[GitHub] [beam] amaliujia commented on pull request #11967: [BEAM-9992] | use Sets transform in BeamSQL

[GitBox]

amaliujia commented on pull request #11967:
URL: https://github.com/apache/beam/pull/11967#issuecomment-658460380


   Ok it seems a `NULL` value handling problem (causing a crashing on program 
execution).
   
   Can you log the java execution stack in BEAM-9992 and we can continue 
discussion there?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [beam] amaliujia commented on pull request #11967: [BEAM-9992] | use Sets transform in BeamSQL

[GitBox]

amaliujia commented on pull request #11967:
URL: https://github.com/apache/beam/pull/11967#issuecomment-655707048


   @darshanj  
   
   I believe your implementation will break this query (at least from ZetaSQL 
dialect path)
   
   ```
   SELECT DISTINCT val.BYTES
   from (select b"1" BYTES union all
 select cast(NULL as bytes) union all
 select b"-1" union all
 select b"1" union all
 select cast(NULL as bytes)) val
   ```



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [beam] amaliujia commented on pull request #11967: [BEAM-9992] | use Sets transform in BeamSQL

[GitBox]

amaliujia commented on pull request #11967:
URL: https://github.com/apache/beam/pull/11967#issuecomment-643679910







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [beam] amaliujia commented on pull request #11967: [BEAM-9992] | use Sets transform in BeamSQL

[GitBox]

amaliujia commented on pull request #11967:
URL: https://github.com/apache/beam/pull/11967#issuecomment-643662786


   retest this please



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [beam] amaliujia commented on pull request #11967: [BEAM-9992] | use Sets transform in BeamSQL

[GitBox]

amaliujia commented on pull request #11967:
URL: https://github.com/apache/beam/pull/11967#issuecomment-643661874


   retest this please



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [beam] amaliujia commented on pull request #11967: [BEAM-9992] | use Sets transform in BeamSQL

[GitBox]

amaliujia commented on pull request #11967:
URL: https://github.com/apache/beam/pull/11967#issuecomment-643479230


   @darshanj could you rebase this PR please?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [beam] amaliujia commented on pull request #11967: [BEAM-9992] | use Sets transform in BeamSQL

[GitBox]

amaliujia commented on pull request #11967:
URL: https://github.com/apache/beam/pull/11967#issuecomment-642159934


   I will also try to run this PR against internal test suite since it is a big 
change.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org