[GitHub] [beam] davidcavazos commented on pull request #12252: [BEAM-7390] Add combineglobally code snippets

2020-07-15 Thread GitBox 


davidcavazos commented on pull request #12252:
URL: https://github.com/apache/beam/pull/12252#issuecomment-658939252


   I also noticed that the output tags were a little misleading now since we 
are showing the stdout instead of an output PCollection



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [beam] davidcavazos commented on pull request #12252: [BEAM-7390] Add combineglobally code snippets

2020-07-15 Thread GitBox 


davidcavazos commented on pull request #12252:
URL: https://github.com/apache/beam/pull/12252#issuecomment-658937924


   @aaltay I've addressed the comments



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [beam] davidcavazos commented on pull request #12252: [BEAM-7390] Add combineglobally code snippets

2020-07-15 Thread GitBox 


davidcavazos commented on pull request #12252:
URL: https://github.com/apache/beam/pull/12252#issuecomment-658891683


   Staged: 
http://apache-beam-website-pull-requests.storage.googleapis.com/12252/documentation/transforms/python/aggregation/combineglobally/index.html



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org