[GitHub] [beam] jmcomets commented on pull request #12173: [BEAM-XXX] JdbcIO - Allow customization of the PoolableDataSource's pool

2020-07-09 Thread GitBox 


jmcomets commented on pull request #12173:
URL: https://github.com/apache/beam/pull/12173#issuecomment-656090239


   Closing this as I found a way to inject the pool generically, using 
`withDataSourceProviderFn(...)`. IMO one of either methods should be available, 
it took me a while before figuring out how to workaround this issue.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [beam] jmcomets commented on pull request #12173: [BEAM-XXX] JdbcIO - Allow customization of the PoolableDataSource's pool

2020-07-06 Thread GitBox 


jmcomets commented on pull request #12173:
URL: https://github.com/apache/beam/pull/12173#issuecomment-654291827


   R: @jbonofre Should be all good now! ;)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org