[GitHub] [beam] kgabryje commented on pull request #11796: [BEAM-10003] Use local code for building code samples on website

2020-05-27 Thread GitBox 


kgabryje commented on pull request #11796:
URL: https://github.com/apache/beam/pull/11796#issuecomment-634835006


   I see that the precommits failed because changes from this PR were out of 
sync with current master. Now they should pass



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [beam] kgabryje commented on pull request #11796: [BEAM-10003] Use local code for building code samples on website

2020-05-25 Thread GitBox 


kgabryje commented on pull request #11796:
URL: https://github.com/apache/beam/pull/11796#issuecomment-633544900


   I followed Hugo's convention here, which doesn't use `/` prefix for paths. 
However, if you think it would be more clear for the Beam community then I can 
change it 🙂 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [beam] kgabryje commented on pull request #11796: [BEAM-10003] Use local code for building code samples on website

2020-05-22 Thread GitBox 


kgabryje commented on pull request #11796:
URL: https://github.com/apache/beam/pull/11796#issuecomment-632648552


   Hi @rezarokni , this PR solves the issue submitted by you. Can you take a 
look?
   Also @pabloem , I'd appreciate if you took a look as well.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org