[GitHub] [beam] lostluck commented on pull request #11782: [BEAM-10056] Fix validation for struct CoGBKs

2020-05-22 Thread GitBox 


lostluck commented on pull request #11782:
URL: https://github.com/apache/beam/pull/11782#issuecomment-632807038


   I like that the tests are very nicely separated for the different cases eg. 
Unknown being more permissive than any of the stricter checks. Well done!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [beam] lostluck commented on pull request #11782: [BEAM-10056] Fix validation for struct CoGBKs

2020-05-21 Thread GitBox 


lostluck commented on pull request #11782:
URL: https://github.com/apache/beam/pull/11782#issuecomment-632304959


   R: @youngoli 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org