[GitHub] [beam] mxm commented on pull request #11777: [BEAM-10054] Fix watermark hold for on_time_pane
mxm commented on pull request #11777: URL: https://github.com/apache/beam/pull/11777#issuecomment-638750806 Since the test has been added and this was the missing piece here, I'm going to merge. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [beam] mxm commented on pull request #11777: [BEAM-10054] Fix watermark hold for on_time_pane
mxm commented on pull request #11777: URL: https://github.com/apache/beam/pull/11777#issuecomment-638146606 Please note that the fix commit is the parent of the commit which introduced the test. So you'll see the test commit fail and the fix commit pass. GitHub sorts by timestamps which makes this non-obvious. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [beam] mxm commented on pull request #11777: [BEAM-10054] Fix watermark hold for on_time_pane
mxm commented on pull request #11777: URL: https://github.com/apache/beam/pull/11777#issuecomment-638145542 Probably not. I finally managed to produce a very trimmed down version of the pipeline for which the execution still stalls. Please have a look. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [beam] mxm commented on pull request #11777: [BEAM-10054] Fix watermark hold for on_time_pane
mxm commented on pull request #11777: URL: https://github.com/apache/beam/pull/11777#issuecomment-634610378 This should be covered by the tests added in the PR which introduced the changes: https://github.com/apache/beam/pull/10304. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [beam] mxm commented on pull request #11777: [BEAM-10054] Fix watermark hold for on_time_pane
mxm commented on pull request #11777: URL: https://github.com/apache/beam/pull/11777#issuecomment-632572299 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [beam] mxm commented on pull request #11777: [BEAM-10054] Fix watermark hold for on_time_pane in DirectRunner
mxm commented on pull request #11777: URL: https://github.com/apache/beam/pull/11777#issuecomment-632181899 Please have a look @rohdesamuel if you consider the fix valid. I'm not very familiar with the Python SDK triggering code. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [beam] mxm commented on pull request #11777: [BEAM-10054] Fix watermark hold for on_time_pane in DirectRunner
mxm commented on pull request #11777: URL: https://github.com/apache/beam/pull/11777#issuecomment-632181118 R: @rohdesamuel This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
