[GitHub] [beam] mxm commented on pull request #12576: [BEAM-10671] Add environment configuration fields as first-class pipeline options.

2020-09-30 Thread GitBox 


mxm commented on pull request #12576:
URL: https://github.com/apache/beam/pull/12576#issuecomment-701245561


   Run Python PreCommit



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [beam] mxm commented on pull request #12576: [BEAM-10671] Add environment configuration fields as first-class pipeline options.

2020-09-30 Thread GitBox 


mxm commented on pull request #12576:
URL: https://github.com/apache/beam/pull/12576#issuecomment-701244754


   Run Portable_Python PreCommit



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [beam] mxm commented on pull request #12576: [BEAM-10671] Add environment configuration fields as first-class pipeline options.

2020-09-15 Thread GitBox 


mxm commented on pull request #12576:
URL: https://github.com/apache/beam/pull/12576#issuecomment-692877960


   Thanks! I'll have another look tomorrow but generally looks good to me. 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org