robinyqiu commented on pull request #12120:
URL: https://github.com/apache/beam/pull/12120#issuecomment-651426652
The new ZetaSQL `DATE` and `TIME` types use Beam logical types. Currently
Beam SQL transforms operate on the **base types** of logical types. This
produces incorrect result because **input types** are often expected. In
addition, after https://github.com/apache/beam/pull/11074 values of input type
are stored in `Row`s. I think we should leverage that change to avoid
unnecessary conversion to base types for better performance, instead of forcing
the use of base types.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
