[GitHub] [beam] veblush commented on pull request #11651: [BEAM-8889] Upgrades gcsio to 2.1.3
veblush commented on pull request #11651: URL: https://github.com/apache/beam/pull/11651#issuecomment-631882467 Thanks, Brian and Chamikara! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [beam] veblush commented on pull request #11651: [BEAM-8889] Upgrades gcsio to 2.1.3
veblush commented on pull request #11651: URL: https://github.com/apache/beam/pull/11651#issuecomment-631815316 Thanks for running the test and the result doesn't make sense because this change won't introduce any runtime behavior other than dependency. Is it possible to be caused by flaky environment? Can we rerun the test again? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [beam] veblush commented on pull request #11651: [BEAM-8889] Upgrades gcsio to 2.1.3
veblush commented on pull request #11651: URL: https://github.com/apache/beam/pull/11651#issuecomment-631632732 This is the result of linkage chekcer. (it was challenging because it seems to require Java8 strictly to finish it smoothly) ``` # /bin/bash sdks/java/build-tools/beam-linkage-check.sh (omitted) Wed May 20 17:57:11 UTC 2020: Done: 0 No new linkage errors ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [beam] veblush commented on pull request #11651: [BEAM-8889] Upgrades gcsio to 2.1.3
veblush commented on pull request #11651: URL: https://github.com/apache/beam/pull/11651#issuecomment-631065488 It turns out that `grpc-netty` and `grpc-netty-shaded` can coexist. So I'm trying to list those new dependencies in the build file to make gRPC component have the same version. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [beam] veblush commented on pull request #11651: [BEAM-8889] Upgrades gcsio to 2.1.3
veblush commented on pull request #11651: URL: https://github.com/apache/beam/pull/11651#issuecomment-631025815 This is most likely caused by gcsio 2.1.3 dependency to `grpc-netty-shaded` ([ref](https://mvnrepository.com/artifact/com.google.cloud.bigdataoss/gcsio/2.1.3)). Meanwhile, Beam uses `grpc_netty` so it happens to have the same netty library in two different forms. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [beam] veblush commented on pull request #11651: [BEAM-8889] Upgrades gcsio to 2.1.3
veblush commented on pull request #11651:
URL: https://github.com/apache/beam/pull/11651#issuecomment-631024519
It appears that it actually has a problem with dependency.
Java PostCommit /
[testReadEmptySketchFromBigQuery](https://builds.apache.org/job/beam_PostCommit_Java_PR/366/testReport/junit/org.apache.beam.sdk.extensions.zetasketch/BigQueryHllSketchCompatibilityIT/testReadEmptySketchFromBigQuery/)
```
Caused by: java.lang.NoSuchFieldError: NETTY_SHADED
at
io.grpc.netty.shaded.io.grpc.netty.NettyClientStream.(NettyClientStream.java:59)
at
io.grpc.netty.shaded.io.grpc.netty.NettyClientTransport.newStream(NettyClientTransport.java:177)
at
io.grpc.internal.MetadataApplierImpl.apply(MetadataApplierImpl.java:70)
at io.grpc.CallCredentials2$1.apply(CallCredentials2.java:61)
at
io.grpc.auth.GoogleAuthLibraryCallCredentials$1.onSuccess(GoogleAuthLibraryCallCredentials.java:133)
at
com.google.auth.oauth2.OAuth2Credentials.getRequestMetadata(OAuth2Credentials.java:134)
at
io.grpc.auth.GoogleAuthLibraryCallCredentials.applyRequestMetadata(GoogleAuthLibraryCallCredentials.java:110)
at
io.grpc.CallCredentials2.applyRequestMetadata(CallCredentials2.java:58)
at
io.grpc.internal.CallCredentialsApplyingTransportFactory$CallCredentialsApplyingTransport.newStream(CallCredentialsApplyingTransportFactory.java:108)
at
io.grpc.internal.ForwardingConnectionClientTransport.newStream(ForwardingConnectionClientTransport.java:49)
at
io.grpc.internal.InternalSubchannel$CallTracingTransport.newStream(InternalSubchannel.java:635)
at
io.grpc.internal.DelayedClientTransport$PendingStream.createRealStream(DelayedClientTransport.java:353)
at
io.grpc.internal.DelayedClientTransport$PendingStream.access$300(DelayedClientTransport.java:341)
at
io.grpc.internal.DelayedClientTransport$5.run(DelayedClientTransport.java:300)
```
Java PostCommit /
[SpannerWriteIT/testWrite_2](https://builds.apache.org/job/beam_PostCommit_Java_PR/366/testReport/junit/org.apache.beam.sdk.io.gcp.spanner/SpannerWriteIT/testWrite_2/)
```
Caused by: java.lang.NoClassDefFoundError: Could not initialize class
io.grpc.netty.shaded.io.grpc.netty.NettyClientStream
at
io.grpc.netty.shaded.io.grpc.netty.NettyClientTransport.newStream(NettyClientTransport.java:177)
at
io.grpc.internal.MetadataApplierImpl.apply(MetadataApplierImpl.java:70)
at io.grpc.CallCredentials2$1.apply(CallCredentials2.java:61)
at
io.grpc.auth.GoogleAuthLibraryCallCredentials$1.onSuccess(GoogleAuthLibraryCallCredentials.java:133)
at
com.google.auth.oauth2.OAuth2Credentials.getRequestMetadata(OAuth2Credentials.java:134)
at
io.grpc.auth.GoogleAuthLibraryCallCredentials.applyRequestMetadata(GoogleAuthLibraryCallCredentials.java:110)
at
io.grpc.CallCredentials2.applyRequestMetadata(CallCredentials2.java:58)
at
io.grpc.internal.CallCredentialsApplyingTransportFactory$CallCredentialsApplyingTransport.newStream(CallCredentialsApplyingTransportFactory.java:108)
at
io.grpc.internal.ForwardingConnectionClientTransport.newStream(ForwardingConnectionClientTransport.java:49)
at
io.grpc.internal.InternalSubchannel$CallTracingTransport.newStream(InternalSubchannel.java:635)
at
io.grpc.internal.DelayedClientTransport$PendingStream.createRealStream(DelayedClientTransport.java:353)
at
io.grpc.internal.DelayedClientTransport$PendingStream.access$300(DelayedClientTransport.java:341)
at
io.grpc.internal.DelayedClientTransport$5.run(DelayedClientTransport.java:300)
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [beam] veblush commented on pull request #11651: [BEAM-8889] Upgrades gcsio to 2.1.3
veblush commented on pull request #11651: URL: https://github.com/apache/beam/pull/11651#issuecomment-630948467 No performance regression with this change. (Tested with internal tests) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
