Re: [PR] Clean up stale code in BigtableService [beam]
Abacn merged PR #30172: URL: https://github.com/apache/beam/pull/30172 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Clean up stale code in BigtableService [beam]
github-actions[bot] commented on PR #30172: URL: https://github.com/apache/beam/pull/30172#issuecomment-2126958710 Reminder, please take a look at this pr: @Abacn @Abacn @igorbernstein2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Clean up stale code in BigtableService [beam]
Abacn commented on PR #30172: URL: https://github.com/apache/beam/pull/30172#issuecomment-2112840886 This one has taken long. Going to merge it in 24 hrs if no other concern -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Clean up stale code in BigtableService [beam]
github-actions[bot] commented on PR #30172: URL: https://github.com/apache/beam/pull/30172#issuecomment-2106226798 Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment `assign to next reviewer`: R: @Abacn for label java. R: @Abacn for label io. R: @igorbernstein2 for label bigtable. Available commands: - `stop reviewer notifications` - opt out of the automated review tooling - `remind me after tests pass` - tag the comment author after tests pass - `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Clean up stale code in BigtableService [beam]
github-actions[bot] commented on PR #30172: URL: https://github.com/apache/beam/pull/30172#issuecomment-2100440804 Reminder, please take a look at this pr: @robertwb @ahmedabu98 @igorbernstein2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Clean up stale code in BigtableService [beam]
github-actions[bot] commented on PR #30172: URL: https://github.com/apache/beam/pull/30172#issuecomment-2088382169 Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment `assign to next reviewer`: R: @robertwb for label java. R: @ahmedabu98 for label io. R: @igorbernstein2 for label bigtable. Available commands: - `stop reviewer notifications` - opt out of the automated review tooling - `remind me after tests pass` - tag the comment author after tests pass - `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Clean up stale code in BigtableService [beam]
github-actions[bot] commented on PR #30172: URL: https://github.com/apache/beam/pull/30172#issuecomment-2080508706 Reminder, please take a look at this pr: @kennknowles @damondouglas @igorbernstein2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Clean up stale code in BigtableService [beam]
github-actions[bot] commented on PR #30172: URL: https://github.com/apache/beam/pull/30172#issuecomment-2066444329 Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment `assign to next reviewer`: R: @kennknowles for label java. R: @damondouglas for label io. R: @igorbernstein2 for label bigtable. Available commands: - `stop reviewer notifications` - opt out of the automated review tooling - `remind me after tests pass` - tag the comment author after tests pass - `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Clean up stale code in BigtableService [beam]
github-actions[bot] commented on PR #30172: URL: https://github.com/apache/beam/pull/30172#issuecomment-2061119369 Reminder, please take a look at this pr: @robertwb @Abacn @igorbernstein2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Clean up stale code in BigtableService [beam]
github-actions[bot] commented on PR #30172: URL: https://github.com/apache/beam/pull/30172#issuecomment-2045016335 Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment `assign to next reviewer`: R: @robertwb for label java. R: @Abacn for label io. R: @igorbernstein2 for label bigtable. Available commands: - `stop reviewer notifications` - opt out of the automated review tooling - `remind me after tests pass` - tag the comment author after tests pass - `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Clean up stale code in BigtableService [beam]
github-actions[bot] commented on PR #30172: URL: https://github.com/apache/beam/pull/30172#issuecomment-2037019465 Reminder, please take a look at this pr: @kennknowles @chamikaramj @igorbernstein2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Clean up stale code in BigtableService [beam]
github-actions[bot] commented on PR #30172: URL: https://github.com/apache/beam/pull/30172#issuecomment-2022622576 Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment `assign to next reviewer`: R: @kennknowles for label java. R: @chamikaramj for label io. R: @igorbernstein2 for label bigtable. Available commands: - `stop reviewer notifications` - opt out of the automated review tooling - `remind me after tests pass` - tag the comment author after tests pass - `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Clean up stale code in BigtableService [beam]
github-actions[bot] commented on PR #30172: URL: https://github.com/apache/beam/pull/30172#issuecomment-2016474867 Reminder, please take a look at this pr: @damondouglas @johnjcasey @igorbernstein2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Clean up stale code in BigtableService [beam]
damondouglas commented on PR #30172: URL: https://github.com/apache/beam/pull/30172#issuecomment-2001466972 @mutianf LGTM, would you like me to merge this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Clean up stale code in BigtableService [beam]
github-actions[bot] commented on PR #30172: URL: https://github.com/apache/beam/pull/30172#issuecomment-1999539644 Reminder, please take a look at this pr: @damondouglas @johnjcasey @igorbernstein2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Clean up stale code in BigtableService [beam]
damondouglas commented on PR #30172: URL: https://github.com/apache/beam/pull/30172#issuecomment-1984097875 @mutianf I'll have a look at it. Apologies for your wait. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Clean up stale code in BigtableService [beam]
github-actions[bot] commented on PR #30172: URL: https://github.com/apache/beam/pull/30172#issuecomment-1983384303 Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment `assign to next reviewer`: R: @damondouglas for label java. R: @johnjcasey for label io. R: @igorbernstein2 for label bigtable. Available commands: - `stop reviewer notifications` - opt out of the automated review tooling - `remind me after tests pass` - tag the comment author after tests pass - `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Clean up stale code in BigtableService [beam]
github-actions[bot] commented on PR #30172: URL: https://github.com/apache/beam/pull/30172#issuecomment-1976450449 Reminder, please take a look at this pr: @Abacn @chamikaramj @igorbernstein2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Clean up stale code in BigtableService [beam]
github-actions[bot] commented on PR #30172: URL: https://github.com/apache/beam/pull/30172#issuecomment-1964007271 Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment `assign to next reviewer`: R: @Abacn for label java. R: @chamikaramj for label io. R: @igorbernstein2 for label bigtable. Available commands: - `stop reviewer notifications` - opt out of the automated review tooling - `remind me after tests pass` - tag the comment author after tests pass - `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Clean up stale code in BigtableService [beam]
github-actions[bot] commented on PR #30172: URL: https://github.com/apache/beam/pull/30172#issuecomment-1956521520 Reminder, please take a look at this pr: @kennknowles @damondouglas @igorbernstein2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Clean up stale code in BigtableService [beam]
github-actions[bot] commented on PR #30172: URL: https://github.com/apache/beam/pull/30172#issuecomment-1941382197 Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment `assign to next reviewer`: R: @kennknowles for label java. R: @damondouglas for label io. R: @igorbernstein2 for label bigtable. Available commands: - `stop reviewer notifications` - opt out of the automated review tooling - `remind me after tests pass` - tag the comment author after tests pass - `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Clean up stale code in BigtableService [beam]
github-actions[bot] commented on PR #30172: URL: https://github.com/apache/beam/pull/30172#issuecomment-1935822282 Reminder, please take a look at this pr: @bvolpato @chamikaramj @igorbernstein2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Clean up stale code in BigtableService [beam]
Abacn commented on PR #30172: URL: https://github.com/apache/beam/pull/30172#issuecomment-1921952952 Are these "stale code" not used in Beam, i.e., there is currently no way to make this code in effect; or it's not needed? If it still can make some effect on Beam I would suggests defer the clean up until we see the issue no longer exist for a time period -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Clean up stale code in BigtableService [beam]
github-actions[bot] commented on PR #30172: URL: https://github.com/apache/beam/pull/30172#issuecomment-1920055272 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @bvolpato for label java. R: @chamikaramj for label io. R: @igorbernstein2 for label bigtable. Available commands: - `stop reviewer notifications` - opt out of the automated review tooling - `remind me after tests pass` - tag the comment author after tests pass - `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers) The PR bot will only process comments in the main thread (not review comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
