Re: [I] Overflow bug in POW scalar function (found by SQLancer) [datafusion]

2024-06-23 Thread via GitHub


LorrensP-2158466 commented on issue #11075:
URL: https://github.com/apache/datafusion/issues/11075#issuecomment-2185083331

   > Now that only just a few types/functions have been fuzzed, I'm expecting 
more function-local bugs to appear.
   
   That's right, fixing GCD & LCM was very local, only to the actual 
implementation of the algorithm, the API already allowed to return error's. I 
expect that will also be the case for the others.
   
   Thanks! You have made a very cool tool, because I would have never thought 
about this, and I think a lot of other neither.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org



Re: [I] Overflow bug in POW scalar function (found by SQLancer) [datafusion]

2024-06-23 Thread via GitHub


LorrensP-2158466 commented on issue #11075:
URL: https://github.com/apache/datafusion/issues/11075#issuecomment-2184998761

   this is the third, scalar function that panics instead of returning an 
error, maybe it's a good idea to open up a separate tracking issue to find all 
of these cases?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org



Re: [I] Overflow bug in POW scalar function (found by SQLancer) [datafusion]

2024-06-23 Thread via GitHub


LorrensP-2158466 commented on issue #11075:
URL: https://github.com/apache/datafusion/issues/11075#issuecomment-2184998506

   take


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org



[I] Overflow bug in POW scalar function (found by SQLancer) [datafusion]

2024-06-23 Thread via GitHub


2010YOUY01 opened a new issue, #11075:
URL: https://github.com/apache/datafusion/issues/11075

   ### Describe the bug
   
   The following statement should return an error instead of directly crash
   ```shell
   DataFusion CLI v39.0.0
   > select pow(2107754225, 1221660777);
   thread 'main' panicked at 
/rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/core/src/num/mod.rs:358:5:
   attempt to multiply with overflow
   note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
   ```
   
   Found by SQLancer https://github.com/apache/datafusion/issues/11030
   
   ### To Reproduce
   
   _No response_
   
   ### Expected behavior
   
   _No response_
   
   ### Additional context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org