Re: [I] Support convert LogicalPlan JOIN with `Using` constraint to SQL String [datafusion]
alamb closed issue #10652: Support convert LogicalPlan JOIN with `Using` constraint to SQL String URL: https://github.com/apache/datafusion/issues/10652 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
Re: [I] Support convert LogicalPlan JOIN with `Using` constraint to SQL String [datafusion]
alamb commented on issue #10652: URL: https://github.com/apache/datafusion/issues/10652#issuecomment-2131211386 > Is there any plan to support them? I think we should make plans to support them! I started collecting issues on https://github.com/apache/datafusion/issues/8661 I also filed https://github.com/apache/datafusion/issues/10663 https://github.com/apache/datafusion/issues/10664 to track distint and window Looking at https://github.com/apache/datafusion/blob/8bedecc00b2f1f04d7b1a907152ce0d19b7046a5/datafusion/sql/src/unparser/plan.rs#L83-L91 it actually looks like there are seveal other types of plans not yet supported (like EXPLAIN, INSERT, etc...) Maybe we should file tickets for them as well -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
Re: [I] Support convert LogicalPlan JOIN with `Using` constraint to SQL String [datafusion]
goldmedal commented on issue #10652: URL: https://github.com/apache/datafusion/issues/10652#issuecomment-2129764802 By the way, I saw there're other unimplemented plans in `plan.rs`: - Distinct - Union - Window - Extension (I guess we need to provide some method for `UserDefinedLogicalNodeCore`) Is there any plan to support them? gentle ping @alamb -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
[I] Support convert LogicalPlan JOIN with `Using` constraint to SQL String [datafusion]
goldmedal opened a new issue, #10652:
URL: https://github.com/apache/datafusion/issues/10652
### Is your feature request related to a problem or challenge?
We only support to convert JOIN with `ON` constraint to SQL String now. The
SQL as below can't be converted now.
```
SELECT * FROM orders JOIN customer USING (custkey)
```
It will panic with the message:
```
NotImplemented("Unsupported join constraint: Using")
```
### Describe the solution you'd like
The unparse rule for `JOIN` in `datafusion/sql/src/unparser/plan.rs` should
be implemented.
https://github.com/apache/datafusion/blob/8bedecc00b2f1f04d7b1a907152ce0d19b7046a5/datafusion/sql/src/unparser/plan.rs#L277-L285
### Describe alternatives you've considered
_No response_
### Additional context
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
