Re: [PR] Jdk 11 in readme [datafusion-comet]
viirya commented on code in PR #366: URL: https://github.com/apache/datafusion-comet/pull/366#discussion_r1586603568 ## README.md: ## @@ -63,7 +63,7 @@ Linux, Apple OSX (Intel and M1) ## Requirements - Apache Spark 3.2, 3.3, or 3.4 -- JDK 8 and up +- JDK 11 and up (JDK 8 should be supported, but development is on JDK 11) Review Comment: I think for sure option is to use supported JDKs with the Spark version you are working on. It is good to have it clean here to reduce confusion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
Re: [PR] Jdk 11 in readme [datafusion-comet]
viirya commented on PR #366: URL: https://github.com/apache/datafusion-comet/pull/366#issuecomment-2088874522 Thanks @edmondop -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
Re: [PR] Jdk 11 in readme [datafusion-comet]
andygrove commented on code in PR #366: URL: https://github.com/apache/datafusion-comet/pull/366#discussion_r1586574363 ## README.md: ## @@ -63,7 +63,7 @@ Linux, Apple OSX (Intel and M1) ## Requirements - Apache Spark 3.2, 3.3, or 3.4 -- JDK 8 and up +- JDK 11 and up (JDK 8 should be supported, but development is on JDK 11) Review Comment: I think we should say that we only support 8, 11, and 17 rather than say JDK 11 and up. We do not support JDK 21 for example (neither does Spark 3.x). I think we should recommend 11 for now because Spark 3.2 does not support JDK 17 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
[PR] Jdk 11 in readme [datafusion-comet]
edmondop opened a new pull request, #366: URL: https://github.com/apache/datafusion-comet/pull/366 ## Which issue does this PR close? Closes #. ## Rationale for this change ## What changes are included in this PR? ## How are these changes tested? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
