Re: [PR] fix: limit with offset should return correct results [datafusion-comet]
viirya commented on code in PR #359: URL: https://github.com/apache/datafusion-comet/pull/359#discussion_r1586759865 ## spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala: ## @@ -340,7 +340,7 @@ class CometSparkSessionExtensions op } -case op: LocalLimitExec => +case op: LocalLimitExec if getOffset(op) == 0 => Review Comment: Oh, I missed it. I will create a follow up. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
Re: [PR] fix: limit with offset should return correct results [datafusion-comet]
parthchandra commented on code in PR #359: URL: https://github.com/apache/datafusion-comet/pull/359#discussion_r1586750015 ## spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala: ## @@ -340,7 +340,7 @@ class CometSparkSessionExtensions op } -case op: LocalLimitExec => +case op: LocalLimitExec if getOffset(op) == 0 => Review Comment: Add a `withInfo` for the case when `offset > 0` ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
Re: [PR] fix: limit with offset should return correct results [datafusion-comet]
viirya commented on PR #359: URL: https://github.com/apache/datafusion-comet/pull/359#issuecomment-2087956677 Merged. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
Re: [PR] fix: limit with offset should return correct results [datafusion-comet]
viirya merged PR #359: URL: https://github.com/apache/datafusion-comet/pull/359 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
Re: [PR] fix: limit with offset should return correct results [datafusion-comet]
viirya commented on PR #359: URL: https://github.com/apache/datafusion-comet/pull/359#issuecomment-2087787026 cc @sunchao @andygrove -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
[PR] fix: limit with offset should return correct results [datafusion-comet]
viirya opened a new pull request, #359: URL: https://github.com/apache/datafusion-comet/pull/359 ## Which issue does this PR close? Closes #358. ## Rationale for this change ## What changes are included in this PR? ## How are these changes tested? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
