Re: [PR] Change no-statement error message to be clearer [datafusion]
alamb commented on PR #11394: URL: https://github.com/apache/datafusion/pull/11394#issuecomment-2221190066 > @alamb thank you for catching that - I guess I forgot to run it earlier. All should be good now. LOL -- well the CI checks caught it, I just figured I would point it out in case you hadn't seen it (I am not really sure how other people have their github alert settings configured. I get a 🚒 hose so miss stuff sometimes) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
Re: [PR] Change no-statement error message to be clearer [datafusion]
itsjunetime commented on PR #11394: URL: https://github.com/apache/datafusion/pull/11394#issuecomment-2221066292 @alamb thank you for catching that - I guess I forgot to run it earlier. All should be good now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
Re: [PR] Change no-statement error message to be clearer [datafusion]
alamb commented on PR #11394: URL: https://github.com/apache/datafusion/pull/11394#issuecomment-2221062458 @itsjunetime it appears that the CI job https://github.com/apache/datafusion/actions/runs/9877944034/job/27282735257?pr=11394 failed I think you can resolve this by doing `cargo fmt` and pushing the result -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
Re: [PR] Change no-statement error message to be clearer [datafusion]
alamb commented on PR #11394: URL: https://github.com/apache/datafusion/pull/11394#issuecomment-2221052528 Thanks @itsjunetime ! I started the CI on this PR -- once that passes I think this PR will be good to go. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
