Re: [PR] Enable `clone_on_ref_ptr` clippy lint on physical-expr crate [datafusion]
alamb commented on PR #11240: URL: https://github.com/apache/datafusion/pull/11240#issuecomment-2210812373 Thanks again @lewiszlw and @ozankabak -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
Re: [PR] Enable `clone_on_ref_ptr` clippy lint on physical-expr crate [datafusion]
alamb merged PR #11240: URL: https://github.com/apache/datafusion/pull/11240 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
Re: [PR] Enable `clone_on_ref_ptr` clippy lint on physical-expr crate [datafusion]
ozankabak commented on PR #11240: URL: https://github.com/apache/datafusion/pull/11240#issuecomment-2210759239 Let's merge this today. We can do the other big PR towards the end of the next week to give everyone some time in between. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
Re: [PR] Enable `clone_on_ref_ptr` clippy lint on physical-expr crate [datafusion]
alamb commented on PR #11240: URL: https://github.com/apache/datafusion/pull/11240#issuecomment-2210748052 Since this PR is likely to accumulate merge conflicts over time, I think we should probably merge it in relatively soon I took the liberty of merging up from main and resolving a bunch of conflicts cc @ozankabak what do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
