Re: [PR] Migrate more code from `Expr::to_columns` to `Expr::column_refs` [datafusion]
comphead merged PR #11067: URL: https://github.com/apache/datafusion/pull/11067 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
Re: [PR] Migrate more code from `Expr::to_columns` to `Expr::column_refs` [datafusion]
alamb commented on code in PR #11067: URL: https://github.com/apache/datafusion/pull/11067#discussion_r1650060628 ## datafusion/optimizer/src/utils.rs: ## @@ -66,6 +66,16 @@ pub fn optimize_children( } } +/// Returns true if all columns in col_refs are in `schema_cols` +/// +/// Note: can't use `HashSet::intersect` here because they have different types. +pub(crate) fn has_all_refs( Review Comment: in d4346f384b5a843997a9c0fcb37878b5007a024e -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
Re: [PR] Migrate more code from `Expr::to_columns` to `Expr::column_refs` [datafusion]
comphead commented on code in PR #11067: URL: https://github.com/apache/datafusion/pull/11067#discussion_r1649769840 ## datafusion/optimizer/src/utils.rs: ## @@ -66,6 +66,16 @@ pub fn optimize_children( } } +/// Returns true if all columns in col_refs are in `schema_cols` +/// +/// Note: can't use `HashSet::intersect` here because they have different types. +pub(crate) fn has_all_refs( Review Comment: maybe we can rename it to better reflect `if all columns in col_refs are in `schema_cols` ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
