Re: [PR] Replace println! with assert! if possible in DataFusion examples [datafusion]
alamb merged PR #11237: URL: https://github.com/apache/datafusion/pull/11237 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
Re: [PR] Replace println! with assert! if possible in DataFusion examples [datafusion]
alamb commented on PR #11237: URL: https://github.com/apache/datafusion/pull/11237#issuecomment-2211021041 Thanks again @Nishi46 and @findepi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
Re: [PR] Replace println! with assert! if possible in DataFusion examples [datafusion]
alamb commented on code in PR #11237:
URL: https://github.com/apache/datafusion/pull/11237#discussion_r1666725266
##
datafusion-examples/examples/sql_analysis.rs:
##
@@ -280,9 +280,11 @@ from
// We can create a LogicalPlan from a SQL query like this
let logical_plan = ctx.sql(tpcds_query_88).await?.into_optimized_plan()?;
-println!(
-"Optimized Logical Plan:\n\n{}\n",
-logical_plan.display_indent()
+assert_eq!(
+logical_plan.display_indent().to_string(),
Review Comment:
this actual plan is quite a bit more complicated than shown here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
Re: [PR] Replace println! with assert! if possible in DataFusion examples [datafusion]
findepi commented on PR #11237: URL: https://github.com/apache/datafusion/pull/11237#issuecomment-2207202123 please run `cargo fmt` to fix CI errors -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
