Re: [Github-comments] [geany/geany] Multipaste (#2328)
elextr commented on this pull request. > @@ -56,162 +57,162 @@ void > sci_set_current_position(ScintillaObject *sci, gint position, gboolean gint sci_get_selection_start (ScintillaObject *sci); gint sci_get_selection_end (ScintillaObject *sci); -void sci_replace_sel (ScintillaObject *sci, const gchar *text); +void sci_replace_sel (ScintillaObject *sci, const gchar *text); Yeah, but to return it to its original state only needs `git checkout src/sciwrappers.h`. There was so much noise I didn't even notice that there was an actual change. @b4n did better. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2328#discussion_r329870111
Re: [Github-comments] [geany/geany-plugins] No debugger in Geany 1.36 (#913)
If Geany is compiled when VTE headers are not available then VTE support in Geany must be disabled since it has no way of knowing what the interface to VTE is. The Autotools build does that automatically. You could report it to Arch to see if they can build their binary different. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/913#issuecomment-536846701
Re: [Github-comments] [geany/geany-plugins] No debugger in Geany 1.36 (#913)
You right,but in Arch the issue it's about binary compiled without VTE. Dosen't matter you have VTE or not,in binary it's disabled. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/913#issuecomment-536800128
Re: [Github-comments] [geany/geany] [WIP] Build: Separate geany.conf/project non-filetype execute commands from FT execute (#2307)
> Not sure what travis is whinging about for Linux builds Google says we need to add the key or use a newer Ubuntu version. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2307#issuecomment-536797761
Re: [Github-comments] [geany/geany] Multipaste (#2328)
codebrainz commented on this pull request. > @@ -56,162 +57,162 @@ void > sci_set_current_position(ScintillaObject *sci, gint position, gboolean gint sci_get_selection_start (ScintillaObject *sci); gint sci_get_selection_end (ScintillaObject *sci); -void sci_replace_sel (ScintillaObject *sci, const gchar *text); +void sci_replace_sel (ScintillaObject *sci, const gchar *text); To be fair, aligning stuff like this (GNU/GTK+-style) is a terrible idea, especially when tabs are used. Not sure why this one file in Geany uses this alignment style. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2328#discussion_r329830688
Re: [Github-comments] [geany/geany] [WIP] Build: Separate geany.conf/project non-filetype execute commands from FT execute (#2307)
Not sure what travis is whinging about for Linux builds, doesn't look like anything you did. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2307#issuecomment-536795494
Re: [Github-comments] [geany/geany-plugins] No debugger in Geany 1.36 (#913)
> But issue is installation via standart way in arch. You could report a bug to whoever packages Geany for Arch. I think both Geany and Geany-Plugins packages should depend on VTE library so it gets installed automatically. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/913#issuecomment-536795347
Re: [Github-comments] [geany/geany] [WIP] Build: Separate geany.conf/project non-filetype execute commands from FT execute (#2307)
> So I suggest we merge this to a geany/build-exec branch until GUI editing of > independent execute commands is implemented (in another pull for easier > review). Sounds good to me, I support separate branches for large developments, its just that I'm not so sure how well it will get tested, but lets try. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2307#issuecomment-536794443
Re: [Github-comments] [geany/geany] Multipaste (#2328)
b4n requested changes on this pull request.
With a quick test, I agree that changing the behavior makes sense and is mostly
compatible.
For the implementation part, I think this should be all what's needed (no need
for a new Scintilla wrapper for something only used once in *editor.c*, and the
function shouldn't be exposed in the headers anyway):
```diff
>From 9b503708203a4986736da33d882f695dee6119c0 Mon Sep 17 00:00:00 2001
From: Colomban Wendling
Date: Mon, 30 Sep 2019 20:09:12 +0200
Subject: [PATCH] Enable multi-selection clipboard paste
When pasting a single-line clipboard content inside multiple or
rectangular selections, paste it in each selection rather than only
in the main one.
This changes behavior, but the old behavior is easily reproduced by
canceling a multiple selection when a single paste is desired, whereas
it was not possible to obtain multiple pastes before.
diff --git a/src/editor.c b/src/editor.c
index df25c8808..b02705e36 100644
--- a/src/editor.c
+++ b/src/editor.c
@@ -4940,6 +4940,10 @@ static ScintillaObject *create_new_sci(GeanyEditor
*editor)
#endif
SSM(sci, SCI_SETRECTANGULARSELECTIONMODIFIER,
rectangular_selection_modifier, 0);
+ /* With multiple selections, paste in them all (doesn't affect pasting
+* multi-line data in a rectangular selection) */
+ SSM(sci, SCI_SETMULTIPASTE, SC_MULTIPASTE_EACH, 0);
+
/* virtual space */
SSM(sci, SCI_SETVIRTUALSPACEOPTIONS, editor_prefs.show_virtual_space,
0);
```
I'd be happy to get this through, but I won't open a new PR just yet (hehe) and
I can't push here. Of course I can create a new PR if @elextr's happy with it ;)
> editor->sci = editor_create_widget(editor);
+ sci_set_multipaste(editor->sci, SC_MULTIPASTE_EACH);
This should go in `editor_create_widget()` along the other similar ones.
> @@ -93,6 +93,10 @@ sptr_t sci_send_message_internal (const gchar *file, guint
> line, ScintillaObject
}
#endif
+ /* Set multi paste setting (at 3104 scintilla defaults to SC_MULTIPASTE_ONCE)
*/
+void sci_set_multipaste(ScintillaObject *sci, gint mpval) {
+ SSM(sci, SCI_SETMULTIPASTE, mpval, 0);
+}
We don't actually need a new wrapper for just one call, especially not when
that call is in *editor.c*.
> @@ -39,9 +39,10 @@ sptr_t sci_send_message_internal (const gchar *file, guint
> line, ScintillaObject
# endif
#endif
-void sci_set_text
(ScintillaObject *sci, const gchar *text);
-gboolean sci_has_selection
(ScintillaObject *sci);
-void sci_end_undo_action
(ScintillaObject *sci);
+voidsci_set_multipaste
(ScintillaObject *sci, gint mpval);
This should be in the `GEANY_PRIVATE` section below. Only plugin API functions
should be outside of it.
> @@ -56,162 +57,162 @@ void
> sci_set_current_position(ScintillaObject *sci, gint position, gboolean
gint sci_get_selection_start
(ScintillaObject *sci);
gint sci_get_selection_end
(ScintillaObject *sci);
-void sci_replace_sel
(ScintillaObject *sci, const gchar *text);
+void sci_replace_sel
(ScintillaObject *sci, const gchar *text);
Please don't rewrite unrelated indentation, even if it was incorrect (and here
it's not, Geany uses a tab width of 4, which aligns well). Changes like this
make it a lot harder to read the actual, meaningful changes, and should be made
in a specific commit if at all.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2328#pullrequestreview-295163357
Re: [Github-comments] [geany/geany-plugins] No debugger in Geany 1.36 (#913)
You are welcome. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/913#issuecomment-536686905
Re: [Github-comments] [geany/geany-plugins] No debugger in Geany 1.36 (#913)
Closed #913. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/913#event-2674298026
Re: [Github-comments] [geany/geany-plugins] No debugger in Geany 1.36 (#913)
Well.Fixed. For debian\ubuntu need to install libvte-dev for GTK2,libvte-2.91-dev - GTK3 For Arch - need to install package vte3.Then install geany via pacman,and install geany-plugins via building from sources,and it's works. Thank you for help.But issue is installation via standart way in arch.I hope this will help for users who face this problems too. Thank you for you help!!! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/913#issuecomment-536684465
Re: [Github-comments] [geany/geany-plugins] No debugger in Geany 1.36 (#913)
Hmmm...you could try to build ```libvte``` from source. But I have never done it, so I do not know how simple or difficult it is. Maybe you can ask somewhere in the Arch community if they know how to get it or build it on Arch. But without ```libvte``` you cannot build the debugger plugin or the scope plugin. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/913#issuecomment-536675518
Re: [Github-comments] [geany/geany-plugins] No debugger in Geany 1.36 (#913)
Okey,it's works for Debian and Ubuntu,but in Arch is no such thing like libvte at all...any way to do something? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/913#issuecomment-536673918
Re: [Github-comments] [geany/geany-plugins] No debugger in Geany 1.36 (#913)
First, let me inform you that there are two debugger plugins in the Geany-Plugins package you can choose from: - the debugger plugin - the scope plugin If the configure script tells you that the debugger plugin is not enabled than a requirement to build the debugger plugin is missing. It could be that the VTE package is missing on your system. Please follow one of the steps below, depending on your GTK version: - if you are building for GTK2 please try ```sudo apt-get install libvte-dev``` - if you are building for GTK3 please try ```sudo apt-get install libvte-2.91-dev``` After that please run ```./configure``` again. Does it say ```yes``` now? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/913#issuecomment-536662437
Re: [Github-comments] [geany/geany] [WIP] Build: Separate geany.conf/project non-filetype execute commands from FT execute (#2307)
Update: > there are still bugs with the build commands dialog [project filetype] > execute command These have been fixed in the latest commit. The project filetype list (used for saving) was only updated if the *filetype build* commands had been edited. Now it's also updated if the (filetype) execute commands have been edited. I've realised that this pull shouldn't really be merged to master until the commands dialog supports editing independent execute commands. This is because in master, with a project open, editing the dialog's execute field creates a project filetype-independent execute command. Although those commands are not lost with this pull, it would be confusing for them to no longer be visible in the dialog. So I suggest we merge this to a `geany/build-exec` branch until GUI editing of independent execute commands is implemented (in another pull for easier review). BTW ATM Travis has failed due to an unrelated error: ``` The command "sudo apt-get update -qq" failed and exited with 100 during . ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2307#issuecomment-536657536
Re: [Github-comments] [geany/geany] Too Many Filetypes in Open Dropdown! How can I shorten list? (#2296)
@RufusVS You can't do that ATM, I could implement it though. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2296#issuecomment-536649777
Re: [Github-comments] [geany/geany] [WIP] Build: Separate geany.conf/project non-filetype execute commands from FT execute (#2307)
@ntrel pushed 1 commit. 837dbe1237cf3c3edafeda2b98d4e9645ea3cc50 Fix not saving project filetype execute commands after dialog editing -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/geany/geany/pull/2307/files/98fa2d0893e8aa109de2a3e0a234148922d44b6e..837dbe1237cf3c3edafeda2b98d4e9645ea3cc50
[Github-comments] [geany/geany-plugins] No debugger in Geany 1.36 (#913)
No debugger plugin can be found in Plugin Manager,no file installed. On Arch linux - installed geany and geany-plugins via pacman On Debian 10 - Installed via building from sources On Ubuntu 19.04 - installed via building from sources On Ubuntu Studio 19.04 - installed via building from sources. No debugger at all. Where is no errors on installation process,but ./configure describes me - debugger no Sorry for my english.Waiting for help. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/913
Re: [Github-comments] [geany/geany] Add missing HAVE_SOCKET guard on in main_lib() (#2312)
Merged #2312 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2312#event-2673546129
Re: [Github-comments] [geany/geany] Save main and project configuration whenever documents are opened/closed (#2114)
Unfortunately this wasn't merged, even with two approvals and the target milestone 1.36. I'd say merge this quickly so we don't forget it again ;-) @eht16 ? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2114#issuecomment-536592907
Re: [Github-comments] [geany/geany] build.c: enable the Next/Prev Error menu items only when there are build error messages (#2269)
@elextr > this PR also includes changes not relevant to that I've taken those commits out and will submit them separately. OK to merge this? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2269#issuecomment-536587153
Re: [Github-comments] [geany/geany] Add various pref for whether to confirm project close (#2171)
Closed #2171. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2171#event-2673438524
Re: [Github-comments] [geany/geany] Add various pref for whether to confirm project close (#2171)
Closed as #2178 is merged. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2171#issuecomment-536580842
Re: [Github-comments] [geany/geany] Fix static build (99eacb4)
@codebrainz I don't actually know how well this works, I just stumbled on an old build directory configured this way and found this failure. Maybe we could just prevent making a static build, or just ignore it as we don't advertise it; I juts figured this was a very innocent fix if it can be useful for anything. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/commit/99eacb4416b9a0adfed0a1e46ba2740581535fae#commitcomment-35292028
Re: [Github-comments] [geany/geany] Close button for items in the sidebar documents list (#2330)
You can also close the document by clicking on it with the middle mouse button. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2330#issuecomment-536499332
