[Github-comments] [geany/geany-plugins] GeanyVC: Use geanyvc_la_LIBADD to add libs needed for unittests (#977)

2020-05-12 Thread nomadbyte
Fixes #976
You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany-plugins/pull/977

-- Commit Summary --

  * GeanyVC: Use geanyvc_la_LIBADD to add libs needed for unittests

-- File Changes --

M geanyvc/src/Makefile.am (2)

-- Patch Links --

https://github.com/geany/geany-plugins/pull/977.patch
https://github.com/geany/geany-plugins/pull/977.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/977


[Github-comments] [geany/geany-plugins] GeanyVC: build is failing at linking the unittests due to missing gtkspell lib (#976)

2020-05-12 Thread nomadbyte
Looks like the recent build of [90974ab] is failing at linking geanyvc 
unittests due to missing gtkspell lib:

[jobs/685847261](https://travis-ci.org/github/geany/geany-plugins/jobs/685847261#L7195)

```
...
  CCLD unittests
unittests-geanyvc.o: In function `vccommit_activated':
/home/travis/build/geany/geany-plugins/_build/geany-plugins-1.37/_build/geanyvc/src/../../../geanyvc/src/geanyvc.c:1739:
 undefined reference to `gtkspell_new_attach'
collect2: error: ld returned 1 exit status
make[4]: *** [unittests] Error 1
make[4]: Leaving directory 
`/home/travis/build/geany/geany-plugins/_build/geany-plugins-1.37/_build/geanyvc/src'
make[3]: *** [check-am] Error 2
make[3]: Leaving directory 
`/home/travis/build/geany/geany-plugins/_build/geany-plugins-1.37/_build/geanyvc/src'

```

Fix is submitted in  PR.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/976

Re: [Github-comments] [geany/geany] Can't see underscores on Ubuntu 20.04 (#2502)

2020-05-12 Thread Matthew Brush
Since I went spelunking a bit, I shall leave some links - which may or not be 
related - for those who wish to investigate this further:
https://bugs.freedesktop.org/show_bug.cgi?id=43760
https://bugs.freedesktop.org/show_bug.cgi?id=10693
https://bugs.freedesktop.org/show_bug.cgi?id=44624
https://bugs.freedesktop.org/show_bug.cgi?id=96893
https://bugs.freedesktop.org/show_bug.cgi?id=9029
https://bugs.freedesktop.org/show_bug.cgi?id=7223

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2502#issuecomment-627696039

Re: [Github-comments] [geany/geany] Can't see underscores on Ubuntu 20.04 (#2502)

2020-05-12 Thread elextr
I would expect that underscore isn't a simple line, but a filled shape like all 
other characters, so its probably not so simple.  And the issue isn't so much 
drawing the underscore as the next line drawing over it because the line height 
is too small (or the underscore drop is too large).

Anyway the thing is to wait for the Scintilla change to ripple through 
Scintilla LTS branch and into Geany and see if its better (and if other fonts 
are worse :(

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2502#issuecomment-627693457

Re: [Github-comments] [geany/geany] Can't see underscores on Ubuntu 20.04 (#2502)

2020-05-12 Thread Matthew Brush
For reference, I was referring to this:
https://www.cairographics.org/FAQ/#sharp_lines

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2502#issuecomment-627688739

Re: [Github-comments] [geany/geany] Can't see underscores on Ubuntu 20.04 (#2502)

2020-05-12 Thread elextr
I didn't look at the change Neil made, but I think he might have changed a 
truncation to a rounding, but not sure if that was round up/down/nearest.  But 
of course that may just change the perturbation surface to numbers near x.5 not 
numbers near x.0.  It depends on screen resolutions, the font measurements etc 
so there is no simple universal solution like "add 0.5" sadly.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2502#issuecomment-627688205

Re: [Github-comments] [geany/geany] Can't see underscores on Ubuntu 20.04 (#2502)

2020-05-12 Thread Matthew Brush
I saw that thread but didn't really understand what it's about. Can we just 
change the default in Geany to fix the issue once and for all without 
noticeable impact on other fonts? Is it just a matter of adding `0.5f` to clamp 
it to the next nearest pixel as is often required in Cairo drawing?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2502#issuecomment-627685545

Re: [Github-comments] [geany/geany] Can't see underscores on Ubuntu 20.04 (#2502)

2020-05-12 Thread elextr
And not just Ubuntu, Neil at Scintilla had it on Fedora too.  Discussions on 
that ML seemed to suggest that the font may be sensitive to rounding when 
converting measurements to integer pixels.  There was a change to the rounding 
on Scintilla which may help, but rounding still occurs and setting extra line 
descent may always be necessary with some fonts.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2502#issuecomment-627684235

Re: [Github-comments] [geany/geany] Can't see underscores on Ubuntu 20.04 (#2502)

2020-05-12 Thread Matthew Brush
I guess we can expect a flood of new duplicates as people upgrade to Ubuntu 
20.04 (and derivatives) and encounter this issue. I can confirm it happens here 
too, but it's not limited to Geany, for example it happens in HexChat too.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2502#issuecomment-627678275

Re: [Github-comments] [geany/geany] Weird copy and paste bug involving multiple instances of Geany (#2503)

2020-05-12 Thread Matthew Brush
It works fine here with Geany 1.37 (master) on Ubuntu 20.04 in Gnome/X11 as 
well as Geany 1.36 on Windows 7. Perhaps it's a bug in your unspecified version 
of Geany or OS.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2503#issuecomment-627676940

Re: [Github-comments] [geany/geany] Can't see underscores on Ubuntu 20.04 (#2502)

2020-05-12 Thread elextr
Duplicate of #2466 and #1387 and others

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2502#issuecomment-627640989

Re: [Github-comments] [geany/geany] Can't see underscores on Ubuntu 20.04 (#2502)

2020-05-12 Thread elextr
Closed #2502.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2502#event-3329624722

[Github-comments] [geany/geany] Weird copy and paste bug involving multiple instances of Geany (#2503)

2020-05-12 Thread Chris Graham
If I open a second instance of Geany, copy something to the clipboard, close 
that instance, and then try and paste into that second instance, nothing 
happens. This is using the drop-down menu, the context menu, and ctrl+v.
However, I can then paste into other applications and it works fine.
So somehow there is some issue with Geany accessing clipboard data from a 
closed version of itself that other applications don't suffer.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2503

[Github-comments] [geany/geany] Can't see underscores on Ubuntu 20.04 (#2502)

2020-05-12 Thread bristow
Hello everyone,

Since the migration to Ubuntu 20.04, Geany no longer displays underscores.
I have to zoom in considerably to see them.

Any ideas on how to solve this annoying problem? Thanks for this fabulous 
software !

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2502

Re: [Github-comments] [geany/geany] Use Scintilla's JSON lexer for JSON instead of the JavaScript/C++ lexer (#2454)

2020-05-12 Thread Ellie
Isn't it common that JSON parsers accept comments as an extension? I know many 
also don't, but unless you want to split up into two separate JSON-pure and 
JSON-with-comments file types it might be better to keep in the comment 
highlighting

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2454#issuecomment-627307579

Re: [Github-comments] [geany/geany] Easier project creation (#2245)

2020-05-12 Thread Ellie
This is *the* major reason why I personally don't use geany :cry: I love the 
new fancy "open folder" concept where the folder just magically is shown as a 
complete file tree, but Geany only allows me to open single files or a project 
file by default. It just feels clumsy and inflexible, in particular the concept 
of project files just feels so outdated... All the newer IDEs like VS Code get 
it right, but they also all use Electron and run really poorly. It's quite a 
shame and it'd be so cool if geany could do this better out of the box!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2245#issuecomment-627304875