Re: [Github-comments] [geany/geany] WIP: Meson build system (#2761)

[Andy Alt]

But you can still specify the prefix and other options after the build 
directory has been initialized. While in the build directory 'meson configure 
-Dprefix=...'. (Use 'meson configure' to see other config options)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2761#issuecomment-894724332

Re: [Github-comments] [geany/geany] WIP: Meson build system (#2761)

[elextr]

@techee you specify the prefix when you initialize the build directory, see 
https://github.com/geany/geany/pull/2761#issuecomment-809698447

The error looks like g++ is using the wrong standard, @kugel- hasn't specified 
it and I guess all the rest of us are using a g++ that defaults to at least 
c++11.  In fact the new Julia lexer requires c++17 so you will need a compiler 
capable of that (see recent changes to travis distro version on geany-plugins 
to get new enough compilers).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2761#issuecomment-894722666

Re: [Github-comments] [geany/geany] WIP: Meson build system (#2761)

[Jiří Techet]

@kugel- Finally had some time to try it on macOS but I get the following error:

```
The Meson build system
Version: 0.59.0
Source dir: /Users/jhbuild/geany
Build dir: /Users/jhbuild/geany/_builddir
Build type: native build
Project name: geany
Project version: 1.38
C compiler for the host machine: 
/Applications/Xcode.app/Contents/Developer/usr/bin/gcc (clang 12.0.5 "Apple 
clang version 12.0.5 (clang-1205.0.22.11)")
C linker for the host machine: 
/Applications/Xcode.app/Contents/Developer/usr/bin/gcc ld64 650.9
C++ compiler for the host machine: 
/Applications/Xcode.app/Contents/Developer/usr/bin/g++ (clang 12.0.5 "Apple 
clang version 12.0.5 (clang-1205.0.22.11)")
C++ linker for the host machine: 
/Applications/Xcode.app/Contents/Developer/usr/bin/g++ ld64 650.9
Host machine cpu family: x86_64
Host machine cpu: x86_64
Found pkg-config: /Users/jhbuild/gtk/inst/bin/pkg-config (0.29.2)
Run-time dependency glib-2.0 found: YES 2.68.0
Run-time dependency gmodule-2.0 found: YES 2.68.0
Run-time dependency gtk+-3.0 found: YES 3.24.30
Has header "dlfcn.h" : YES 
Has header "errno.h" : YES 
Has header "fcntl.h" : YES 
Has header "glob.h" : YES 
Has header "inttypes.h" : YES 
Has header "limits.h" : YES 
Has header "locale.h" : YES 
Has header "memory.h" : YES 
Has header "stdint.h" : YES 
Has header "stdlib.h" : YES 
Has header "strings.h" : YES 
Has header "string.h" : YES 
Has header "stdbool.h" : YES 
Has header "sys/stat.h" : YES 
Has header "sys/time.h" : YES 
Has header "sys/types.h" : YES 
Has header "unistd.h" : YES 
Checking for function "gnu_get_libc_version" : NO 
Checking for function "fnmatch" : YES 
Checking for function "ftruncate" : YES 
Checking for function "mkstemp" : YES 
Checking for function "regcomp" : YES 
Checking for function "socket" : YES 
Checking for function "strerror" : YES 
Checking for function "strstr" : YES 
Program sh found: YES (/bin/sh)
Program cp found: YES (/bin/cp)
Program ln found: YES (/bin/ln)
Program python3 found: YES (/Users/jhbuild/gtk/inst/bin/python3)
Program rst2html found: NO
Program rst2pdf found: NO
Program git found: YES (/usr/bin/git)
Configuring config.h using configuration
Configuring geany.pc using configuration
Compiler for C supports arguments -fvisibility=hidden: YES 
Configuring geany.1 using configuration
Message: Building from tarball, installing prebuild html
Program doxygen found: NO
Program ctags/runner.sh found: YES (/Users/jhbuild/geany/tests/ctags/runner.sh)
Message: [['COPYING', 'GPL-2']]
Program cp found: YES (/bin/cp)
Build targets in project: 22

Found ninja-1.8.2 at /Users/jhbuild/.new_local/bin/ninja
[1/252] Compiling C++ object 
libscintilla.a.p/scintilla_lexlib_CharacterSet.cxx.o
FAILED: libscintilla.a.p/scintilla_lexlib_CharacterSet.cxx.o 
/Applications/Xcode.app/Contents/Developer/usr/bin/g++ -Ilibscintilla.a.p -I. 
-I.. -I../scintilla/include -I../scintilla/src -I../scintilla/lexlib 
-I/Users/jhbuild/gtk/inst/include/glib-2.0 
-I/Users/jhbuild/gtk/inst/lib/glib-2.0/include 
-I/Users/jhbuild/gtk/inst/include/gtk-3.0 
-I/Users/jhbuild/gtk/inst/include/gio-unix-2.0 
-I/Users/jhbuild/gtk/inst/include/cairo 
-I/Users/jhbuild/gtk/inst/include/pango-1.0 
-I/Users/jhbuild/gtk/inst/include/harfbuzz 
-I/Users/jhbuild/gtk/inst/include/fribidi 
-I/Users/jhbuild/gtk/inst/include/atk-1.0 
-I/Users/jhbuild/gtk/inst/include/pixman-1 
-I/Users/jhbuild/gtk/inst/include/freetype2 
-I/Users/jhbuild/gtk/inst/include/libpng16 
-I/Users/jhbuild/gtk/inst/include/gdk-pixbuf-2.0 
-I/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include
 -I/Users/jhbuild/gtk/inst/include -fcolor-diagnostics -Wall -Winvalid-pch 
-Wnon-virtual-dtor -O0 -g -O2 -arch x86_64 -isysroot 
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk
 -mmacosx-version-min=10.13 -arch x86_64 -isysroot 
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk
 -DHAVE_CONFIG_H=1 -O2 -DGTK -Wno-deprecated-declarations 
-DGDK_DISABLE_DEPRECATION_WARNINGS 
-DGLIB_VERSION_MIN_REQUIRED=GLIB_VERSION_2_32 '-DGEANY_PREFIX="/usr/local"' 
'-DGEANY_INCLUDEDIR="/usr/local/include"' '-DGEANY_LIBDIR="/usr/local/lib"' 
'-DGEANY_LIBEXECDIR="/usr/local/libexec"' '-DGEANY_DATADIR="/usr/local/share"' 
'-DGEANY_LOCALEDIR="/usr/local/share/locale"' 
'-DGEANY_DOCDIR="/usr/local/share/doc"' -DGEANY_PRIVATE -fvisibility=hidden 
'-DGEANY_EXPORT_SYMBOL=__attribute__((visibility("default")))' 
-DGEANY_API_SYMBOL=GEANY_EXPORT_SYMBOL -Wno-non-virtual-dtor -DNDEBUG 
-DSCI_LEXER -DNO_CXX11_REGEX -MD -MQ 
libscintilla.a.p/scintilla_lexlib_CharacterSet.cxx.o -MF 
libscintilla.a.p/scintilla_lexlib_CharacterSet.cxx.o.d -o 
libscintilla.a.p/scintilla_lexlib_CharacterSet.cxx.o -c 
../scintilla/lexlib/CharacterSet.cxx
In file included from ../scintilla/lexlib/CharacterSet.cxx:12:
../scintilla/lexlib/CharacterSet.h:49:28: warning: rvalue references are a 
C++11 extension [-Wc++11-extensions]

Re: [Github-comments] [geany/geany] Underscore not displayed on 20.04 (#2466)

[Saurabh]

Increasing the default font size to 16 **and** changing `#~ line_height=0;2;` 
in Tools > Configuration Files > filetypes.common works

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2466#issuecomment-894713554

Re: [Github-comments] [geany/geany] Add reload all keybinding (#2859)

[David Yang]

@Davidy22 pushed 1 commit.

0160b4ca58e57d49bcb40dbf8630d86cad1ef17f  Amendments as per review


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/geany/geany/pull/2859/files/30b104d25c7e68b0c74b2b22e033e52012fe1ab0..0160b4ca58e57d49bcb40dbf8630d86cad1ef17f

Re: [Github-comments] [geany/geany] Add reload all keybinding (#2859)

[David Yang]

@Davidy22 commented on this pull request.



> @@ -244,6 +244,8 @@ gboolean document_reload_prompt(GeanyDocument *doc, const 
> gchar *forced_enc);
 
 void document_reload_config(GeanyDocument *doc);
 
+void force_reload_all(void);

Whoops, will clean

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2859#discussion_r684619595

Re: [Github-comments] [geany/geany] Add reload all keybinding (#2859)

[David Yang]

@Davidy22 commented on this pull request.



> @@ -335,6 +335,21 @@ void on_toolbutton_reload_clicked(GtkAction *action, 
> gpointer user_data)
document_reload_prompt(doc, NULL);
 }
 
+/* reload all files */
+void on_toolbutton_reload_all_clicked(GtkAction *action, gpointer user_data)

sort of was hoping there might be one but I'll rename

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2859#discussion_r684619702

Re: [Github-comments] [geany/geany] Add reload all keybinding (#2859)

[David Yang]

@Davidy22 commented on this pull request.



> @@ -335,6 +335,21 @@ void on_toolbutton_reload_clicked(GtkAction *action, 
> gpointer user_data)
document_reload_prompt(doc, NULL);
 }
 
+/* reload all files */
+void on_toolbutton_reload_all_clicked(GtkAction *action, gpointer user_data)
+{
+   guint i;
+   gint cur_page = 
gtk_notebook_get_current_page(GTK_NOTEBOOK(main_widgets.notebook));
+   
+   foreach_document(i)
+   {
+   if (! (documents[i]->file_name == NULL))

But when a user hits CTRL+R to reload a single file that they've changed, 
they're expecting it to reload regardless of changed status. Hitting the 
keybinding being a conscious choice should mean that the user knows what they 
want

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2859#discussion_r684619540

Re: [Github-comments] [geany/geany] Add reload all keybinding (#2859)

[elextr]

@elextr commented on this pull request.



> @@ -335,6 +335,21 @@ void on_toolbutton_reload_clicked(GtkAction *action, 
> gpointer user_data)
document_reload_prompt(doc, NULL);
 }
 
+/* reload all files */
+void on_toolbutton_reload_all_clicked(GtkAction *action, gpointer user_data)
+{
+   guint i;
+   gint cur_page = 
gtk_notebook_get_current_page(GTK_NOTEBOOK(main_widgets.notebook));
+   
+   foreach_document(i)
+   {
+   if (! (documents[i]->file_name == NULL))

The logic should probably match #1246 where issues around when to reload 
automatically were thrashed out.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2859#discussion_r684611206

Re: [Github-comments] [geany/geany-plugins] geanynumberedbookmarks: Fix README typos and add headings (#1096)

[Enrico Tröger]

Just noticed the README of the geanynumberedbookmarks plugin had quite some 
typos and no heading at all. Felt like this should be fixed.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1096#issuecomment-894629591

[Github-comments] [geany/geany-plugins] geanynumberedbookmarks: Fix README typos and add headings (#1096)

[Enrico Tröger]

Also add license information (based on COPYING).
You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany-plugins/pull/1096

-- Commit Summary --

  * geanynumberedbookmarks: Fix README typos and add headings

-- File Changes --

M geanynumberedbookmarks/README (37)

-- Patch Links --

https://github.com/geany/geany-plugins/pull/1096.patch
https://github.com/geany/geany-plugins/pull/1096.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1096

Re: [Github-comments] [geany/geany-plugins] Make numbered bookmarks work with numlock on (#1093)

[elextr]

Can anybody with a French keyboard (at least I think its a French keyboard I'm 
remembering) with numbers on the top and symbols below check if it works, 
perhaps even though they are on top the numbers will still be level 0?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1093#issuecomment-894628779

Re: [Github-comments] [geany/geany-plugins] Make numbered bookmarks work with numlock on (#1093)

[Enrico Tröger]

Looks good to me, tested and works (on my German keyboard) with and without 
Numlock turned on.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1093#issuecomment-894628143

Re: [Github-comments] [geany/geany] Create julia lexer and tags parser (#2584)

[Enrico Tröger]

Hopefully it will happen in September, if not at least this year :).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2584#issuecomment-894624269

Re: [Github-comments] [geany/geany] Add reload all keybinding (#2859)

[Enrico Tröger]

@eht16 requested changes on this pull request.

Looks good and works as expected.

Beside my other minor comments, adding the keybinding to 
https://github.com/geany/geany/blob/master/doc/geany.txt#file-keybindings would 
be cool.

> @@ -244,6 +244,8 @@ gboolean document_reload_prompt(GeanyDocument *doc, const 
> gchar *forced_enc);
 
 void document_reload_config(GeanyDocument *doc);
 
+void force_reload_all(void);

Seems like a left-over.

> @@ -335,6 +335,21 @@ void on_toolbutton_reload_clicked(GtkAction *action, 
> gpointer user_data)
document_reload_prompt(doc, NULL);
 }
 
+/* reload all files */
+void on_toolbutton_reload_all_clicked(GtkAction *action, gpointer user_data)

The function name somewhat suggests there is a toolbar button while it is not.
It might be unlikely that we will add a toolbar item for this functionality, so 
I think it's worth to rename the function to make it less confusing.

> @@ -335,6 +335,21 @@ void on_toolbutton_reload_clicked(GtkAction *action, 
> gpointer user_data)
document_reload_prompt(doc, NULL);
 }
 
+/* reload all files */
+void on_toolbutton_reload_all_clicked(GtkAction *action, gpointer user_data)
+{
+   guint i;
+   gint cur_page = 
gtk_notebook_get_current_page(GTK_NOTEBOOK(main_widgets.notebook));
+   
+   foreach_document(i)
+   {
+   if (! (documents[i]->file_name == NULL))

Fine!
What do you think about additionally ignoring documents which have 
`doc->changed` set?
It might be surprising for the user if changed documents get reloaded and the 
unsaved changes will be lost without a warning.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2859#pullrequestreview-724802554

Re: [Github-comments] [geany/geany] Can't see underscores on Ubuntu 20.04 (#2502)

[elextr]

Did you uncomment the heading?

On Sat, 7 Aug 2021, 11:36 am almir-campos, ***@***.***> wrote:

> I got the same problem and tried the proposed solution (adjusting the
> line-height), but nothing changed even when I exaggerated the the
> line_height as:
>
> line_height=10;10;false;false
>
> There were no visible changes in any line_heights neither by reloading the
> configuration nor by quitting and restarting Geany.
>
> Any clues?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> , or
> unsubscribe
> 
> .
> Triage notifications on the go with GitHub Mobile for iOS
> 
> or Android
> 
> .
>


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2502#issuecomment-894593407