Re: [Github-comments] [geany/geany] Update C++ compiler check to require C++17 (#2862)
I suggest using this, @kugel- has already made a PR for Scintilla 5 and who knows what that needs. Of course its not _just_ the compiler, but also the standard library (which is where string_view lives) that needs to be modern enough, but the compiler is possibly a proxy for that ... maybe. I just investigated this Mint (ie Ubuntu LTS based) system that has been allowed to handle compilers itself, it has gcc 8-10 available in the repos with 9.3 installed by default, and libstdc++ 8-10 available but 10.3 installed by default, interesting, I guess its ABI compatible with 9.3 so it can still be used with a 9.3 compiler but benefit from the bugfixes/additions. It also has clang 8-12 available with clang 10 installed by default and libc++ 8-12 available, but none installed. So clang is using libstdc++ here. All are Ubuntu packages, so I would expect Ubuntu LTS systems to be the same. So I suggest we use this as "reasonable efforts, feel free to contribute better tests if you think they are needed". -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2862#issuecomment-900710576
Re: [Github-comments] [geany/geany] Update C++ compiler check to require C++17 (#2862)
Yeah, as @elextr mentioned, the reason for the check is for an early failure with a message explaining the compiler isn't supported. Another way to do it would be to do a compile-test for only `std::string_view` to also support non-C++17 compilers which might have already supported `std::string_view`, but then that would have to be updated for each new C++17 type/function we use, and especially with newer Scintilla 4/5 coming, probably LOTS of stuff. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2862#issuecomment-900703838
[Github-comments] [geany/geany-plugins] vimode: Ignore special command handling in insert mode (#1100)
This special command handling is not related to insert mode and causes problems in insert mode for dummies. Fixes #1075. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany-plugins/pull/1100 -- Commit Summary -- * vimode: Ignore special command handling in insert mode -- File Changes -- M vimode/src/cmd-runner.c (4) -- Patch Links -- https://github.com/geany/geany-plugins/pull/1100.patch https://github.com/geany/geany-plugins/pull/1100.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1100
Re: [Github-comments] [geany/geany-plugins] Vimode: Can't exit insert mode if 'g' was the last entered character. (#1075)
> EDIT: I have "Insert Mode for Dummies" on. When I turned that off, it works > now. The bug is in "Insert Mode for Dummies". Ah, OK, I can reproduce it now. Will investigate. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1075#issuecomment-900642071
Re: [Github-comments] [geany/geany-plugins] Vimode: Can't exit insert mode if 'g' was the last entered character. (#1075)
It's still happening for me. I just open Geany, type `i`, type `g`, and press ``, which does nothing. As soon as I type any other character, `` sends me back to command mode. I'm using Geany from the Arch repos, maybe it has to do with that. I'll try to build from source and see if it stills does the same thing. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1075#issuecomment-900460100
Re: [Github-comments] [geany/geany-plugins] yank paste incorrect behaviour (#1060)
> while you understood the vim functions but you ask what "delete line number > means" or yank paste should not be a bug if it is known how it is done. No, I'm asking what _you_ mean by "delete line number" because you didn't explain it and "delete line number" is a bad description. What you want is not deleting a line number - you want deleting a line at certain line number. And if someone gives such vague descriptions, I just need to make sure that I understand what the person wants (and yes, I understood it correctly, you just didn't care to answer my question here https://github.com/geany/geany-plugins/issues/1060#issuecomment-898895363). And you confuse me with @elextr - I didn't ask about the yank problem at all, the description was quite clear. > If I were to write a program, I would test everything that I can list as > functions and not merely implement the functions and let bug reporters do it. And what do you think I did? You think I didn't test it at all? I did all my best to test all I could but there are already something like 100 vim functions to test and lots of their combinations and corner cases (for instance, the yank problem only affects end of files and when you have Geany set up so that it inserts EOL at the end of file, you won't see that problem). > If I were to write a program... Yes, that's the problem - you didn't spend any time writing the plugin, you just came here blaming the author who spent lots of hours writing the plugin in his spare time how lousy job he did and how you would do a much better job. To that, I can only give you one answer: show me (by looking at your profile, I can't see any projects you contributed to or any code you have written). > I can't use the plugin now as it is. Bug reporters are not necessarily > testers and cannot be assume as testers. They use for production and report > the bugs that don't affect their normal usage. If they find the plugins state > affects their work then they will not use it or report it. Therefore if you > get a bug report you are already fortunate. Would you rather prefer people > don't care? I absolutely want people to report bugs. Bug reports should describe what doesn't work correctly and what's missing and be technical and not contain the additional garbage you added. The only two useful things I got from you is the yank problem and missing `:d` which will probably be fixed in something like 10 lines of code. If that's all that's the reason why you "can't use the plugin", nice. But if there are more reasons, I'm just not a magician and can't read your thoughts so these things won't get fixed unless you describe them properly. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1060#issuecomment-900386555
Re: [Github-comments] [geany/geany] Update C++ compiler check to require C++17 (#2862)
This should be a failure in configure, hopefully with a message, instead of a compile failure half way through make. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2862#issuecomment-900069653
[Github-comments] [geany/geany] Update to Scintilla5 (#2867)
Update to scintilla, incl. lexilla split-off. Closes #2824 You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/2867 -- Commit Summary -- * Update Scintilla to version 5.1.1 * Update scintilla_changes.patch * Update update-scintilla.sh -- File Changes -- M plugins/Makefile.am (1) M scintilla/License.txt (4) M scintilla/Makefile.am (332) M scintilla/gtk/PlatGTK.cxx (1211) M scintilla/gtk/ScintillaGTK.cxx (639) M scintilla/gtk/ScintillaGTK.h (61) M scintilla/gtk/ScintillaGTKAccessible.cxx (189) M scintilla/gtk/ScintillaGTKAccessible.h (18) D scintilla/include/Compat.h (70) M scintilla/include/ILexer.h (22) M scintilla/include/ILoader.h (4) D scintilla/include/Makefile.am (15) D scintilla/include/Platform.h (549) M scintilla/include/Scintilla.h (117) M scintilla/include/Scintilla.iface (2459) A scintilla/include/ScintillaCall.h (881) A scintilla/include/ScintillaMessages.h (788) A scintilla/include/ScintillaStructures.h (103) A scintilla/include/ScintillaTypes.h (803) D scintilla/julia_lexilla_v5.patch (36) A scintilla/lexilla/License.txt (20) A scintilla/lexilla/include/LexicalStyles.iface (2252) A scintilla/lexilla/include/Lexilla.h (108) R scintilla/lexilla/include/SciLexer.h (22) R scintilla/lexilla/lexers/LexAbaqus.cxx (5) R scintilla/lexilla/lexers/LexAda.cxx (3) R scintilla/lexilla/lexers/LexAsm.cxx (9) R scintilla/lexilla/lexers/LexBash.cxx (7) R scintilla/lexilla/lexers/LexBasic.cxx (11) R scintilla/lexilla/lexers/LexBatch.cxx (57) R scintilla/lexilla/lexers/LexCOBOL.cxx (5) R scintilla/lexilla/lexers/LexCPP.cxx (134) R scintilla/lexilla/lexers/LexCSS.cxx (5) R scintilla/lexilla/lexers/LexCaml.cxx (139) R scintilla/lexilla/lexers/LexCmake.cxx (5) R scintilla/lexilla/lexers/LexCoffeeScript.cxx (5) R scintilla/lexilla/lexers/LexD.cxx (9) R scintilla/lexilla/lexers/LexDiff.cxx (5) R scintilla/lexilla/lexers/LexErlang.cxx (17) R scintilla/lexilla/lexers/LexForth.cxx (5) R scintilla/lexilla/lexers/LexFortran.cxx (5) R scintilla/lexilla/lexers/LexHTML.cxx (69) R scintilla/lexilla/lexers/LexHaskell.cxx (9) R scintilla/lexilla/lexers/LexJulia.cxx (12) R scintilla/lexilla/lexers/LexLaTeX.cxx (8) R scintilla/lexilla/lexers/LexLisp.cxx (5) R scintilla/lexilla/lexers/LexLua.cxx (49) R scintilla/lexilla/lexers/LexMake.cxx (5) R scintilla/lexilla/lexers/LexMarkdown.cxx (67) R scintilla/lexilla/lexers/LexMatlab.cxx (7) R scintilla/lexilla/lexers/LexNsis.cxx (5) R scintilla/lexilla/lexers/LexNull.cxx (5) R scintilla/lexilla/lexers/LexPO.cxx (5) R scintilla/lexilla/lexers/LexPascal.cxx (5) R scintilla/lexilla/lexers/LexPerl.cxx (7) R scintilla/lexilla/lexers/LexPowerShell.cxx (5) R scintilla/lexilla/lexers/LexProps.cxx (3) R scintilla/lexilla/lexers/LexPython.cxx (7) R scintilla/lexilla/lexers/LexR.cxx (5) R scintilla/lexilla/lexers/LexRuby.cxx (55) R scintilla/lexilla/lexers/LexRust.cxx (7) R scintilla/lexilla/lexers/LexSQL.cxx (7) R scintilla/lexilla/lexers/LexSmalltalk.cxx (5) R scintilla/lexilla/lexers/LexTCL.cxx (12) R scintilla/lexilla/lexers/LexTxt2tags.cxx (5) R scintilla/lexilla/lexers/LexVHDL.cxx (5) R scintilla/lexilla/lexers/LexVerilog.cxx (7) R scintilla/lexilla/lexers/LexYAML.cxx (15) R scintilla/lexilla/lexlib/Accessor.cxx (9) R scintilla/lexilla/lexlib/Accessor.h (6) R scintilla/lexilla/lexlib/CatalogueModules.h (8) R scintilla/lexilla/lexlib/CharacterCategory.cxx (149) R scintilla/lexilla/lexlib/CharacterCategory.h (2) R scintilla/lexilla/lexlib/CharacterSet.cxx (4) R scintilla/lexilla/lexlib/CharacterSet.h (103) R scintilla/lexilla/lexlib/DefaultLexer.cxx (11) R scintilla/lexilla/lexlib/DefaultLexer.h (10) A scintilla/lexilla/lexlib/LexAccessor.cxx (70) R scintilla/lexilla/lexlib/LexAccessor.h (43) R scintilla/lexilla/lexlib/LexerBase.cxx (13) R scintilla/lexilla/lexlib/LexerBase.h (10) R scintilla/lexilla/lexlib/LexerModule.cxx (5) R scintilla/lexilla/lexlib/LexerModule.h (8) R scintilla/lexilla/lexlib/LexerNoExceptions.cxx (9) R scintilla/lexilla/lexlib/LexerNoExceptions.h (10) R scintilla/lexilla/lexlib/LexerSimple.cxx (7) R scintilla/lexilla/lexlib/LexerSimple.h (8) R scintilla/lexilla/lexlib/OptionSet.h (4) A scintilla/lexilla/lexlib/PropSetSimple.cxx (75) A scintilla/lexilla/lexlib/PropSetSimple.h (31) R scintilla/lexilla/lexlib/SparseState.h (2) R scintilla/lexilla/lexlib/StringCopy.h (2) R scintilla/lexilla/lexlib/StyleContext.cxx (35) R scintilla/lexilla/lexlib/StyleContext.h (11) R scintilla/lexilla/lexlib/SubStyles.h (46) R scintilla/lexilla/lexlib/WordList.cxx (2) R scintilla/lexilla/lexlib/WordList.h (2) A scintilla/lexilla/src/Lexilla.cxx
Re: [Github-comments] [geany/geany] Update C++ compiler check to require C++17 (#2862)
Doesn't a check only really useful if there is a fallback? If we fail hard either way, why add a check? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2862#issuecomment-900047305
