[Github-comments] Re: [geany/geany-osx] Find window loses focus (Issue #42)
Hello, thanks very much for that. Your new build does seem to have fixed the Find window focus issue. I'll post again if the problem recurs, however your new build is **very** slow to start: 100% CPU, unresponsive, UI eventually appears only after several minutes -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-osx/issues/42#issuecomment-1427422658 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Enclose text in HTML tags (#1863)
Because I wanted to know how to do this too, I ended up putting a brief howto on the Geany wiki here: https://wiki.geany.org/howtos/enclose_text_in_html_tags -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1863#issuecomment-1427370577 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Julia block comments (Issue #3368)
> AFAIK the styles are just compile-time constants so it's not obvious how they > could be stored in the filetype file. Perhaps Scintilla provides some other > way too, IDK. Well themes set styles using names for the lexical entity, my (not fleshed out) thought at the time of the comment was that the same mechanism could be used to translate names to style numbers? > More generally it would be good if we could auto-generate C code based on > scintilla styles so adding a lexer is semi-automated. Agree totally, IIRC @codebrainz once looked at scripting Lexer upgrades further, but (again IIRC) when he asked for changes to Scintilla Neil refused (backward compatibility) so the idea was dropped. I think some other Scintilla users have such tooling, thats why Neil didn't want to change stuff, maybe we could ~steal~ reuse it. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3368#issuecomment-1427165927 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Don't insert * after new line in multi-line comment if previous line … (PR #3392)
@elextr commented on this pull request. > @@ -2208,7 +2208,8 @@ Automatic continuation multi-line comments * on the next line with the correct indentation based on the previous line, -as long as the multi-line is not closed by ``*/``. +as long as the multi-line is not closed by ``*/``. If the previous line +has no ``*`` prefix, the new line will not be changed. Suggest "the new line will not be changed" s/b "no ``*`` will be added to the new line" just to be explicit -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3392#pullrequestreview-1294804436 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Add recent filename on saving when real_path is not set (PR #3389)
LGBI -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3389#issuecomment-1427162952 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Open CLI docs only once main window is active again (PR #3395)
Certainly better than allowing it, but doesn't this break the use case of #2599? 1. Open a document 2. File->Save As 3. Notice an interesting file in the list of files in the dialog 4. Open interesting file from the command-line (in another program) with geany interesting-file. The file does not open (because the dialog is still open). 5. User says WHAT THE 6. complete save as 7. file opens 8. User says WHAT THE -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3395#issuecomment-1427158840 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Update of Latvian translation (PR #3347)
Merged #3347 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3347#event-8499075971 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Open CLI docs only once main window is active again (PR #3395)
@ntrel pushed 1 commit. e3de0579b9878f503b952a77cc2b067eca60e74b Use 100ms timeout to prevent idle callback spinning -- View it on GitHub: https://github.com/geany/geany/pull/3395/files/60067b4a0b10aa0a186f74a32073f07d61682e60..e3de0579b9878f503b952a77cc2b067eca60e74b You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Remove unusable plugins: DevHelp, GeanyPy, Multiterm (PR #1217)
> @eht16 well done for tricking me into giving it another shot ;) Though you > only got bare minimum resurrection from old work, but that doesn't actually > don't look that bad, not sure why I never submitted it. This wasn't completely intended by me but nice that it worked :). Thanks for pushing the old uncompletely work, if anyone wants to pick it up, now they can. If nobody stops me, I will merge this in a week so that we finally get a green CI again. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1217#issuecomment-1427057811 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Add bracket colors plugin (PR #1221)
> @eht16 I incorporated your suggested changes. I'm still learning Github, I > apologize if I'm not navigating this pull request correctly sweat_smile (at > my work, I'm used to Gitlab) No worries, it's fine. Thanks for the changes. The PR looks good to me and I would merge it in a few days if nobody objects. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1221#issuecomment-1427055544 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Add bracket colors plugin (PR #1221)
@eht16 commented on this pull request. > @@ -0,0 +1,35 @@ +# = I don't know if there is a better way :(. Asked primarily for curiosity. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1221#discussion_r1103817412 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Make cut/copy keybinding select word if no selection (PR #3391)
I find this also confusing behaviour and don't think we should do this. @ntrel, what about adding a new keybinding which provides the desired behaviour instead? I'd say leave the new keybinding unset but then users can rebind it to Ctrl-C if they like. And all other users won't be confused. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3391#issuecomment-1427052773 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Add recent filename on saving when real_path is not set (PR #3389)
I agree with the changes. Adding newly opened, unsaved files to recent files does not make much sense. If nobody objects, I'd merge it in a few days. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3389#issuecomment-1427051607 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Show modified MRU docs in red (PR #3390)
Merged #3390 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3390#event-8498431551 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Show modified MRU docs in red (PR #3390)
Nice! -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3390#issuecomment-1427048317 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Save As dialog can save the wrong document (#2599)
Closed #2599 as completed via #3388. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2599#event-8498406882 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Fix #2599 - Save As dialog can save the wrong document (PR #3388)
Merged #3388 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3388#event-8498406834 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Fix #2599 - Save As dialog can save the wrong document (PR #3388)
Tested and works great. I agree that even with #3395, this cannot hurt. There might be more cases where the current doc differs from the doc the Save As dialog were open. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3388#issuecomment-1427044849 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Open CLI docs only once main window is active again (PR #3395)
When a file is opened from a remote instance while a modal is open, the `handle_input_filename()` is called as fast as the main loop allows. This causes high CPU usage until the main window gets the focus back and the idle function is removed. I'd say this doesn't make it better than before especially as it is most probably not clear to the user why Geany suddently eats the CPU. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3395#issuecomment-1427042777 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Don't insert * after new line in multi-line comment if previous line … (PR #3392)
@ntrel commented on this pull request.
> @@ -3526,10 +3526,13 @@ static void auto_multiline(GeanyEditor *editor, gint
> cur_line)
{ /* we are on the second line of a multi line comment, so we
have to insert white space */
whitespace = " ";
}
-
- if (style == SCE_D_COMMENTNESTED)
- continuation = "+"; /* for nested comments in D */
-
+ else if (!(g_str_has_prefix(previous_line + i, continuation) &&
No problem, thanks for reviewing.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3392#discussion_r1103786927
You are receiving this because you are subscribed to this thread.
Message ID:
[Github-comments] Re: [geany/geany] Julia block comments (Issue #3368)
> if the list of comment styles came from the filetype file so custom styles > could alter it AFAIK the styles are just compile-time constants so it's not obvious how they could be stored in the filetype file. Perhaps Scintilla provides some other way too, IDK. More generally it would be good if we could auto-generate C code based on scintilla styles so adding a lexer is semi-automated. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3368#issuecomment-1427011135 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Fix #2599 - Save As dialog can save the wrong document (PR #3388)
This fix is superceded by #3395, but it's probably worth merging this also for resilience. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3388#issuecomment-1427008435 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Restore startup behavior to focus files from the command line after session files (PR #3267)
Haven't looked at this, but it may be affected by #3395. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3267#issuecomment-1427006837 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] [geany/geany] Open CLI docs only once main window is active again (PR #3395)
Avoid creating documents immediately because there could be a modal dialog open. Modal code often assumes the current doc hasnt changed and calls `document_get_current` at different times. Fixes #2599. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/3395 -- Commit Summary -- * Open CLI docs only once main window is active -- File Changes -- M src/socket.c (21) -- Patch Links -- https://github.com/geany/geany/pull/3395.patch https://github.com/geany/geany/pull/3395.diff -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3395 You are receiving this because you are subscribed to this thread. Message ID: geany/geany/pull/3...@github.com
[Github-comments] Re: [geany/geany] Make cut/copy keybinding select word if no selection (PR #3391)
@ntrel pushed 1 commit. 62f9eb5f5369b3c7d550e1465026224a818058f3 Only select word on copy (which copies to X clipboard) -- View it on GitHub: https://github.com/geany/geany/pull/3391/files/bdaaa3cd609427880a4a031333c21049518d7940..62f9eb5f5369b3c7d550e1465026224a818058f3 You are receiving this because you are subscribed to this thread. Message ID:
