[Github-comments] Re: [geany/geany] Improve code commenting-out global config files (PR #3413)
> I just had a look at a few filetype's configurations and it's really a mixed > bag of styles. Thats the problem with software development that is contributed by lots of different people :-D I am not sure about the suggestion to document only in `filetypes.common`, in one way I see your point, its all in one place and the individual filetype files then work as intended, only containing settings that need to be overridden. But on the other hand it means that two files need to be open, the individual filetype to be edited and `filetypes.common` to read the comments and to find settings that the filetype file does not yet use, and since Geany doesn't do multi-pane very well nor multi-window, it will mean switching back and forward between them, not ideal. The other way is to make all filetypes files a copy of `filetypes.common`, comments and all, with the unused settings already commented out. Then no commenting code is needed when the filetype file is copied, and users can add settings simply by uncommenting the one they want instead of having to copy it from `filetypes.common`. Of course that means maintaining them all when `filetypes.common` changes. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3413#issuecomment-1453114080 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] [GeanyLua] For version 5.4.3? (Issue #1133)
Well, there is no plugin maintainer to object ;-)
The simplest solution would be just to make it a new plugin ("Geanyluajit"
maybe) until its stable and supports the platforms the existing one does. That
also means a Geanylua is still available while the distros get their heads
around the new dependency.
Then Geanylua can be simply deleted when it breaks.
I can't figure out if the bundles include Geanylua and if a bundled lua dll is
included for Windows (@eht16) or OSX (@techee)?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/1133#issuecomment-1452773141
You are receiving this because you are subscribed to this thread.
Message ID:
[Github-comments] Re: [geany/geany-plugins] [GeanyLua] For version 5.4.3? (Issue #1133)
I am willing to look into what would be necessary to switch to LuaJIT, but if there would be opposition to such a change, it wouldn't be worth the effort. In principle, switching to LuaJIT should be easier than switching to Lua 5.4+ because LuaJIT is intended to be a drop-in replacement for Lua 5.1. LuaJIT appears to be actively maintained, while Lua 5.1 has been deprecated for nearly two decades. At the moment, it's working, but there's a possibility that it will eventually be dropped by some distros or stop compiling because of some future gcc, glibc, or other update. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1133#issuecomment-1452739600 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] [GeanyLua] For version 5.4.3? (Issue #1133)
As I noted above, the plugin is orphaned, so somebody needs to take it over and then make the change. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1133#issuecomment-1452721785 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] TypeScript Parser: Does Not Always Display Complete List of Methods (Issue #3416)
This seems to fix it, not sure it's perfect though:
```diff
diff --git a/ctags/parsers/typescript.c b/ctags/parsers/typescript.c
index 7dcc338ef..3fcd956a8 100644
--- a/ctags/parsers/typescript.c
+++ b/ctags/parsers/typescript.c
@@ -1820,8 +1820,11 @@ static void parseClassBody (const int scope, tokenInfo
*const token)
parsingValue = false;
break;
case TOKEN_OPEN_PAREN:
- if (! member) break;
uwiUngetC ('(');
+ if (! member) {
+ parsed = tryParser
(parseParens, token, false);
+ break;
+ }
const int nscope = emitTag (member,
isGenerator ? TSTAG_GENERATOR : TSTAG_METHOD);
```
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3416#issuecomment-1452585750
You are receiving this because you are subscribed to this thread.
Message ID:
[Github-comments] Re: [geany/geany] TypeScript Parser: Does Not Always Display Complete List of Methods (Issue #3416)
Playing a tad with it, I see it's the `()`s in the members initialization (e.g. `singletons.getSoundManager()`): if you remove the `()`s it keeps on parsing. Now somebody will have to fix it… :slightly_smiling_face: -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3416#issuecomment-1452561759 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] TypeScript Parser: Does Not Always Display Complete List of Methods (Issue #3416)
Sorry, I didn't answer sooner. The two files that I used as examples are located here: - [User.ts](https://github.com/arianne/stendhal/blob/master/srcjs/stendhal/entity/User.ts) - [Player.ts](https://github.com/arianne/stendhal/blob/master/srcjs/stendhal/entity/Player.ts) > ...see whether [universal-ctags](https://github.com/universal-ctags/ctags) > has the same issue, and report it there... When I get done with something I am currently working on, I'll check out Universal Ctags & see if the problem is there. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3416#issuecomment-1452552209 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Use GtkApplication instead of gtk_main (PR #3417)
Seems to work on macOS without any problems. And I agree that we should start using GtkApplication (if, in the far future, we switch to GMenuModel for menus, we could avoid using the mac-integration library because the global menu should be then handled by GtkApplication). -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3417#issuecomment-1452536904 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Use GtkApplication instead of gtk_main (PR #3417)
No, you can use GAction without. And I'm not against GtkApplication, but we should then embrace it rather than fight it, otherwise I really don't see the point. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3417#issuecomment-1452533187 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] [geany/geany-plugins] [GeanyLua] geany.activate not activating document (Issue #1229)
`geany.activate()` is supposed activate a document and return true. If it is
unable, it returns false. However, it is not activating the document.
Accepted arguments are a tab id (negative numbers), document id (positive
numbers), or full document path. Test code attempting to call
`geany.activate()` with the document id (test1) and path (test2) follows:
```
test1 = geany.activate(geany.documents(geany.filename()))
doc_id = geany.documents(geany.filename())
test2 = geany.activate(doc_id)
for key,val in pairs({ test1, test2 }) do
if val then
geany.status("true")
else
geany.status("false")
geany.status(geany.documents(geany.filename()))
geany.status(geany.filename())
end
end
```
Results in status window are:
```
false
1
/tmp/test
false
1
/tmp/test
```
For reference, an excerpt from the GeanyLua
[documentation](https://plugins.geany.org/geanylua/geanylua-ref.html#activate):
> **`geany.activate ( tab_id )`**
>
> Activates the document specified by tab_id.
>
> If `tab_id` is a number, it activates the document at that index. A
> positive number refers to the internal document array, and a negative number
> refers to the (absolute) GtkNotebook index.
> Note that the indices begin at (1) and (-1) respectively.
>
> If `tab_id` is a string, the function will try to activate the notebook tab
> whose filename matches that string.
> ( The full pathname is required! )
>
> Returns `true` on success, or `false` if the tab could not be found.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/1229
You are receiving this because you are subscribed to this thread.
Message ID:
[Github-comments] [geany/geany-plugins] [GeanyLua] Switch to LuaJIT? (Issue #1228)
Lua 5.1 has been deprecated (in a few years, will be two decades). [LuaJIT](https://github.com/LuaJIT/LuaJIT) appears to be a drop-in replacement for Lua 5.1 that would require only build script or other minor changes. Based on Git activity, LuaJIT is actively maintained. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1228 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] [GeanyLua] For version 5.4.3? (Issue #1133)
I've recently learned about [LuaJIT](https://github.com/LuaJIT/LuaJIT). It appears to be a drop-in replacement for Lua 5.1 that would require only build script or other minor changes. Based on Git activity, LuaJIT appears to be actively maintained. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1133#issuecomment-1452496625 You are receiving this because you are subscribed to this thread. Message ID:
