[Github-comments] Re: [geany/geany-plugins] Add bracket colors plugin (PR #1241)

2023-03-10 Thread Asif Amin via Github-comments
cc @elextr @eht16 @b4n @rdipardo

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1241#issuecomment-1464731699
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany-plugins] Add bracket colors plugin (PR #1241)

2023-03-10 Thread Asif Amin via Github-comments
This is revived from my [original pull 
request](https://github.com/geany/geany-plugins/pull/1221)

I got too aggressive squashing commits between my work and home workstations 
and ended up getting other unrelated commits from upstream into my feature 
branch :sweat_smile: 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1241#issuecomment-1464730769
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] [geany/geany-plugins] Add bracket colors plugin (PR #1241)

2023-03-10 Thread Asif Amin via Github-comments
# Bracketcolors plugin

- Color { }, [ ], ( ) based on nesting order to make it easier to see the 
start/end bracket
- Ignore brackets in non source code (strings, comments, doc strings, etc.)
- Language agnostic 



## How it works 

Allocates 3 indicators (starting at `INDICATOR_IME` - 3) to color each bracket 
pair as determined by `SCI_BRACEMATCH`. Ignore non source brackets as 
determined by `highlighting_is_code_style`

## Dependencies

- Geany 1.38
  - Need `INDICATOR_IME` from updated scintilla release
- C++17
  - Mainly for `std::map` 

### Demo 
image;
You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany-plugins/pull/1241

-- Commit Summary --

  * Bracket Colors
  * remove leftover cruft, apply consistent snake case for helper functions
  * Merge branch 'geany:master' into bracketcolors_v1_clean

-- File Changes --

M MAINTAINERS (7)
M Makefile.am (4)
M README (1)
A bracketcolors/AUTHORS (1)
A bracketcolors/COPYING (339)
A bracketcolors/ChangeLog (0)
A bracketcolors/Makefile.am (4)
A bracketcolors/NEWS (0)
A bracketcolors/README (32)
A bracketcolors/src/BracketMap.cc (110)
A bracketcolors/src/BracketMap.h (63)
A bracketcolors/src/Makefile.am (15)
A bracketcolors/src/bracketcolors.cc (1292)
A build/ax_cxx_compile_stdcxx.m4 (962)
A build/ax_cxx_compile_stdcxx_17.m4 (35)
A build/bracketcolors.m4 (31)
M build/geany-plugins.nsi (1)
M configure.ac (2)
M po/POTFILES.in (3)

-- Patch Links --

https://github.com/geany/geany-plugins/pull/1241.patch
https://github.com/geany/geany-plugins/pull/1241.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1241
You are receiving this because you are subscribed to this thread.

Message ID: 


[Github-comments] Re: [geany/geany-plugins] Add bracket colors plugin (PR #1221)

2023-03-10 Thread elextr via Github-comments
? why removed

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1221#issuecomment-1464723023
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany-plugins] Add bracket colors plugin (PR #1221)

2023-03-10 Thread Asif Amin via Github-comments
Closed #1221.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1221#event-8723027077
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany-plugins] Add bracket colors plugin (PR #1221)

2023-03-10 Thread Asif Amin via Github-comments
@asifamin13 pushed 1 commit.

7cd6454107f45540a1f62f4d471d78fecdd9583c  Bracketcolors v1 codereview 3/10/23 
(#3)

-- 
View it on GitHub:
https://github.com/geany/geany-plugins/pull/1221/files/0850594b6132956e8a813db85020473e33c7aa6a..7cd6454107f45540a1f62f4d471d78fecdd9583c
You are receiving this because you are subscribed to this thread.

Message ID: 


[Github-comments] Re: [geany/geany-plugins] Add bracket colors plugin (PR #1221)

2023-03-10 Thread Asif Amin via Github-comments
@asifamin13 commented on this pull request.



> +static gchar char_at(ScintillaObject *sci, gint pos)
+/*
+
+- 
*/
+{
+return sci_get_char_at(sci, pos);
+}

When I was writing this, I was using the `autoclose` plugin as a template 
[which has this wrapper as 
well](https://github.com/geany/geany-plugins/blob/dc6980e5df24434597b37a5a7064837b3f5158e8/autoclose/src/autoclose.c#L93).
 I suspect the authors of `autoclose` used the wrapper for convenience since 
it's used a lot, I don't really need it as bad to be honest. 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1221#discussion_r1132943357
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] [geany/geany-plugins] vimode: implement "iw", "ow", "iW" and "oW" text objects (PR #1240)

2023-03-10 Thread Jiří Techet via Github-comments
This enables a family of word-related text object commands such as:
"ciw", "diw", "viw" etc.

Fixes https://github.com/geany/geany-plugins/issues/1155.
You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany-plugins/pull/1240

-- Commit Summary --

  * vimode: Refactor motion-word.c so the motion commands can be reused
  * vimode: implement "iw", "ow", "iW" and 
"oW" text objects

-- File Changes --

M vimode/README (4)
M vimode/src/cmd-runner.c (4)
M vimode/src/cmds/motion-word.c (323)
M vimode/src/cmds/motion-word.h (3)
M vimode/src/cmds/txtobjs.c (44)
M vimode/src/cmds/txtobjs.h (4)

-- Patch Links --

https://github.com/geany/geany-plugins/pull/1240.patch
https://github.com/geany/geany-plugins/pull/1240.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1240
You are receiving this because you are subscribed to this thread.

Message ID: 


[Github-comments] Re: [geany/geany-osx] Find window loses focus (Issue #42)

2023-03-10 Thread cloudis-ild via Github-comments
FYI, I followed the suggestion at 
[https://github.com/geany/geany/issues/791](url) and that fixes the problem as 
far as I'm concerned, because all I lose is the Symbols tab, and that's a bit 
flakey anyway for PL/SQL code. The advantages of the build with the later GTK 
library (consistent focus, cursor changing correctly depending on context) far 
outweigh the loss of symbol functionality.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-osx/issues/42#issuecomment-1464192521
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany-plugins] Debugger: Fix debugging of multi-threaded programs (PR #1170)

2023-03-10 Thread nomadbyte via Github-comments
> ... IIRC @avafinger applied changes manually, it would be nice for someone to 
> test the PR explicitly.

Sure. However, as you probably could see, the changes are very much limited, so 
applying manually should be just as effective. Of course, I did the testing of 
the issue, as I described above.

It's been almost a year since this issue is in DONE state. Is there something 
that I could do to get this finally merged?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1170#issuecomment-1464128273
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Improve code commenting-out global config files (PR #3413)

2023-03-10 Thread Colomban Wendling via Github-comments
> The one thing you possibly could do is still add a leading `#` to the 
> `\t#comment` line, e.g. "if line is an indented comment, add a documentation 
> comment prefix", but that might be an overly specific case to warrant it, and 
> special cases have a tendency to come back to bite you…

Wait, if we don't need to handle leading whitespaces (which we don't *need* 
AFAIK, although it might be nice), the logic is merely `if (*line && *line != 
'[' && *line != '#') comment();`, isn't it?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3413#issuecomment-1463938113
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] .F77 file extension does not syntax highlight (Issue #3425)

2023-03-10 Thread Colomban Wendling via Github-comments
Closed #3425 as completed via 39d1e7f53a2b77cb0527f8368a49164b7ae6372f.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3425#event-8717852231
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Recognize .F77 extension (uppercase) as FORTRAN77 (PR #3427)

2023-03-10 Thread Colomban Wendling via Github-comments
Merged #3427 into master.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3427#event-8717852265
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] The editor inserts a quote too much (Issue #3426)

2023-03-10 Thread SandorBy via Github-comments
Solved:
I disabled the autoclose plugin. Now it works.
(And yes I have enabled all "Autoclose quotes and brackets")

Thank you all for your responses!

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3426#issuecomment-1463451728
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] The editor inserts a quote too much (Issue #3426)

2023-03-10 Thread SandorBy via Github-comments
Closed #3426 as completed.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3426#event-8715881783
You are receiving this because you are subscribed to this thread.

Message ID: