[Github-comments] Re: [geany/geany] Mark tags as "local" only for files with a known C/C++ source extension (PR #3490)
I'll try to test it properly tomorrow, but the approach, although a bit of a workaround (as it's basically overriding a similar check in uctags), it looks pretty good indeed (esp. with the discussion on the uctags PR). -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3490#issuecomment-1539023567 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Scrolling using Alt+Arrow keys moves cursor when end of visible region is reached (Issue #3489)
Although @elextr is right that there's nothing actually stating what it really does, it doesn't feel very intuitive nor useful to me as is (I either want the caret to move, or I don't, I rarely don't care). So it's not technically a bug as it behaves just the way the code intends, but it feels counterintuitive to me, and worth changing. We could probably achieve the OP's expectations fairly easily using `SCI_LINESCROLL(0, [-]1)` instead. This said, I don't really use the feature (or I would have noticed I guess), so I might not be the best judge of current behavior. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3489#issuecomment-1539003019 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Remove obsolete helper scripts (PR #3486)
I don't use them, and I don't care much. *scripts/fix-alignment.pl* and *scripts/fix-cxx-comments.pl* *look like* they could be useful (basically, poor man's code formatter), but I don't read Perl and didn't use them in ages, if ever. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3486#issuecomment-1538993137 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Port create_php_tags to Python3 and generate new PHP tags file (PR #3488)
@cwendling commented on this pull request.
I don't know much PHP anymore either, but at least the script seems to still
work, the difference seem to be in the JSON itself (I only checked a couple
things, but they match).
Sadly the JSON seems to have a few flaws with the types in signatures (no
alternative types, and it seems to use the last one which sometimes is `null`
-- that used to be `mixed` in the PHP docs, but now is `foo|bar|baz`), but then
again nothing the script can do with that data so I'd think it's fine.
> (arg_list, TA_ARGLIST),
(return_type, TA_VARTYPE),
(scope, TA_SCOPE)]:
if attr is not None:
-tag_line += '{type:c}{attr}'.format(type=type, attr=attr)
+tag_line += f'{type_:c}{attr}'
+print(tag_line)
new debugging, is that wanted?
>
# write tags
script_dir = dirname(__file__)
tags_file_path = join(script_dir, '..', 'data', 'tags', 'std.php.tags')
-with open(tags_file_path, 'w') as tags_file:
+with open(tags_file_path, 'w', encoding='iso-8859-1') as tags_file:
why ISO 8859-1? This seems fully ASCII currently, is this encoding documented
somewhere? I can't seem to find out anything in a response header or something.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3488#pullrequestreview-1417367708
You are receiving this because you are subscribed to this thread.
Message ID:
[Github-comments] Re: [geany/geany] New UI on windows is bloated and scaled up (Issue #3063)
> Seriously though, this is the stuff that kills projects. I am already eyeing > out another open source project. What exactly is this referring to? What should kill the project and why? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3063#issuecomment-1538845271 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Cannot go to tag if using an unconventional file extension (Issue #3454)
In tag manager, it's called "local", in uctags it's called "isFileScope" (which is a better name). It's those definitions/declarations that are valid only within a single file and which cannot be legally used outside of that file (like static functions for instance). -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3454#issuecomment-1538411640 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Cannot go to tag if using an unconventional file extension (Issue #3454)
I'm confused, what does uctags mean by "local"? Its only at C++20 that the concept of "TU local" is formalised but "extern" and "static" have been about since C. Or do they mean "function locals", ie what C++ calls "automatic" and "thread_local"? I presume they don't mean "block locals" since uctags doesn't do scopes. Or do they mean "internal" linkage (vs "external" linkage) which after all is what keeps objects "local" to a TU? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3454#issuecomment-1538346936 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] [WIP] [D] Switch to mainline ctags parser (PR #3479)
@ntrel pushed 3 commits. aaaf750eeb6ad019c12c40c0ab5d3518cf10113a Sync templates.d with ctags PR dc8cab25b0b7da8b9ae7d0846b4b63a40dc366a5 backport ctags tweaks d3fa78adb5747a9612261433a817a47566c1366e D: fix parsing parameter with pointer -- View it on GitHub: https://github.com/geany/geany/pull/3479/files/8ac0919f83cb35cfef89340f4d2d8dbfef8170e7..d3fa78adb5747a9612261433a817a47566c1366e You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Vimode in Geany not working (Issue #1248)
Yeah, I merged all I could from projectorganizer and vimode yesterday ;-) Regarding quality control I think I could have prevented some of the vimode problems before the release if the PRs got merged to master earlier as I didn't notice the issues when I worked on the individual PRs and then never checked out later myself. So having things merged earlier before the release could improve the quality because someone, including me, is more probable to notice the problems. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1248#issuecomment-1538285137 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] vimode: support some more commands (Issue #1155)
Closed #1155 as completed via #1240. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1155#event-9189824590 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] vimode: implement "iw", "ow", "iW" and "oW" text objects (PR #1240)
Merged #1240 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1240#event-9189824392 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Port "main.py" template to Python3 (PR #3485)
@b4n approved this pull request. It's a bit more than making it python 3, but LGTM still -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3485#pullrequestreview-1416696377 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Vimode in Geany not working (Issue #1248)
@frlan could give his opinion, but I agree with @elextr : the plugins themselves are the responsibility of their maintainers, not really @frlan that can't know them all inside out anyway. And as a maintainer, although I am fine with people merging stuff to plugins I maintain when I clearly don't have time (which I clearly don't 😅), I'd still rather review and merge myself when I can so I know what I'm maintaining kinda. The only gray area would be quality control as the bundle is kind of a whole expected to behave, but we didn't have this kind of problems in the past I think (but for the unfortunate yet expected bugs that will sneak their way in no matter what anyway, but none of it was gross negligence nor malice), so I don't think there's any reason to be rigid in this area yet. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1248#issuecomment-1538249580 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Cannot go to tag if using an unconventional file extension (Issue #3454)
See #3490 for a possible fix of this issue. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3454#issuecomment-1538244012 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Don't use ctags isFileScope tag information (PR #3457)
Closing as this PR is obsoleted by #3490. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3457#issuecomment-1538242734 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Don't use ctags isFileScope tag information (PR #3457)
Closed #3457. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3457#event-9189611694 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] [geany/geany] Mark tags as "local" only for files with a known C/C++ source extension (PR #3490)
After some more thinking about it, we can fix #3454 very easily by ourselves by checking whether the tag originates from a source file with a known/common C/C++ extension - if not, always set "local" to FALSE. The first patch adds `is_c_source` flag to TMSourceFile to indicate whether the file has one of the known C/C++ extensions, the second patch uses this flag and for C/C++ sources sets "local" to TRUE only when this flag is set (in addition to ctag's isFileScope flag). @b4n Does this fix look OK to you? Fixes #3454. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/3490 -- Commit Summary -- * Add a flag to TMSourceFile indicating whether it's a C/C++ source file * For C/C++ only mark tag as local if it originates from a source file -- File Changes -- M src/tagmanager/tm_ctags.c (7) M src/tagmanager/tm_source_file.c (18) M src/tagmanager/tm_source_file.h (2) -- Patch Links -- https://github.com/geany/geany/pull/3490.patch https://github.com/geany/geany/pull/3490.diff -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3490 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Add tooltips for goto tag menu items (PR #3467)
Closed #3467. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3467#event-9189488827 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Add tooltips for goto tag menu items (PR #3467)
Superceded by #3475 -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3467#issuecomment-1538225019 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Make Go to Symbol commands show symbol type/signature in list (PR #3475)
Merged #3475 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3475#event-9189469656 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Scrolling using Alt+Arrow keys moves cursor when end of visible region is reached (Issue #3489)
> I thought using Alt + Arrow keys (up, down) should emulate mouse wheel > behaviour Where did you get that impression? I can't find anywhere that exactly defines what that key combination does, but nothing I can find says its a mouse replacement. All the [Geany docs](https://www.geany.org/manual/current/index.html#editor-keybindings) say is "scroll view" with no mention of what the cursor does or does not do, unlike the line above for `ctrl_shift+l`. The Scintilla docs are similarly silent (which is probably why Geany ones are, since Geany simply calls Scintilla). Certainly the oldest version I have (1.36) works like that, and as far as I can recall it always did, but I never paid much attention. This is also the way Scite behaves (except its key combo is different). Certainly it is strange, exactly what it is for I don't know. > Is this intended behaviour? You would have to ask that of Scintilla, perhaps there is some olden times use. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3489#issuecomment-1538183154 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Scrolling using Alt+Arrow keys moves cursor when end of visible region is reached (Issue #3489)
gif attached https://ibb.co/k8RM2tX -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3489#issuecomment-1537984183 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] [geany/geany] Scrolling using Alt+Arrow keys moves cursor when end of visible region is reached (Issue #3489)
Is this intended behaviour? I thought using Alt + Arrow keys (up, down) should emulate mouse wheel behaviour, i.e. NOT move the text cursor, but only the visible region of the text file. This is clearly uncomfortable if we have a text selection greater than the visible region, because in that case, using Alt + Arrow-keys deselects the text once the cursor is re-positioned due to visible region end. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3489 You are receiving this because you are subscribed to this thread. Message ID:
