[Github-comments] Re: [geany/geany-plugins] Addons: Delay updating of tasks list until document has been colorised (PR #1257)

2023-07-09 Thread elextr via Github-comments
@elextr commented on this pull request.



>  {
+   AoTasksUpdateTasksForDocArguments *arguments = data;
+   AoTasks *t = arguments->t;
+   GeanyDocument *doc = arguments->doc;

I was thinking of DOCVALID()

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1257#discussion_r1257590524
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] CSS nesting syntax coloring (Issue #3523)

2023-07-09 Thread elextr via Github-comments
Ahh, ok, highlighting!!

Highlighting is performed by the Lexer from the 
[Lexilla](https://github.com/ScintillaOrg/lexilla) project.  AFAICT even the 
latest does not support that syntax, so you should request it there, that way 
you can directly discuss it with the maintainer of the lexer.  Please post a 
link to the Lexilla issue here.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3523#issuecomment-1627871778
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] CSS nesting syntax coloring (Issue #3523)

2023-07-09 Thread elextr via Github-comments
Reopened #3523.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3523#event-9768223009
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany-plugins] Compiling geangy-plugins appeared errors (Issue #1255)

2023-07-09 Thread Enrico Tröger via Github-comments
@Novak-Zhao you can use the changes from 
https://github.com/geany/geany-plugins/pull/1259 to fix the build.
E.g. by downloading the changes as patch from 
https://github.com/geany/geany-plugins/pull/1259.patch and then apply it 
locally, should work with the 1.38 sources as well.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/1255#issuecomment-1627827620
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany-plugins] vimode: Don't build the viw binary on Windows (PR #1259)

2023-07-09 Thread Enrico Tröger via Github-comments
Thank you @techee.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1259#issuecomment-1627827244
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany-plugins] Compiling geangy-plugins appeared errors (Issue #1255)

2023-07-09 Thread Jiří Techet via Github-comments
Closed #1255 as completed via #1259.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/1255#event-9767795811
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany-plugins] vimode: Don't build the viw binary on Windows (PR #1259)

2023-07-09 Thread Jiří Techet via Github-comments
Merged #1259 into master.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1259#event-9767795769
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany-plugins] Add bracket colors plugin (PR #1221)

2023-07-09 Thread Asif Amin via Github-comments
It's from [the pull 
request](https://github.com/asifamin13/geany-plugins/pull/5) on my fork. 

I'd appreciate any feedback, I added some GUI elements to specify custom colors 
on the plugin preferences page.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1221#issuecomment-1627764648
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] CSS nesting syntax coloring (Issue #3523)

2023-07-09 Thread bobWinner via Github-comments
I'm talking about syntax highlighting and block collapsing of css files within 
geany.
both are broken if you do nesting.

this is very annoying

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3523#issuecomment-1627759633
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany-plugins] Add bracket colors plugin (PR #1221)

2023-07-09 Thread Enrico Tröger via Github-comments
> @eht16 I did the rebase, verified it compiles/works as expected on my rhel 8 
> workstation. Shall we give the CI another shot?

The CI is fine.
Though you added quite some new code in the last commit which should be 
reviewed.

Btw, what is the "#5" referring to you mentioned in the commit message?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1221#issuecomment-1627750676
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany-plugins] Addons: Delay updating of tasks list until document has been colorised (PR #1257)

2023-07-09 Thread Enrico Tröger via Github-comments
@elextr fine by you now?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1257#issuecomment-1627749597
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Create file.md (PR #3517)

2023-07-09 Thread Enrico Tröger via Github-comments
Nice idea.

If there are no objections, I'll merge this in a few days.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3517#issuecomment-1627748936
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany-plugins] vimode: Don't build the viw binary on Windows (PR #1259)

2023-07-09 Thread Enrico Tröger via Github-comments
> end of summer holidays so he can check.

Unfortunately no holidays but I was unable to find enough time anyway :).

> > CI passes!
> 
> Was the original problem reproducible with our CI (and the version of msys2 
> our CI uses)?

Let's just celebrate the CI passes, even without any reason! :)

Finally to the topic:
@elextr @techee I can confirm the changes here fix the Windows build. Good job!

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1259#issuecomment-1627731244
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] CSS nesting syntax coloring (Issue #3523)

2023-07-09 Thread Enrico Tröger via Github-comments
Just to be sure,
@bobWinner did you mean to use CSS nesting on the gtk.css / theming?
Or did you refer to the syntax highlighting of CSS files within Geany?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3523#issuecomment-1627724948
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany-themes] Add Matcha Theme (PR #55)

2023-07-09 Thread Axel via Github-comments
@xelser pushed 1 commit.

9568fc80d227ba2152cccbcc95342d94c1e90d92  Merge branch 'geany:master' into 
matcha

-- 
View it on GitHub:
https://github.com/geany/geany-themes/pull/55/files/a39fac2905866cb88f0d14c6f3df4c81fafc8b97..9568fc80d227ba2152cccbcc95342d94c1e90d92
You are receiving this because you are subscribed to this thread.

Message ID: 


[Github-comments] Re: [geany/geany-themes] Add Matcha Theme (PR #55)

2023-07-09 Thread Axel via Github-comments
@xelser pushed 1 commit.

9568fc80d227ba2152cccbcc95342d94c1e90d92  Merge branch 'geany:master' into 
matcha

-- 
View it on GitHub:
https://github.com/geany/geany-themes/pull/55/files/a39fac2905866cb88f0d14c6f3df4c81fafc8b97..9568fc80d227ba2152cccbcc95342d94c1e90d92
You are receiving this because you are subscribed to this thread.

Message ID: