[Github-comments] Re: [geany/geany] Prefix generated scope field by the "scope:" prefix (PR #3592)

2023-10-12 Thread elextr via Github-comments
Purple editors pencil has been deployed :-)

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3592#issuecomment-1760568000
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Use the official 'libreadtags' library from ctags for parsing ctags files (PR #3049)

2023-10-12 Thread elextr via Github-comments
@elextr requested changes on this pull request.

A couple of changes.

> @@ -1785,6 +1786,25 @@ This works basically the same as on other platforms::
 "c:\program files\geany\bin\geany" -g c:\mytags.php.tags 
c:\code\somefile.php
 
 
+Generating tags files using ctags
+*
+Geany supports loading tag files generated using the ``ctags`` command-line
+tool from the universal-ctags project 
(https://github.com/universal-ctags/ctags).
+Even though Geany should work with any ctags file, it is recommended to use
+certain fields to give Geany some additional information. The recommended 
fields
+are ``EfiklsZSt``, so, for instance, to generate tags for all sources in the 
geany

delete "for instance" and comma after "directory"

> +Generating tags files using ctags
+*
+Geany supports loading tag files generated using the ``ctags`` command-line
+tool from the universal-ctags project 
(https://github.com/universal-ctags/ctags).
+Even though Geany should work with any ctags file, it is recommended to use
+certain fields to give Geany some additional information. The recommended 
fields
+are ``EfiklsZSt``, so, for instance, to generate tags for all sources in the 
geany
+directory, one can use::
+
+ctags --fields=EfiklsZSt -o geany.c.tags -R geany
+
+Additional options may be given to the ``ctags`` tool, for instance, to 
restrict
+the generated tags file to some languages only, use certain tag kinds, etc.
+
+Note that when the ``l`` field (specifying the programming language for every 
tag)
+is enabled, the language of the tag is set based on this field instead of the

question, is it the tag or the symbol in Geany that gets the language specified?

> @@ -1689,12 +1689,13 @@ Global tags files can have three different formats:
 * Pipe-separated format
 * CTags format
 
-The first line of global tags files should be a comment, introduced
-by ``#`` followed by a space and a string like ``format=pipe``,
-``format=ctags`` or ``format=tagmanager`` respectively, these are
+For the tagmanager or pipe-separated format, the first line of global tag files
+should be a comment, introduced by ``#`` followed by a space and a string like

delete "a string like", its not "like" it is exactly one or other IIUC

>  case-sensitive.  This helps Geany to read the file properly. If this
 line is missing, Geany tries to auto-detect the used format but this
-might fail.
+might fail.  Tag files using the CTags format should be left unmodified in the

"used format" above s/b "format used"

(I know its not your change, but might as well fix it)

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3049#pullrequestreview-1675440113
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] New UI on windows is bloated and scaled up (Issue #3063)

2023-10-12 Thread elextr via Github-comments
> I don't see how it should get better by postponing to 2.1.

The obligatory last minute Windows change? ;-P

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3063#issuecomment-1760552595
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] [geany/geany] Support parsing scopeKind/p of ctags files (Issue #3598)

2023-10-12 Thread Jiří Techet via Github-comments
When given, it specifies the kind introducing the scope information. May be 
another way to speed up parsing of scope in addition to the sZ field.


-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3598
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Prefix generated scope field by the "scope:" prefix (PR #3592)

2023-10-12 Thread Jiří Techet via Github-comments
@elextr Would you mind having a look at the update of geany.txt I made in 
https://github.com/geany/geany/pull/3049 if it looks alright to you?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3592#issuecomment-1760450881
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Use the official 'libreadtags' library from ctags for parsing ctags files (PR #3049)

2023-10-12 Thread Jiří Techet via Github-comments
@techee pushed 1 commit.

bb64384a6af2631ff6f4168118ff27e0dff1c4b5  Update geany.txt with ctags usage for 
generating tag files

-- 
View it on GitHub:
https://github.com/geany/geany/pull/3049/files/d945009828e3c36b366a42448b009ea66f784090..bb64384a6af2631ff6f4168118ff27e0dff1c4b5
You are receiving this because you are subscribed to this thread.

Message ID: 


[Github-comments] Re: [geany/geany] New UI on windows is bloated and scaled up (Issue #3063)

2023-10-12 Thread Jiří Techet via Github-comments
> I don't see how it should get better by postponing to 2.1.

OK, I just thought it kind of died because of different opinions but I'm all 
for it myself.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3063#issuecomment-1760445091
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany-plugins] Fix ci version parser (PR #1278)

2023-10-12 Thread Enrico Tröger via Github-comments
Merged #1278 into master.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1278#event-10637128409
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] New UI on windows is bloated and scaled up (Issue #3063)

2023-10-12 Thread Enrico Tröger via Github-comments
I don't see how it should get better by postponing to 2.1.

To me, switching to @techee's version of the Prof-Gnome theme is a big 
improvement over the default theme. In the mean time, the website FAQ explains 
how to change the GTK theme on Windows, so users who do not like it, can change 
it themselves.

I think most of the participants here agree that Adwaita is not a good default 
and most of us agree on the modified version of Prof-Gnome. Only @kugel- could 
not be convinced yet and vice versa, @techee and me are not convinced that the 
Boomerang theme is a better choice.

Again, since there are now instructions on how to change the theme, the default 
theme is now only a default theme.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3063#issuecomment-1760396929
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Use the official 'libreadtags' library from ctags for parsing ctags files (PR #3049)

2023-10-12 Thread Jiří Techet via Github-comments
> At least we can easily change the PHP tags generation script when needed.

But we still need to support user's tag files possibly generated by older ctags 
versions so it should stay there for some time even if we update the php parser.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3049#issuecomment-1760381748
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Use the official 'libreadtags' library from ctags for parsing ctags files (PR #3049)

2023-10-12 Thread Jiří Techet via Github-comments
@techee pushed 3 commits.

e1ae976a7284d59f24b387825e967a2e6794a330  Add ctags 'readtags' library to allow 
us parse ctags files
d364c30e7973ceaf387f8c64211d3980a462f90b  Fix compilation when TM_DEBUG is 
defined
d945009828e3c36b366a42448b009ea66f784090  Use the readtags library to parse 
ctags files

-- 
View it on GitHub:
https://github.com/geany/geany/pull/3049/files/c5bfe6ace392f4f8c925de1fcb0e22efee94aed5..d945009828e3c36b366a42448b009ea66f784090
You are receiving this because you are subscribed to this thread.

Message ID: 


[Github-comments] Re: [geany/geany] Use the official 'libreadtags' library from ctags for parsing ctags files (PR #3049)

2023-10-12 Thread Enrico Tröger via Github-comments
> > We'll still need the "unknown" check to support older ctags binaries 
> > unfortunately.

At least we can easily change the PHP tags generation script when needed. 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3049#issuecomment-1760373686
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] CI: Fix version parsing and calculating for 2.0 (PR #3594)

2023-10-12 Thread Enrico Tröger via Github-comments
Didn't you like the second commit's message? :D

Done and thanks for review.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3594#issuecomment-1760362118
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] CI: Fix version parsing and calculating for 2.0 (PR #3594)

2023-10-12 Thread Enrico Tröger via Github-comments
Merged #3594 into master.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3594#event-10636857656
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-12 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request.



On doc/images/build_menu_commands_dialog.png:

It won't get better. No idea what I'm doing wrong.

I managed to scale the display to 60% (after enabling some experimental feature 
in mutter via gsettings and then changing the scale in some XML file) but it 
this really scales the display only, the GTK widgets are still huge.
Completely unmodified Gnome:
![debian_bookworm_vm_huge](https://github.com/geany/geany/assets/617017/3aa0190c-897d-428c-8a64-e580114711ea)
Scaled down to 60% but the widgets are still huge:
![debian_bookworm_vm_scaled_60](https://github.com/geany/geany/assets/617017/4fdb1d11-3135-4b25-9e42-312f5e4ec225)

Either someone else can create the screenshots or I will use my local Xfce with 
Adwaita theme to create them.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3593#discussion_r1357417559
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Fix goto popup location (PR #3316)

2023-10-12 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request.



> + if (sci_get_line_from_position(sci, pos_next) == line)
+   char_width = SSM(sci, SCI_POINTXFROMPOSITION, 0, pos_next) - x;

I guess I feel like the popup should be under the letter the caret is at (not 
sure what are the real differences between having the caret over or before a 
character though, offsets should be pretty much the same… but this is kind of 
irrelevant to the feel :))

> But don't hesitate to implement it your way if this is something that bothers 
> you :-).

You nailed it I guess :D

I went ahead and implemented the more basic version that is similar to what was 
there but don't produce incorrect results on the wrapping corner case.  So I'm 
happier, and you're not too unhappy because it's not as complicated as it could 
be :grin: 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3316#discussion_r1357412991
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Fix goto popup location (PR #3316)

2023-10-12 Thread Colomban Wendling via Github-comments
@b4n pushed 1 commit.

3498fe12a3be953511b810e568991e4149f2613a  Fix popup position on a wrapping 
corner case

-- 
View it on GitHub:
https://github.com/geany/geany/pull/3316/files/4a2999c18e2db59bb40b90ad6453732a2596a316..3498fe12a3be953511b810e568991e4149f2613a
You are receiving this because you are subscribed to this thread.

Message ID: 


[Github-comments] Re: [geany/geany] New UI on windows is bloated and scaled up (Issue #3063)

2023-10-12 Thread Jiří Techet via Github-comments
Yeah, I'm afraid it's time to create the 2.1 milestone ;-).

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3063#issuecomment-1760342824
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] New UI on windows is bloated and scaled up (Issue #3063)

2023-10-12 Thread Colomban Wendling via Github-comments
@eht16 @techee are we really gonna do something about this for next release, or 
is this lingering from release to release? :slightly_smiling_face: 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3063#issuecomment-1760315004
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Fix meson build without git repo (PR #3578)

2023-10-12 Thread Colomban Wendling via Github-comments
Submitted my version as #3597

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3578#issuecomment-1760302273
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] [geany/geany] Fix meson build without git repo (PR #3597)

2023-10-12 Thread Colomban Wendling via Github-comments
Fixes #3424.

This is my alternate proposal over #3578, as suggested there.  If nobody 
complains, Ill use that -- but even better, somebody else could test and 
merge :wink: 
You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany/pull/3597

-- Commit Summary --

  * Fix meson build without git repo

-- File Changes --

M meson.build (10)

-- Patch Links --

https://github.com/geany/geany/pull/3597.patch
https://github.com/geany/geany/pull/3597.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3597
You are receiving this because you are subscribed to this thread.

Message ID: geany/geany/pull/3...@github.com


[Github-comments] Re: [geany/geany] Do not enable Scintilla's Change History by default (PR #3591)

2023-10-12 Thread Colomban Wendling via Github-comments
Merged #3591 into master.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3591#event-10636308048
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] CI: Fix version parsing and calculating for 2.0 (PR #3594)

2023-10-12 Thread Colomban Wendling via Github-comments
@b4n approved this pull request.

LGTM, but you could squash the second commit into the first :wink: 



-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3594#pullrequestreview-1675065827
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Use the official 'libreadtags' library from ctags for parsing ctags files (PR #3049)

2023-10-12 Thread Colomban Wendling via Github-comments
> We'll still need the "unknown" check to support older ctags binaries 
> unfortunately.

Sure, but it'll still make it more coherent.  Unless we fear it'd break 
compatibility at some level…

> OK to rebase this branch on top of master so it can be more easily tested 
> with the php and py tag files? I'd also squash the commits a bit.

Sure, fine with me.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3049#issuecomment-1760275309
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Prefix generated scope field by the "scope:" prefix (PR #3592)

2023-10-12 Thread Jiří Techet via Github-comments
> But if uctags still generates the parent_kind:A::B::C form the problem will 
> still apply in the case of ctags generated files without sZ so needs to still 
> be able to read those files. And document the ctags option as recommended 
> somewhere.

The documentation is a good point, I'll write something.

> How "slow" is it in reality? After all tags are only read once, even seconds 
> is likely to be acceptable.

I haven't benchmarked that, it probably just "doesn't feel right" than being 
some real problem.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3592#issuecomment-1760097675
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Use the official 'libreadtags' library from ctags for parsing ctags files (PR #3049)

2023-10-12 Thread Jiří Techet via Github-comments
> Good catch. Maybe it'd be worth submitting an update to that parser to be 
> more in line with the convention as well.

We'll still need the "unknown" check to support older ctags binaries 
unfortunately.

OK to rebase this branch on top of master so it can be more easily tested with 
the php and py tag files? I'd also squash the commits a bit.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3049#issuecomment-1760091651
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] update czech translation (PR #3595)

2023-10-12 Thread zenobit via Github-comments
@zen0bit commented on this pull request.



>  msgid "_Backspace key unindents"
-msgstr "Klávesa tabelátor odsazuje"
+msgstr "_Klávesa tabelátor odsazuje"

done

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3595#discussion_r1357170933
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] update czech translation (PR #3595)

2023-10-12 Thread zenobit via Github-comments
@zen0bit pushed 1 commit.

b0f2d909332fdbc447003a349a40a0de460b1d6b  update czech translation

-- 
View it on GitHub:
https://github.com/geany/geany/pull/3595/files/0821da0a2600de5e9876dfd89777205e7e4fd40a..b0f2d909332fdbc447003a349a40a0de460b1d6b
You are receiving this because you are subscribed to this thread.

Message ID: 


[Github-comments] [geany/geany-plugins] git-changebar: Re-set first visible line after Scintilla size request (PR #1280)

2023-10-12 Thread Jiří Techet via Github-comments
After updating to Scintilla 5.3.7 the Scintilla popup with the diff against git 
shows the wrong number.

It seems that gtk_widget_set_size_request() scrolls Scintilla view so despite 
it was set previously, it isnt set correctly after this call and has to be 
re-set.

Note that the call to SCI_SETFIRSTVISIBLELINE has to stay at the original 
location too, otherwise subsequent calculation using SCI_POINTXFROMPOSITION 
doesnt work because the line may not be visible.

@b4n Does this look OK to you? Maybe theres a better way to fix this 
problem so take this only as a hint where the problem is.

Fixes #1279 
You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany-plugins/pull/1280

-- Commit Summary --

  * git-changebar: Re-set first visible line after Scintilla size request

-- File Changes --

M git-changebar/src/gcb-plugin.c (4)

-- Patch Links --

https://github.com/geany/geany-plugins/pull/1280.patch
https://github.com/geany/geany-plugins/pull/1280.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1280
You are receiving this because you are subscribed to this thread.

Message ID: geany/geany-plugins/pull/1...@github.com


[Github-comments] Re: [geany/geany] update czech translation (PR #3595)

2023-10-12 Thread Andrej Herceg via Github-comments
@andrej-herceg commented on this pull request.



>  msgid "_Backspace key unindents"
-msgstr "Klávesa tabelátor odsazuje"
+msgstr "_Klávesa tabelátor odsazuje"

backspace here?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3595#pullrequestreview-1674087373
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Use the official 'libreadtags' library from ctags for parsing ctags files (PR #3049)

2023-10-12 Thread Colomban Wendling via Github-comments
> > I wrote most of it, it ought to be perfect 
> 
> Oh, I'm syncing it in the wrong direction - I should have updated ctags with 
> your code :-).

Meh, I also wrote some of that one, so either way works :grinning: 

> I discovered one more problem - all parsers use `typeref:typename` but I just 
> discovered after looking at Enrico's php tags file and at the php parser 
> afterwards that php uses `typeref:unknown` for typenames for some reason. So 
> I updated the code to allow `unknown` behind `typeref` too.

Good catch.  Maybe it'd be worth submitting an update to that parser to be more 
in line with the convention as well.

> Maybe should I also grab the latest version of the libreadtags library for 
> this PR? I noticed you also submitted some patch to it in the spring.

I didn't check the diff, but my latest changes there were not crucial, they 
fixed C stdlib usage, and some very theoretical issues handling some non-ASCII 
bytes.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3049#issuecomment-1759182634
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Shortcut to add/insert semicolon to end of line (Discussion #3596)

2023-10-12 Thread Richard3134 via Github-comments
Many thanks elextr. The auto-close plugin adds semicolon while typing a know 
function, therefore it should be enough in most circumstances. I will implement 
your suggestion anyway because I am wondering if this plugin is not interfering 
with Firefox somehow. I have some keyboards issue in Firefox that I solve 
closing Geanystrange. Thanks a lot for your help. Regards. Richard

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/discussions/3596#discussioncomment-7260035
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Shortcut to add/insert semicolon to end of line (Discussion #3596)

2023-10-12 Thread elextr via Github-comments
There is no built-in "add semicolon at EOL" action, so you can't just set a 
keybinding.  

You might be able to define a macro with suitable keystrokes using the 
geanymacro plugin and assign that a keybinding.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/discussions/3596#discussioncomment-7259956
You are receiving this because you are subscribed to this thread.

Message ID: