[Github-comments] Re: [geany/geany] update czech translation (PR #3595)
Merged #3595 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3595#event-10656894364 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Use the official 'libreadtags' library from ctags for parsing ctags files (PR #3049)
@elextr commented on this pull request. > +Generating tags files using ctags +* +Geany supports loading tag files generated using the ``ctags`` command-line +tool from the universal-ctags project (https://github.com/universal-ctags/ctags). +Even though Geany should work with any ctags file, it is recommended to use +certain fields to give Geany some additional information. The recommended fields +are ``EfiklsZSt``, so, for instance, to generate tags for all sources in the geany +directory, one can use:: + +ctags --fields=EfiklsZSt -o geany.c.tags -R geany + +Additional options may be given to the ``ctags`` tool, for instance, to restrict +the generated tags file to some languages only, use certain tag kinds, etc. + +Note that when the ``l`` field (specifying the programming language for every tag) +is enabled, the language of the tag is set based on this field instead of the Yep fine. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3049#discussion_r1359669807 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] New UI on windows is bloated and scaled up (Issue #3063)
> based on my preference For thermes everyone does, so no problem. (Its also why there is so much discussion on themes) -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3063#issuecomment-1763203451 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Windows: Include "Prof-Gnome" GTK theme from geany-osx (PR #3129)
If this PR is going to get merged, I'd just suggest also applying the following patch on top of the theme. https://github.com/geany/geany-osx/blob/master/prof_gnome_windows_changes.patch It changes text colors to #00 instead of the slightly gray which is native for macOS, and also reduces the size of the status bar. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3129#issuecomment-1763170674 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-osx] Add a patch with Windows-specific changes to Prof-Gnome (PR #35)
Closed #35. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-osx/pull/35#event-10655784846 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Windows: Include "Prof-Gnome" GTK theme from geany-osx (PR #3129)
I NAK'd the theme but I don't want to block any Adwaita-replacement so please go for it. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3129#issuecomment-1763146890 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] New UI on windows is bloated and scaled up (Issue #3063)
I don't have enough time and motivation to play with themes on windows anytime soon. Go with whatever you agreed. While I NAK'd #3129 on based on my preference (so biased) I was also clear that I won't block it (or any other theme) as long as we swap out Adwaita. So I'm in favor of merging #3129 over post-poning. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3063#issuecomment-1763144730 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Update meson.build also on version bumps (PR #3599)
@kugel- commented on this pull request. > @@ -23,6 +23,7 @@ s/^\(#define VER_FILEVERSION_STR *\)[^ ].*$/\1"'"$VER"'"/ ' -i geany_private.rc sed -e 's/^\(AC_INIT([^,]*, *\[\)[^]]*\(\],\)/\1'"$VER"'\2/' -i configure.ac +sed -e 's/^\( *version: *\)[^,]*\(,\)/\1'"\'$VER\'"'\2/' -i meson.build Rather greedy. For OK, but I *will* add another line that matches one day or another. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3599#pullrequestreview-1678401351 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Update meson.build also on version bumps (PR #3599)
@kugel- approved this pull request. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3599#pullrequestreview-1678401360 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Prefix generated scope field by the "scope:" prefix (PR #3592)
> How "slow" is it in reality? After all tags are only read once, even seconds > is likely to be acceptable. I just tested it and it's actually about the same both with and without `scope:`. Roughly 1 million tags per second. So while I still think the patch is worth applying, it can wait after 2.0. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3592#issuecomment-1763059572 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Use the official 'libreadtags' library from ctags for parsing ctags files (PR #3049)
@techee commented on this pull request. > +Generating tags files using ctags +* +Geany supports loading tag files generated using the ``ctags`` command-line +tool from the universal-ctags project (https://github.com/universal-ctags/ctags). +Even though Geany should work with any ctags file, it is recommended to use +certain fields to give Geany some additional information. The recommended fields +are ``EfiklsZSt``, so, for instance, to generate tags for all sources in the geany +directory, one can use:: + +ctags --fields=EfiklsZSt -o geany.c.tags -R geany + +Additional options may be given to the ``ctags`` tool, for instance, to restrict +the generated tags file to some languages only, use certain tag kinds, etc. + +Note that when the ``l`` field (specifying the programming language for every tag) +is enabled, the language of the tag is set based on this field instead of the Oh, my response from yesterday disappeared somewhere. So once again - you mean whether to use the word "tag" or "symbol" here, right? I checked geany.txt and we only use "tags" in "tags file" but never talk about tags themselves so probably "symbol" is the correct one here. I've modified it to: ``` Note that when the ``l`` field (specifying the programming language) is enabled, the language of all symbols is set based on the value of this field instead of the language specified in the extension of the tags file. ``` Does it sound OK? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3049#discussion_r1359479477 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] update czech translation (PR #3595)
just to be same as original (poedit complain) -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3595#issuecomment-1762820654 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Link to libiconv explicitly for Windows/mingw64 builds (PR #3600)
@b4n approved this pull request. You gotta do what you gotta do I guess -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3600#pullrequestreview-1678012613 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Fix meson build without git repo (PR #3578)
Closing in favor to #3597. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3578#issuecomment-1762816343 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Fix meson build without git repo (PR #3578)
Closed #3578. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3578#event-10653093939 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Meson build assumes presence of git repository (Issue #3424)
Closed #3424 as completed via #3597. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3424#event-10653091225 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Fix meson build without git repo (PR #3597)
Merged #3597 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3597#event-10653091149 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] ctags: Matlab: generate tag with only the function name, not the function name plus arguments (PR #3358)
Excellent! Thank you very much :) -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3358#issuecomment-1762784057 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] ctags: Matlab: ignore defs within block comments and allow spaces before function defs (PR #3563)
> I need to understand how to integrate the parsing function with the rest of > ctags I think the only thing you have to do is to overwrite the existing regex-based parser with the code of this parser. And then have a look at the unit tests to see what fails. > I'd consider at least pulling https://github.com/geany/geany/pull/3358 Done, thanks! -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3563#issuecomment-1762773338 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] ctags: Matlab: generate tag with only the function name, not the function name plus arguments (PR #3358)
I had a look at the code and it appears to do the right thing. The changes seem simple enough that they shouldn't cause any problems - so even though we are close to release, I'm merging this. Thanks! -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3358#issuecomment-1762771062 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] ctags: Matlab: generate tag with only the function name, not the function name plus arguments (PR #3358)
Merged #3358 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3358#event-10652554773 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Add templates to Config Files menu (PR #3396)
@ntrel @elextr I tested and it works great. Apart from the little remark on the docs, I'm fine with this. About the section comment in the docs, this is no big deal, we can also leave as it is. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3396#issuecomment-1762744605 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Spellecheck: Update style mappings (PR #1277)
Yesterday I noticed that the GeanyLua plugin also uses Scintilla 5.x API and so the version requirement bump is more than justified I think. Adding conditionals in mutiple plugins only for a hypothetical backwards compability seems not very reasonable. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1277#issuecomment-1762743234 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] GitChangebar: disable Scintilla's Change History in diff tooltip (PR #1281)
FTR: the used theme on the screenshot is Inkpot. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1281#issuecomment-1762742754 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Link to libiconv explicitly for Windows/mingw64 builds (PR #3600)
@elextr just for you, the classic last minute Windows fix. This was removed as part of https://github.com/geany/geany/pull/3465 a few months ago. I was very sure I tested this properly but it turned out that the explicit link to `libiconv` is necessary for building on Windows. However it is not necessary for the cross compilation toolchain in the CI but also don't hurt. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3600#issuecomment-1762742277 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] [geany/geany] Link to libiconv explicitly for Windows/mingw64 builds (PR #3600)
This was removed in e465a2b456e7c0aba6aefc1c4b406b8089386d1a erroneously but it still needed on Windows/mingw64 builds. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/3600 -- Commit Summary -- * Link to libiconv explicitly for Windows/mingw64 builds -- File Changes -- M configure.ac (1) -- Patch Links -- https://github.com/geany/geany/pull/3600.patch https://github.com/geany/geany/pull/3600.diff -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3600 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Fix meson build without git repo (PR #3597)
@eht16 approved this pull request. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3597#pullrequestreview-1677927392 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Fix meson build without git repo (PR #3597)
+1 let's merge. Successfully tested on native Windows with Git installed and without, with `.git` vailable and without. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3597#issuecomment-1762740662 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] [geany/geany] Update meson.build also on version bumps (PR #3599)
We missed to update `scripts/version-bump` for Meson and so `meson.build` still thought we are about to release Geany 1.38 :smile:. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/3599 -- Commit Summary -- * Update meson.build also on version bumps -- File Changes -- M meson.build (2) M scripts/version-bump (1) -- Patch Links -- https://github.com/geany/geany/pull/3599.patch https://github.com/geany/geany/pull/3599.diff -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3599 You are receiving this because you are subscribed to this thread. Message ID:
