[Github-comments] Re: [geany/geany] Maximum number of files that can be opened in a single instance of Geany? (Discussion #3754)
Yeah, it would need an inter-process lock around the critical section "test for existence of socket and create it if not" which would have to be [windows specific](https://learn.microsoft.com/en-us/windows/win32/sync/interprocess-synchronization) code since glib doesn't seem to have any inter-process stuff, just inter-thread. All it needs is a windows developer to contribute. It works on Linux because the file manager (at least Nemo that I tested) uses one command with lots of filenames. @iahung3 see, you were able to provide more helpful clarification (that you selected multiple files at once in explorer) and useful information (that it was sometimes random) that helped others to help you, don't give up so easy, try to describe _exactly_ what you did as if you are guiding a new computer user on the other end how to reproduce. :-) -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/discussions/3754#discussioncomment-8511847 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] update fortran keywords (PR #3656)
@gnikit thanks. I just noticed a comment on the OP that some names are in more than one list. That won't break anything, but it will have performance effects. The lexer has to search all lists for every identifier it finds (so all your variable names, function names, etc as well as keywords, it doesn't know they are keywords until it finds them in a list) so duplicating names makes lists bigger which will slow the lexer down searching them, especially for those identifiers not in a list (it does a linear search of names with the same start character in each list). Maybe somebody might want to "optimise" it, it won't hurt to delay for a bit since there is no release on the horizon. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3656#issuecomment-1951597787 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Add Pinner plugin (PR #1308)
Couple of comments: 1. write the documentation explaining what this plugin is supposed to do, sounds like it does something different to what @eht16 understood "pin" to mean, and I have always been confused about what it was meant to do. (and do not describe it in terms of some other software, eg do not say "like firefox/eclipse/vscode/libreoffice" ;-) [end getting in ahead] That will mean that you can get relevant guidance. 2. relating to https://github.com/geany/geany/pull/3770 and depending on the answer to the above, you should be working with notebook pages, not documents. I'm pretty sure that plugins can open pages that do not have documents, let alone files. 3. And a hint always check `document_valid()` on a document pointer in any callback if you pass it via the data pointer, the user can always close pages and documents or reorder pages manually. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1308#issuecomment-1951578796 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Return NULL from document_get_current() if document is 'untitled' (PR #3770)
Closed #3770. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3770#event-11843007945 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Return NULL from document_get_current() if document is 'untitled' (PR #3770)
This break `document_get_current()` when the document has no filename. That means any functionality that uses `document_get_current()` won't work on a document that the user has not given a filename. I will add further comments on the plugin. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3770#issuecomment-1951563352 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] [geany/geany] Return NULL from document_get_current() if document is 'untitled' (PR #3770)
I ran into a little problem when testing my pinner plugin. When using document_get_current(), the 'file_name' member was NULL even if the value returned by document_get_current() was not NULL and 'is_valid' was 1. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/3770 -- Commit Summary -- * Return NULL from document_get_current() if document is 'untitled' -- File Changes -- M src/document.c (11) -- Patch Links -- https://github.com/geany/geany/pull/3770.patch https://github.com/geany/geany/pull/3770.diff -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3770 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] xsession errors (Issue #3768)
they probably use negative margins or paddings and (probably empty) element ends up with negative dimensions -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3768#issuecomment-1951467425 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Add CodeQL Analysis workflow (PR #3769)
> Sounds good. > > * For the next time, a description to describe what is the PR about and > more importantly why, is generally a good idea. Understood! > > * We could add `*.py` to the patterns and `python` to the matrix to also > cover the Python helper scripts in the repository. Done. > > * Also, could you strip the commented code from the workflow definition > and also the extensive description comments? I think they are not very useful. Done. >Adding workflow_dispatch: might be a good idea to manually re-run the >workflow. Done. Some examples of this workflow include a cron schedule as well. Would you like that added, and if so, how often should it be scheduled? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3769#issuecomment-1951462845 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Add CodeQL Analysis workflow (PR #3769)
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on [this overview](/geany/geany/security/code-scanning?query=pr%3A3769+is%3Aopen). Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out [the documentation](https://docs.github.com/code-security/code-scanning/automatically-scanning-your-code-for-vulnerabilities-and-errors/about-code-scanning). -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3769#issuecomment-1951452398 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Add CodeQL Analysis workflow (PR #3769)
@andy5995 pushed 1 commit. 2c58e9dcc9f9fc5250e57b1eb53d66a9cd393448 strip comments, add workflow_patch trigger, enable python -- View it on GitHub: https://github.com/geany/geany/pull/3769/files/14ef5fe702b42309fcd9e0fd1088b28e871cb6c5..2c58e9dcc9f9fc5250e57b1eb53d66a9cd393448 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] update fortran keywords (PR #3656)
@gnikit approved this pull request. Things look fine, albeit a bit hard to read. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3656#pullrequestreview-1887316150 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] xsession errors (Issue #3768)
I tried the standard adwaita theme.. no more errrors or warnings from Geany anymore! so now i finally know why, thanks a lot! -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3768#issuecomment-1951428551 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] xsession errors (Issue #3768)
@intact that might be the problem, never thought of that. I use Matcha theme -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3768#issuecomment-1951421313 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] xsession errors (Issue #3768)
Your gtk theme probably do that -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3768#issuecomment-1951413412 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Add CodeQL Analysis workflow (PR #3769)
Adding ` workflow_dispatch:` might be a good idea to manually re-run the workflow. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3769#issuecomment-1951381789 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Add Pinner plugin (PR #1308)
> @eht16 It looks like we were working on something different but similar? ;) I > think incorporating something like that into this plugin would be suitable. Yes, my approach was for a different use case. I like to have a tab/document always in the visible area of the notebook tab list for easy access. The name of your plugin sounded like this to me in the beginning :). -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1308#issuecomment-1951381167 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Add CodeQL Analysis workflow (PR #3769)
Sounds good. - For the next time, a description to describe what is the PR about and more importantly why, is generally a good idea. - We could add `*.py` to the patterns and `python` to the matrix to also cover the Python helper scripts in the repository. - Also, could you strip the commented code from the workflow definition and also the extensive description comments? I think they are not very useful. - I enabled the mentioned "github/*" actions. In general we restrict the usable actions to the necessary ones for security reasons. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3769#issuecomment-1951380412 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Maximum number of files that can be opened in a single instance of Geany? (Discussion #3754)
Good guess. I tested this and Windows Explorer in fact spawns a single Geany process per selected file and then this happens what @elextr described above. There is probably no easy solution. Making the initial startup faster until the socket connection is checked or implementing some other kind of early locking could make it better but there might be still systems or situations where the startup of the first process is slow enough than the second does not yet see the first one. Maybe Windows Explorer can be told to start one only process and pass all files to it but I don't know whether this is possible. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/discussions/3754#discussioncomment-8508160 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Add Pinner plugin (PR #1308)
I moved this to https://github.com/andy5995/pinner -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1308#issuecomment-1951367227 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Add Pinner plugin (PR #1308)
Closed #1308. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1308#event-11840560015 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Japanese(and other) characters show up as boxes in Geany on Windows 10 (#1805)
Also, these fonts are Windows fonts and it would be illegal to redistribute them. As it says [here](https://learn.microsoft.com/en-us/typography/fonts/font-faq#redistribution-and-extended-rights) "you may not redistribute the Windows fonts". -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1805#issuecomment-1951017313 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Japanese(and other) characters show up as boxes in Geany on Windows 10 (#1805)
@Asmageddon fonts have to be installed on windows, they are not part of Geany. If a user wants a font with CJK characters they need to install one. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1805#issuecomment-1950999406 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Japanese(and other) characters show up as boxes in Geany on Windows 10 (#1805)
@eht16 Perhaps at least, you could switch the default font to one of those, and include Asian characters in the preview in order to notice and prevent the problem on user side? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1805#issuecomment-1950998168 You are receiving this because you are subscribed to this thread. Message ID:
