[Github-comments] Re: [geany/geany] Add CodeQL Analysis workflow (PR #3769)
No worries @eht16 , I know mistakes happen to humans. Cheers! -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3769#issuecomment-2002704998 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Add Raku (Perl 6) filetype support (lexer and ctags parser) (PR #3169)
> I gave it some testing and it works fine. I want to repeat I'm really bad at > Perl and saw Raku the first time now. Btw, I did not fell in love with it :D. Good, I was worried we'd have to rewrite Geany in it :-) > The perl6.c parser is taken from uctags, I assume. If so, we probably should > to rename it as it was done in > https://github.com/universal-ctags/ctags/pull/3777. I'm aware of that, I was just thinking it could be done during the next "ctags sync" if it's not a problem. > Geany detects > https://github.com/Raku/examples/blob/master/categories/games/blackjack.p6 as > Perl even the file extension tells Raku. This is because of the shebang in > the file. I totally missed that one, thanks! I've just made a fixup commit with the proposed fix. Is anything else missing? If there are no other problems, I'd like to merge this PR so we are finally done with it. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3169#issuecomment-2002640244 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Add Raku (Perl 6) filetype support (lexer and ctags parser) (PR #3169)
@techee pushed 1 commit. 3b666ca60dc70039b6ede71a9323eb994256f6b4 fixup! Add Raku (Perl 6) filetype support (lexer and ctags parser) -- View it on GitHub: https://github.com/geany/geany/pull/3169/files/1f3c9d53effcf0c242430f4cdd5ab843d9b4c1bd..3b666ca60dc70039b6ede71a9323eb994256f6b4 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Hiding Some Type of Files in the Explorer (Issue #1258)
Closed #1258 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1258#event-12144105120 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] projectorganizer: prjorg-sidebar.c: returning 'void **' from a function with incompatible return type 'gchar **' (Issue #1297)
Closed #1297 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1297#event-12144100618 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] projectorganizer: prjorg-sidebar.c: Cast g_ptr_array_free to gchar** (PR #1298)
Ah, OK, I noticed this PR only after merging https://github.com/geany/geany-plugins/pull/1315 which eliminates some more warnings including this one. So I'm closing this and https://github.com/geany/geany-plugins/issues/1297. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1298#issuecomment-2002625366 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] projectorganizer: prjorg-sidebar.c: Cast g_ptr_array_free to gchar** (PR #1298)
Closed #1298. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1298#event-12144100215 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] geanyctags: eliminate some warnings and update the readtags library (PR #1317)
Merged #1317 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1317#event-12144095700 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] projectorganizer: Eliminate some compiler warnings (PR #1315)
Merged #1315 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1315#event-12144095081 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Disable autocompletion for most non-programming/non-scripting languages (PR #3575)
Closed #3575. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3575#event-12144078537 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] `Use Windows native dialogs` is broken (Issue #3627)
> If the setting is in `geany.glade` how come it doesn't show on Linux? If you have a close look at the changes in #3791, your question will be answered :D. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3627#issuecomment-2002545082 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] [geany/geany] Remove "Use Windows native dialogs" GUI setting (PR #3791)
This is a left-over from #3219 and should have been removed already. Fixes #3627. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/3791 -- Commit Summary -- * Remove "Use Windows native dialogs" GUI setting -- File Changes -- M data/geany.glade (16) M src/prefs.c (3) -- Patch Links -- https://github.com/geany/geany/pull/3791.patch https://github.com/geany/geany/pull/3791.diff -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3791 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-osx] Open dialog enter file path text (#14)
> > I'll try to have a look at it if it would require many changes in Geany to > > migrate to this class. > > It would need to be optional Why would it need to be optional? If it works well on relevant platforms and do not introduce too much restrictions, why not use it completely? > but I think the checkbox from the windows native dialogs is still in Glade > unless @eht16 got around to removing it ;-) thanks for the reminder :D. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-osx/issues/14#issuecomment-2002542469 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] geanyctags: eliminate some warnings and update the readtags library (PR #1317)
LGBI. I didn't test the changes, @techee I guess you did. If so, I think we can merge this. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1317#issuecomment-2002538765 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] vimode: eliminate a warning (PR #1316)
Merged #1316 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1316#event-12143453175 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Add Raku (Perl 6) filetype support (lexer and ctags parser) (PR #3169)
> Agree with @techee and I could give it a bit of testing, though this might
> takes a few weeks.
s/few weeks/few years/ but we are all patient :).
I gave it some testing and it works fine. I want to repeat I'm really bad at
Perl and saw Raku the first time now. Btw, I did not fell in love with it :D.
The perl6.c parser is taken from uctags, I assume. If so, we probably should to
rename it as it was done in https://github.com/universal-ctags/ctags/pull/3777.
Geany detects
https://github.com/Raku/examples/blob/master/categories/games/blackjack.p6 as
Perl even the file extension tells Raku. This is because of the shebang in the
file. The following change should solve it by first checking for "perl6" and
only then "perl".
```diff
@@ -604,6 +605,7 @@ static GeanyFiletype *find_shebang(const gchar
*utf8_filename, const gchar *line
{ "sh", GEANY_FILETYPES_SH },
{ "bash", GEANY_FILETYPES_SH },
{ "dash", GEANY_FILETYPES_SH },
+ { "perl6", GEANY_FILETYPES_RAKU },
{ "perl", GEANY_FILETYPES_PERL },
{ "python", GEANY_FILETYPES_PYTHON },
{ "php",GEANY_FILETYPES_PHP },
```
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3169#issuecomment-2002536714
You are receiving this because you are subscribed to this thread.
Message ID:
[Github-comments] Re: [geany/geany] Add CodeQL Analysis workflow (PR #3769)
Merged #3769 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3769#event-12143071778 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Add CodeQL Analysis workflow (PR #3769)
> > > Adding ` workflow_dispatch:` might be a good idea to manually re-run the > > > workflow. > > > > > > I would still recommend this simple change. > > And it seems the configuration still has syntax errors: > > https://github.com/geany/geany/actions/runs/8135027731/workflow > > That seems outdated. I added the workflow_dispatch and fixed the cron > syntax/indentation about a week ago. Sorry, I guess I didn't properly refresh this page and so commented on the old code. Looks good to me now. Thanks. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3769#issuecomment-2002485389 You are receiving this because you are subscribed to this thread. Message ID:
