[Github-comments] [geany/geany] Increase the default width for the sidebar (PR #3637)
This should prevent the sidebar from being cutoff or clipped of the window. The new value is about 25% of the default window width. Closes #3630. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/3637 -- Commit Summary -- * Increase the default width for the sidebar -- File Changes -- M src/keyfile.c (3) -- Patch Links -- https://github.com/geany/geany/pull/3637.patch https://github.com/geany/geany/pull/3637.diff -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3637 You are receiving this because you are subscribed to this thread. Message ID: geany/geany/pull/3...@github.com
[Github-comments] Re: [geany/geany] `Use Windows native dialogs` is broken (Issue #3627)
Yes. I was very surprised as I jst noticed it is still in the Glade file. Sorry, will remove it soon. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3627#issuecomment-1774032078 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Add meson.build to release howto and replace IRC by Matrix (PR #3633)
@eht16 commented on this pull request. > @@ -24,7 +24,8 @@ version number (e.g. `/home/geany/publish-release 1.36`). Make sure the public part of the GPG key used to sign the archives can be found on the download page. -Windows builds (enrico?). +Windows builds are created mostly by Enrico following the instructions on On a more serious note, I hope we will update this part again in the future. Recently I had to solve the first quirk with running current MSYS2 packages on my old Windows 7 VM which is not supported anymore. As stated before, I will *not* upgrade to any newer Windows version ever. So, either we find another lost soul to have fun with Windows or we use the CI build scripts to create release builds (which is entirely possible already). -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3633#discussion_r1367862031 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Add meson.build to release howto and replace IRC by Matrix (PR #3633)
@eht16 commented on this pull request. > @@ -24,7 +24,8 @@ version number (e.g. `/home/geany/publish-release 1.36`). Make sure the public part of the GPG key used to sign the archives can be found on the download page. -Windows builds (enrico?). +Windows builds are created mostly by Enrico following the instructions on Ha, I wouldn't recommend that. It's already a few decades around but still buggy from time to time. Also it needs lots of resources, mainly water and food to work properly and somtimes even do weird output. Not sure I would recommend this application. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3633#discussion_r1367861607 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/www.geany.org] Add missing "of" in home.html (PR #48)
Thank you! -- Reply to this email directly or view it on GitHub: https://github.com/geany/www.geany.org/pull/48#issuecomment-1773930553 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] [geany/geany-plugins] Add version-bump script (PR #1288)
Its pretty much the same as in Geany, without codename and for the G-P relevant files. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany-plugins/pull/1288 -- Commit Summary -- * Add version-bump script -- File Changes -- A build/version-bump (32) -- Patch Links -- https://github.com/geany/geany-plugins/pull/1288.patch https://github.com/geany/geany-plugins/pull/1288.diff -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1288 You are receiving this because you are subscribed to this thread. Message ID: geany/geany-plugins/pull/1...@github.com
[Github-comments] Re: [geany/geany] Add missing space before "(without the path)" (PR #3635)
Merged #3635 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3635#event-10732156594 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] "Name" and "Value" is not translatable in Preferences dialog (Issue #3628)
Good catch! I'm a bit surprised that this wasn't noticed earlier. Anyway, #3634 should fix it. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3628#issuecomment-1773925853 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] [geany/geany] Enable translations in the "Various" tab in preferences dialog (PR #3634)
config.h is needed as it defines the GETTEXT_PACKAGE which is necessary to enable translations at all. Fixes #3628. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/3634 -- Commit Summary -- * Enable translations in the Various tab in preferences dialog -- File Changes -- M src/stash.c (4) -- Patch Links -- https://github.com/geany/geany/pull/3634.patch https://github.com/geany/geany/pull/3634.diff -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3634 You are receiving this because you are subscribed to this thread. Message ID: geany/geany/pull/3...@github.com
[Github-comments] [geany/geany] Add meson.build to release howto and replace IRC by Matrix (PR #3633)
You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/3633 -- Commit Summary -- * Add meson.build to release howto and replace IRC by Matrix -- File Changes -- M doc/making-a-release (7) -- Patch Links -- https://github.com/geany/geany/pull/3633.patch https://github.com/geany/geany/pull/3633.diff -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3633 You are receiving this because you are subscribed to this thread. Message ID: geany/geany/pull/3...@github.com
[Github-comments] Re: [geany/geany] Translation for status bar not being used (Issue #3620)
The Geany Windows installer has been replaced with updated translation files (binaries are untouched). @scootergrisen could you test the installer again? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3620#issuecomment-1773418145 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Translation for status bar not being used (Issue #3620)
I should have done as well. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3620#issuecomment-1773206928 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Translation for status bar not being used (Issue #3620)
Ah funny, G-P behaves differently. There is no `update-gmo` target and the files seem to have been updated yesterday when building. This reminds me of the change to `autopoint` (#2938) which we did not yet do for G-P and so maybe the stale `*.gmo` problem is rather new. I think I will update the Geany Windows installer with the updated gmo files. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3620#issuecomment-1773201408 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Context menu item "_Join Lines" missing translation (Issue #3621)
Very likely sasme cause as in #3620 :(. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3621#issuecomment-1773188180 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Translation for status bar not being used (Issue #3620)
Unfortunately, this is possible and after some testing even likely. But this raises more questions :(. First I deleted po/da.gmo, expecting that `make` or `make install` will regenerate it. But they didn't. Instead `make install` raised an error: ``` /usr/bin/install: cannot stat './da.gmo': No such file or directory installing ./da.gmo as /home/enrico/build/build_geany/share/locale/da/LC_MESSAGES/geany.mo ``` but it continued to install everything else. After studying `po/Makefile` a bit, I noticed there is a target `update-gmo` which regenerates the `*.gmo' files. This target is only indirectly by `update-po`. This would explain why @b4n and me had some old files laying around and why we probably have distributed outdated language files on Windows already since a long time. I wonder if this is normal behavior or something uncommon in our use. If it is meant like this, I will update the Windows build process to enforce regenerating the gmo files (probably use a clean build clone). @techee might be the macOS builds affected by this as well? @scootergrisen if you want, you can try the attached `geany.mo` file and copy it to `C:\Program Files\Geany\share\locale\da\LC_MESSAGES` (or whereever you have Geany installed). [geany_gmo_da.zip](https://github.com/geany/geany/files/13057359/geany_gmo_da.zip) -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3620#issuecomment-1773178368 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] symbols panels dont update list after switching files (Issue #3622)
One more guess: did you pass `/tmp/geanytest` with `--prefix` to `./configure`? If not, Geany would load the `geany.glade` file from your old installation and this would explain at least the missing filter entry @techee mentioned. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3622#issuecomment-1773142595 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Emoji flag section is empty (Issue #3619)
On my old Windows 7 VM there are items in the flags section though it looks like there are only country codes without a proper emoji icon:  Note that all emojis are black/white, no colors on Windows. This is probably a GTK/Cairo thing. Searching the net didn't reveal much except: - https://gitlab.gnome.org/GNOME/gtk/-/issues/2303#note_925350 says colored emojis are not supported by Cairo on Windows (though it is three years old) - https://gitlab.freedesktop.org/cairo/cairo/-/merge_requests/244 sounds like Cairo got support for color fonts. Maybe an additional font need to be installed. I don't intend to spend more time on this, it doesn't seem like a big issue to me and it's mainly GTK/Windows related. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3619#issuecomment-1773136755 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Adwaita icon theme makes Geany look ugly (on Debian Bookworm?) (Issue #3613)
> Or we mention it somewhere in the announcement email? @eht16 Done. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3613#issuecomment-1771510213 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Replace never released version 1.39 by 2.0 (13bc05d)
We use to name tags with the full version, including the patch level. The rest mostly uses the short version and for API requirements it is fully sufficient to check for major.minor as patch level versions never should increase the API version. What "additional assets" do you refer to? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/commit/13bc05d80f456d8ed745e4fbfbf4286a49d1acaf#commitcomment-130441874 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Please release a new version (Discussion #3499)
Closed #3499 as resolved. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/discussions/3499 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Please release a new version (Discussion #3499)
Here we go, Geany 2.0 waits for you to be installed or upgraded: https://www.geany.org/news/geany-20-is-out/ It's bad it took so long but hopefully it will be the best release ever and next one will be faster :). -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/discussions/3499#discussioncomment-7330886 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Set release date (d50d5b3)
Yep, unfortunately noticed only after pushing it :(. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/commit/d50d5b31977db01fe6e63af7e6dedf0601402594#commitcomment-130432808 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Release 2.0 documentation (PR #1285)
Merged #1285 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1285#event-10714236447 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Replace never released version 1.39 by 2.0 (PR #3617)
Merged #3617 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3617#event-10714080935 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] [geany/geany] Replace never released version 1.39 by 2.0 (PR #3617)
You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/3617 -- Commit Summary -- * Replace never released version 1.39 by 2.0 -- File Changes -- M po/fr.po (2) M src/keybindings.h (2) -- Patch Links -- https://github.com/geany/geany/pull/3617.patch https://github.com/geany/geany/pull/3617.diff -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3617 You are receiving this because you are subscribed to this thread. Message ID: geany/geany/pull/3...@github.com
[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)
Merged #3593 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3593#event-10713731869 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)
@eht16 commented on this pull request. On doc/images/edit_change_history.png: Thanks and sorry. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3593#discussion_r1365723022 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)
@eht16 commented on this pull request. > +* Update Python filetype config (PR#3039). +* Add AutoIt filetype (Skif-off, PR#1752). +* Add GDScript filetype (David Yang, PR#3012). +* Remove Ferite filetype (PR#3075). +* Enable local variables and improve autocompletion for C/C++ and + some other languages (PR#3185, PR#3275). + +Windows +* Remove native file and color dialogs on Windows, GTK dialogs will + be used instead (#3219). +* Use "Prof-Gnome" GTK theme by default (same theme as used on macOS) + for a better experience, the "Adwaita" theme can still be activated + (PR#3129). + +Internationalization +* Updated translations: Done and rebased on master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3593#discussion_r1364579284 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)
@eht16 pushed 6 commits. 641a09159a047d5df5adaf4b7675aa242e72a101 Add NEWS for Geany 2.0 dbf3c8e0141da0e14a619787c2d14a2aa47130c7 Add documentation for new Scintilla feature "Change history" 35a208aa24e78887109fa3d1993548492abc516d Update documentation screenshots c1be9eca9f12c38d12762c6472ad0e50c6db690f Add #3611 to NEWS 22cdf9cd61fa70b8d0c21d87024bd8cf04ada5da Document Change History is disabled by default d2186cccddf8a885eae0ccb7c894564f1ac669a0 Remove duplicate Internationalization item -- View it on GitHub: https://github.com/geany/geany/pull/3593/files/85febd1e301506e8a22cedcc4eb177dd919719c5..d2186cccddf8a885eae0ccb7c894564f1ac669a0 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)
@eht16 commented on this pull request. > +* Update Python filetype config (PR#3039). +* Add AutoIt filetype (Skif-off, PR#1752). +* Add GDScript filetype (David Yang, PR#3012). +* Remove Ferite filetype (PR#3075). +* Enable local variables and improve autocompletion for C/C++ and + some other languages (PR#3185, PR#3275). + +Windows +* Remove native file and color dialogs on Windows, GTK dialogs will + be used instead (#3219). +* Use "Prof-Gnome" GTK theme by default (same theme as used on macOS) + for a better experience, the "Adwaita" theme can still be activated + (PR#3129). + +Internationalization +* Updated translations: This was a stub to be filled later. @frlan pushed the updated list already in master in the meantime. I'd expect that GIT will detect a merge conflict here but it seems it does not. I will remove the two lines, so after a merge it should fit. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3593#discussion_r1364576852 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)
@eht16 commented on this pull request. > +.. image:: ./images/edit_change_history.png + +The image shows the default visuals: + +* inserted characters appear with coloured underlines +* points where characters were deleted are shown with small triangles +* the margin shows a block indicating the overall state of the line, prioritizing the more consequential modified states +* the states are modified (orange), saved (green), saved then reverted to modified (green-yellow), and + saved then reverted to original (cyan). + +Show in markers margin +Changes are shown in the markers margin as vertical bars + +Show as underline indicators +Changes are shown as underlines in the text directly + Ok. Is 85febd1 fine? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3593#discussion_r1364565237 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)
@eht16 pushed 1 commit. 85febd1e301506e8a22cedcc4eb177dd919719c5 Document Change History is disabled by default -- View it on GitHub: https://github.com/geany/geany/pull/3593/files/e35069844226d60456eb397e6095116b099eb74a..85febd1e301506e8a22cedcc4eb177dd919719c5 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)
@elextr @kugel- @b4n could you have a look on the yet open discussions and either resolve or comment on them? We are slightly running out of time. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3593#issuecomment-1769341258 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)
> @eht16 looks like there has been a rebase mishap, and you grabbed some > unrelated things in there Oops, thanks for notifying. Should be fixed. I started a first round of squashing the incremental changes and then came #3611 :). > You can add #3611 now ;) Done. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3593#issuecomment-1769337606 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)
@eht16 commented on this pull request. On doc/images/main_window.png: No, it just that the user reading the documentation would need a resolution big enough to match the screenshot dimensions or the user needs to scroll. But probably no big deal nowadays. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3593#discussion_r1364548749 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)
@eht16 pushed 4 commits. b73b29b90cc1e1526ea77096d59953610777d2d6 Add NEWS for Geany 2.0 6a61051feccacb0698308d256d29f787bff4705c Add documentation for new Scintilla feature "Change history" f90c81347d9542c85bc6aeddbabc6becc7b4311c Update documentation screenshots e35069844226d60456eb397e6095116b099eb74a Add #3611 to NEWS -- View it on GitHub: https://github.com/geany/geany/pull/3593/files/09e82b5781bc1a5cdf2b26cad4c88c2d791900b7..e35069844226d60456eb397e6095116b099eb74a You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Fix startup files order when placing tabs next to the current one (PR #3611)
What bad things should happen? @b4n committed (this is without any irony!). -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3611#issuecomment-1769324008 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] font hintstyle/antialias in editor differ from settings font (Issue #3610)
I didn't understand the issue completely yet but anyway maybe it's worth to try SciTE (https://archlinux.org/packages/extra/x86_64/scite/) to check whether it has the same problem. If so, it is very likely related to Scintilla. If not, it may or may not be related to Scintilla. @poluyan when you are bisecting, maybe check with a commit *before* 19336d22946b77bbcb5131544ea0e6317cdcf6b5, this was the latest Scintilla update. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3610#issuecomment-1769315199 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Release 2.0 documentation (PR #1285)
@eht16 commented on this pull request. > +Addons: +* Bookmarks: Prevent duplicating bookmarks when editing line (PR #1040) +* Delay updating of tasks list until document has been colorised + (Issue #1254, PR #1257) + +GeanyLua: +* Update documentation for "geany.keygrab" and fix infinite loop + (xiota, PR #1236) +* Update for Scintilla 5.1.4 (xiota, PR #1123) +* Update glspi_keycmd.h: add GEANY_KEYS_FILE_RELOAD_ALL, remove + GEANY_KEYS_COUNT (Skif-off, PR #1124) +* Add geany.settype() to set the document filetype (Skif-off, PR #1157) + +GeanyVC: +* Support the use of external diff-tool in directory context + (nomadbyte, PR #1025) Fixed, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1285#discussion_r1364518027 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Release 2.0 documentation (PR #1285)
@eht16 pushed 1 commit. 0167607f2f7124dd285cf088ad0f6e0182b2c4b2 fixup! Add NEWS for Geany-Plugins 2.0 -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1285/files/436e514c1139b6738f617b8441f990c39ed7aa12..0167607f2f7124dd285cf088ad0f6e0182b2c4b2 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Fix startup files order when placing tabs next to the current one (PR #3611)
@eht16 commented on this pull request. > /* necessary to set it to TRUE for project session support */ main_status.opening_session_files++; - i = file_prefs.tab_order_ltr ? 0 : (session_files->len - 1); - while (TRUE) + file_prefs.tab_order_beside = FALSE; + file_prefs.tab_order_ltr = TRUE; I had only a quick look on the code but tested it again and it works fine. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3611#discussion_r1364515468 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Fix startup files order when placing tabs next to the current one (PR #3611)
@eht16 approved this pull request. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3611#pullrequestreview-1686111258 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Adwaita icon theme makes Geany look ugly (on Debian Bookworm?) (Issue #3613)
Great, that you have it reported on Debian. And good to know that newer versions of the theme do not expose this bug. Debian users could probably even install the Sid package (judged from the direct dependencies which should be possible). Back to Geany: I fully agree with what @techee said. It's not unnecessary work as we have to do anyway in the future (if we don't find a way to burn GTK4 before...) and it prevents users from having a bad first impression of Geany and/or the update to the new version. Might there be any risk that other themes may not work well with the changed icon references? I guess this is hard to answer; the icon loading mechanism are big mystique to me and so I'm just wondering how much we could break with this change. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3613#issuecomment-1769281564 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Release 2.0 documentation (PR #1285)
@eht16 pushed 2 commits. 1e9296bee0715464482b0784e0e68cd2f8fc768f Updated translations 436e514c1139b6738f617b8441f990c39ed7aa12 Merge pull request #1 from frlan/release_2_0_documentation -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1285/files/addfc9ae82601bc2922339e468cd6e48039263b5..436e514c1139b6738f617b8441f990c39ed7aa12 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Change default tab_label_length from 99999 to 1000 (PR #3612)
> An aside: @eht16 congrats the Windows CI is working again. Interesting to see > the relative speeds, meson/ninja vs Autotools/gmake vs Autotools in a > container. Comparing Meson vs Autotools was already possible before. The Windows CI builds should be excluded from such comparisons because the cross compiling toolchain is somewhat slower than compiling natively on Windows with mingw64 and this is much slower than compiling natively on Linux. Factors like the build system or the Docker container overhead are less significant than the used compiler with regard to mingw64. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3612#issuecomment-1769250141 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)
You guys like to have me updating screenshots I guess... The screenshot for the prefs dialog with the changed default for the tab label length is updated for 1000 chars, pixels, apples, Euros :smile:. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3593#issuecomment-1769241290 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)
@eht16 pushed 1 commit. 8ac78832fb7e758784ed65dc50eb7ad766ba9eaf Update doc/geany.txt -- View it on GitHub: https://github.com/geany/geany/pull/3593/files/143f8e399684624dbf3b5f0147209ce9f1bd628d..8ac78832fb7e758784ed65dc50eb7ad766ba9eaf You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Fix startup files order when placing tabs next to the current one (PR #3611)
> It's not even clear to me if this is even a bug (as in "not working as > intended"). I surely never used that pref. I hardly can imagine this could be intended behaviour. After start, the previous code opened the tabs in some random (maybe not really random but in some for the user undeterministic order) and after a second start the previous order was restored, on the third start the pseudo random order of the first start is used and so on. At least me would be very confused by this. I don't mind much if this is a new issue or already present in 1.38, since we have a fix already and it is rather trivial, I'm still for merging. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3611#issuecomment-1769229804 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Fix startup files order when placing tabs next to the current one (PR #3611)
> although any sane person would have enabled the problematic option @b4n Hah, it seems you have proven me as crazy again, my config says `tab_order_beside=false` :) -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3611#issuecomment-1769221517 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Fix startup files order when placing tabs next to the current one (PR #3611)
@eht16 approved this pull request. Tested and works cleanly. I'm all in for merge. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3611#pullrequestreview-1685997547 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)
@eht16 pushed 1 commit. 143f8e399684624dbf3b5f0147209ce9f1bd628d Update screenshots -- View it on GitHub: https://github.com/geany/geany/pull/3593/files/50f76291b2e9b3ff55fe655109d532ed221f46a1..143f8e399684624dbf3b5f0147209ce9f1bd628d You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)
@eht16 commented on this pull request. > +.. image:: ./images/edit_change_history.png + +The image shows the default visuals: + +* inserted characters appear with coloured underlines +* points where characters were deleted are shown with small triangles +* the margin shows a block indicating the overall state of the line, prioritizing the more consequential modified states +* the states are modified (orange), saved (green), saved then reverted to modified (green-yellow), and + saved then reverted to original (cyan). + +Show in markers margin +Changes are shown in the markers margin as vertical bars + +Show as underline indicators +Changes are shown as underlines in the text directly + Saying that "is still being evaluated" could lead to issues asking how the status of the evaluation is. IMO this creates expectations that there is someone actively working on this. This might happen but looking back the last two years, it is not that unlikely that it won't happen. Declaring it as "it is there, disabled and being evaluated" might cause more confusion than it tries to solve. I think it is better to leave it as is. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3593#discussion_r1363467685 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)
@eht16 commented on this pull request. On doc/images/main_window.png: Ok, so it's just getting bigger again. I pushed a variant with similar dimensions as @b4n's demo. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3593#discussion_r1363460371 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)
> Perhaps after the first screenshot add "Screenshots in the document are the > default GTK Adwaita theme, but Geany will adapt to the desktop GTK theme that > is set." Done. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3593#issuecomment-1767937367 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)
@eht16 pushed 2 commits. 86754ddaf839503681e6f3939424883ed3e1d97d Update main window screenshot 50f76291b2e9b3ff55fe655109d532ed221f46a1 Add note about screenshots GTK theme -- View it on GitHub: https://github.com/geany/geany/pull/3593/files/a6a36c276cea1d193081987310eec657986c9606..50f76291b2e9b3ff55fe655109d532ed221f46a1 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)
@eht16 commented on this pull request. > +* Add a confirmation dialog on search & replace for the whole session + (PR#3033). +* Filter entry for symbol tree (PR#3055). +* Simplify project creation from existing directories with sources + (PR#3042). +* Add option to show symbols in symbol tree without category groups + (PR#3172). +* Add option to only show line endings if they differ from file default + (PR#3287). +* Make tab label length and window title length configurable + (Abdul Rafey, #3365). +* Make Go to Symbol commands show signature list (PR#3475). + +Editor +* Update Scintilla to 5.3.7 and Lexilla to 5.2.7 (PR#2867, PR#3551). +* Add "Change history" feature (PR#3551). Done. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3593#discussion_r1362825723 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)
@eht16 pushed 1 commit. a6a36c276cea1d193081987310eec657986c9606 Update NEWS -- View it on GitHub: https://github.com/geany/geany/pull/3593/files/f87a878c9c77404f46fbe3af348c04cb8b9543f6..a6a36c276cea1d193081987310eec657986c9606 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)
@eht16 commented on this pull request. > +* Add a confirmation dialog on search & replace for the whole session + (PR#3033). +* Filter entry for symbol tree (PR#3055). +* Simplify project creation from existing directories with sources + (PR#3042). +* Add option to show symbols in symbol tree without category groups + (PR#3172). +* Add option to only show line endings if they differ from file default + (PR#3287). +* Make tab label length and window title length configurable + (Abdul Rafey, #3365). +* Make Go to Symbol commands show signature list (PR#3475). + +Editor +* Update Scintilla to 5.3.7 and Lexilla to 5.2.7 (PR#2867, PR#3551). +* Add "Change history" feature (PR#3551). Oops, my tired brain read "with explaining why". Sorry. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3593#discussion_r1362755340 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)
@eht16 commented on this pull request. On doc/images/main_window.png: So far I tried to keep the width and height of the old screenshot. But I don't mind much. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3593#discussion_r1362754296 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)
@eht16 commented on this pull request. > +* Add a confirmation dialog on search & replace for the whole session + (PR#3033). +* Filter entry for symbol tree (PR#3055). +* Simplify project creation from existing directories with sources + (PR#3042). +* Add option to show symbols in symbol tree without category groups + (PR#3172). +* Add option to only show line endings if they differ from file default + (PR#3287). +* Make tab label length and window title length configurable + (Abdul Rafey, #3365). +* Make Go to Symbol commands show signature list (PR#3475). + +Editor +* Update Scintilla to 5.3.7 and Lexilla to 5.2.7 (PR#2867, PR#3551). +* Add "Change history" feature (PR#3551). `* Add "Change history" feature, disabled by default (PR#3551).` I don't know if it's worth explaining why it is disabled. The explaination will probably be longer than a NEWS item should be. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3593#discussion_r1362746366 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)
@eht16 commented on this pull request. On doc/images/pref_dialog_various.png: This is also theme-dependent, isn't it? I don't remember we changed anything in the dialog? We could discuss if we do not want to use that theme for screenshots but given the time left, I would postpone this discussion to 2.1+. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3593#discussion_r1362742427 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)
@eht16 commented on this pull request. On doc/images/main_window.png: Me too but this is the great Adwaita we all love so much... -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3593#discussion_r1362739094 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-themes] Add new theme Light and Dark (PR #62)
Merged #62 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-themes/pull/62#event-10683074972 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-themes] Add Matcha Theme (PR #55)
Merged #55 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-themes/pull/55#event-10683069370 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-themes] Add Matcha Theme (PR #55)
@eht16 approved this pull request. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-themes/pull/55#pullrequestreview-1683241926 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)
@eht16 commented on this pull request. On doc/images/replace_dialog.png: I'm sorry! Forgot this one but now added. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3593#discussion_r1362664620 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)
@eht16 pushed 1 commit. f87a878c9c77404f46fbe3af348c04cb8b9543f6 Update screenshots -- View it on GitHub: https://github.com/geany/geany/pull/3593/files/c0b429f59fd2dc4436366e146a5016ccedf2f4fa..f87a878c9c77404f46fbe3af348c04cb8b9543f6 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)
@eht16 commented on this pull request. On doc/images/pref_dialog_templ.png: Last chance to get you out of there :). To be honest, I just re-used the values from the 1.38 screenshot. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3593#discussion_r1362655467 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)
@eht16 pushed 1 commit. c0b429f59fd2dc4436366e146a5016ccedf2f4fa Update NEWS -- View it on GitHub: https://github.com/geany/geany/pull/3593/files/1b2d4f04b7a1026148a12eee3e0a39f789f9797c..c0b429f59fd2dc4436366e146a5016ccedf2f4fa You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)
@eht16 commented on this pull request. On doc/images/build_menu_commands_dialog.png: > @eht16 do you want me to take care of the screenshots, or can you do it with > what I mentioned? Decide yourself :). I was too busy with making screenshots to notice your comment. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3593#discussion_r1362653077 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)
@eht16 commented on this pull request. On doc/images/build_menu_commands_dialog.png: Mighty @b4n, that's it. Screenshots are updated again and look a lot better now. The Gnome default screenshot tool adds a think transparent border around the images. I could remove it but actually I think it's nice because it gives the images some margin when embedded in the HTML document. What do you think? And I'm happy to be confirmed not being crazy, at least in this matter :). -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3593#discussion_r1362648113 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)
@eht16 pushed 1 commit. 1b2d4f04b7a1026148a12eee3e0a39f789f9797c Update screenshots - without super bloated Adwaita legacy icons -- View it on GitHub: https://github.com/geany/geany/pull/3593/files/36930bc6bfff50be25831760db3aec9311b519fd..1b2d4f04b7a1026148a12eee3e0a39f789f9797c You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] macOS: use ".so" extension for plugins instead of ".dylib" (PR #3608)
I don't know Meson nor macOS very well but the changes look good. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3608#issuecomment-1766918324 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)
@eht16 pushed 1 commit. 36930bc6bfff50be25831760db3aec9311b519fd Update NEWS -- View it on GitHub: https://github.com/geany/geany/pull/3593/files/b11817519cb0e9d2232958c54ce6c3d37c1ec599..36930bc6bfff50be25831760db3aec9311b519fd You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] [geany/geany-plugins] Release 2.0 documentation (PR #1285)
Add NEWS for 2.0. Remarks for the NEWS items: - I skipped many smaller or non user visible changes or follow-up PRs to not bloat the list too much - if anyone miss his favorite PR or so, shout out You can view, comment on, or merge this pull request online at: https://github.com/geany/geany-plugins/pull/1285 -- Commit Summary -- * Add NEWS for Geany-Plugins 2.0 -- File Changes -- M NEWS (53) -- Patch Links -- https://github.com/geany/geany-plugins/pull/1285.patch https://github.com/geany/geany-plugins/pull/1285.diff -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1285 You are receiving this because you are subscribed to this thread. Message ID: geany/geany-plugins/pull/1...@github.com
[Github-comments] Re: [geany/geany] Enable EOL-filled Markdown headings (PR #3602)
Looks good to me. I'd be ok to merge it for 2.0. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3602#issuecomment-1764281983 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-themes] Add new theme Light and Dark (PR #62)
@inonehp Thanks for the changes, to me it looks good now. If you are fine it with, I would like to merge this so it is ready to use for the upcoming Geany 2.0 release. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-themes/pull/62#issuecomment-1764269360 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-themes] Add new theme Light and Dark (PR #62)
@eht16 approved this pull request. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-themes/pull/62#pullrequestreview-1679743053 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Spellecheck: Update style mappings (PR #1277)
Merged #1277 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1277#event-10663988726 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] commander: Silence expected deprecation warnings (#952)
@b4n do we want to merge this or carry it around for yet another release cycle? :) -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/952#issuecomment-1764258534 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Review string "translator_credits" (#587)
I cannot find the string in the current code, so it was probably removed in the meantime. Do you agree to close this issue? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/587#issuecomment-1764254060 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Link to libiconv explicitly for Windows/mingw64 builds (PR #3600)
Merged #3600 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3600#event-10663775637 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-osx] Add a patch with Windows-specific theme changes (c79e60f)
Great, thanks. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-osx/commit/c79e60f1cc0c25106ab803b2b4c9e61926ce12fa#r130079834 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] New UI on windows is bloated and scaled up (Issue #3063)
Closed #3063 as completed via #3129. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3063#event-10663711768 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Windows: Include "Prof-Gnome" GTK theme from geany-osx (PR #3129)
Merged #3129 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3129#event-10663711533 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Update meson.build also on version bumps (PR #3599)
@eht16 commented on this pull request. > @@ -23,6 +23,7 @@ s/^\(#define VER_FILEVERSION_STR *\)[^ ].*$/\1"'"$VER"'"/ ' -i geany_private.rc sed -e 's/^\(AC_INIT([^,]*, *\[\)[^]]*\(\],\)/\1'"$VER"'\2/' -i configure.ac +sed -e 's/^\( *version: *\)[^,]*\(,\)/\1'"\'$VER\'"'\2/' -i meson.build Thank you both, @dolik-rce and @b4n. I comitted @b4n's version which is probably future safe enough by including the "project" additionally. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3599#discussion_r1360426355 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Update meson.build also on version bumps (PR #3599)
@eht16 pushed 1 commit. ec30b893a7f4a1ef747bbca3ab047bbbca678ff2 Update scripts/version-bump -- View it on GitHub: https://github.com/geany/geany/pull/3599/files/9eeaa691a1d1a68069030226b9d8b0d84cbb9ba7..ec30b893a7f4a1ef747bbca3ab047bbbca678ff2 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Add GPLv3 note and header template (PR #3549)
@eht16 requested changes on this pull request.
On po/ar.po:
Please remove all the translation changes in the *.po files. These are not
necessary in the pull request. The translation files will be updated later as
part of the release process.
> @@ -168,7 +171,7 @@ void templates_replace_common(GString *tmpl, const gchar
> *fname,
NULL);
}
-
+// Maybe a fix to do in this function
It replaces the `{fileheader}` placeholder in other templates when they are
loaded.
As noted below, I think we don't need the "fileheader3" variant at all.
> @@ -501,6 +524,18 @@ gchar *templates_get_template_fileheader(gint
> filetype_idx, const gchar *fname)
return g_string_free(template, FALSE);
}
+// The line `GEANY_API_SYMBOL` is needeed ?
Yes, it would be necessary here as well. This helps the linker to make the
function available for the plugin API.
BUT: I think we don't need the "fileheader3" template at all. It doesn't add
much value as it is the same as "fileheader" but only for GPLv3.
Since the templates are fully user customizable, it is probably enough for
users to modify the existing "fileheader" template or add a new one themselves.
So I suggest to remove the "fileheader3" template altogether.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3549#pullrequestreview-1678765355
You are receiving this because you are subscribed to this thread.
Message ID:
[Github-comments] Re: [geany/geany-plugins] startup always opens the file from /tmp/_dc~~~/ that contains the opened files (Issue #1243)
Closing this after no more feedback. @WhitehawkTailor re-open if it still is a problem. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1243#issuecomment-1763342195 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] startup always opens the file from /tmp/_dc~~~/ that contains the opened files (Issue #1243)
Closed #1243 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1243#event-10657346524 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Help command should check browser tool's return value (Issue #3468)
I think we can close this now since #3178 is merged. @ntrel when use start current GIT master Geany with a fresh config, will it use the correct browser? FTR, the "sensible-browser" default is patched in by Debian (and Ubuntu inherits this change). As pointed out earlier, Geany had the default "firefox" but now it uses GTK to find the system's default browser. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3468#issuecomment-1763341750 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Cannot install webhelper (Issue #1269)
Closed #1269 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1269#event-10657327244 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Cannot install webhelper (Issue #1269)
@TomCarroll09 I'm closing this. Geany and Geany-Plugins 2.0 are going to be released in a few days and then the mentioned update for Webkit will be included in the new release. If you disagree or need further support, just re-open. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1269#issuecomment-1763339113 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Build geany & geany-plugins on windows(using MSYS2), but geany.exe can not find and load any geany-plugins (Issue #3532)
@baoliubin sorry for the late answer. It might help or might not but it's worth a try: Set the environment variable "lt_cv_deplibs_check_method" to "pass_all", e.g. by executing the following command in the same shell where you compile Geany afterwards: ```export lt_cv_deplibs_check_method='pass_all'``` For details see https://github.com/geany/geany/issues/3461. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3532#issuecomment-1763337445 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-themes] Add new theme Light and Dark (PR #62)
@eht16 requested changes on this pull request. Could you please add your themes to the `AUTHORS` file? > @@ -0,0 +1,108 @@ +# Would you mind adding a full file header with license and copyright information? Like this one: https://github.com/geany/geany-themes/blob/master/colorschemes/github.conf > @@ -0,0 +1,108 @@ +# +# GNU General Public License +# +#https://github.com/geany/geany/blob/d9f8cdbad58d09f0c18ca8acccb49209263018f0/data/filedefs/filetypes.common#L2 +# Inspired by Github, Sublime Text, Geany + + + +[theme_info] +name=Dark Abc The other themes with light/dark variants mostly use a naming scheme like "-light" and "-dark". What do you think about following this scheme and rename your themes to "abc-light" and "abc-dark"? (then also please rename the files and screenshots) -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-themes/pull/62#pullrequestreview-1678753116 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Update meson.build also on version bumps (PR #3599)
> What about simply adding a `q` command after the first replacement so only > that one is handled? I don't know how to do, my sed skills are still on a beginner level and I guess this will remain so :). Tried: `sed -e 's/^\( *version: *\)[^,]*\(,\)/\1'"\'$VER\'"'\2/;q' -i meson.build` but then `sed` stops any processing directly after the first line and since we modify the file inline, `meson.build` only has its first line left. Then I tried: `sed -e 's/^\( *version: *\)[^,]*\(,\)/\1'"\'$VER\'"'\2/1' -i meson.build` which should, to my understanding, replace only the first match of the regex and then stop. In my tests, it replaced multiple matches anyway. After all, I think this is a rather small problem and once it occurs, we can handle it. Again, it is only the version-bump script. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3599#issuecomment-1763322023 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Windows: Include "Prof-Gnome" GTK theme from geany-osx (PR #3129)
> I NAK'd the theme but I don't want to block any Adwaita-replacement so please > go for it. Alright. https://www.geany.org/documentation/faq/#how-to-change-the-gtk-theme provides users with instructions on how to change the theme and there are also alternatives linked. I guess this is all an improvement over Adwaita, as you also say. > If this PR is going to get merged, I'd just suggest also applying the > following patch on top of the theme. I added the patch. Will squash the commits before merge and merge tomorrow if nobody objects. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3129#issuecomment-1763316830 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Windows: Include "Prof-Gnome" GTK theme from geany-osx (PR #3129)
@eht16 pushed 1 commit. 704aaa1e622b4d41ecf8a53109b64aaa574a50c2 Add Prof-Gnome Windows specific patch -- View it on GitHub: https://github.com/geany/geany/pull/3129/files/18886248cb10c53e2a140d213e613c93a73aa011..704aaa1e622b4d41ecf8a53109b64aaa574a50c2 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-osx] Add a patch with Windows-specific theme changes (c79e60f)
Sorry for being late, I just thought this might be also good for the dark variant of the theme? Currently it uses the large statusbar.  -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-osx/commit/c79e60f1cc0c25106ab803b2b4c9e61926ce12fa#r130012991 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Update meson.build also on version bumps (PR #3599)
@eht16 commented on this pull request. > @@ -23,6 +23,7 @@ s/^\(#define VER_FILEVERSION_STR *\)[^ ].*$/\1"'"$VER"'"/ ' -i geany_private.rc sed -e 's/^\(AC_INIT([^,]*, *\[\)[^]]*\(\],\)/\1'"$VER"'\2/' -i configure.ac +sed -e 's/^\( *version: *\)[^,]*\(,\)/\1'"\'$VER\'"'\2/' -i meson.build True. I tried two things already but failed: - include the single quotes in the groups in the regex but failed badly on the proper quoting for shell and sed of single quotes within a single quoted string :( - tried to define the Geany version as variable in `meson.build` but Meson has a strict policy that the `project()` must be the very the first instruction in the file. Newer versions of Meson can read the version within the `project()` call from a command which would give more flexibility but we require an older version which does not support this. Anyway, I also think this is OK for now. It is "just" the version-bump script which we use only manually and will notice when the regex fails at some later point and can adjust it when needed. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3599#discussion_r1359807460 You are receiving this because you are subscribed to this thread. Message ID:
