Re: [Github-comments] [geany/geany] Geany crashes if help is clicked in Plugin Manager (not on the first time) (#1781)
Closed #1781 via #1799. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1781#event-1555190251
Re: [Github-comments] [geany/geany] Geany crashes if help is clicked in Plugin Manager (not on the first time) (#1781)
@elextr: Good catch! :clap: The first plugin in my list is Addons. If I give it a help function then in the good case I get the desired help (e.g. auto-mark). But in the bad case it opens the wrong help now (Addons) instead of crashing. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1781#issuecomment-368329739
Re: [Github-comments] [geany/geany] Geany crashes if help is clicked in Plugin Manager (not on the first time) (#1781)
Hmmm...will try to give the first plugin a help. If your assumption is true it should then open the wrong help instead of crashing. But I will be gone now, maybe I got time for it in the evening. Thanks for your help. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1781#issuecomment-368308246
Re: [Github-comments] [geany/geany] Geany crashes if help is clicked in Plugin Manager (not on the first time) (#1781)
So somewhere maybe the PM is reading the active row instead of remembering which plugin its enabling, so its suddenly getting a disconnect between a plugin it thought had help and one that doesn't. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1781#issuecomment-368307298
Re: [Github-comments] [geany/geany] Geany crashes if help is clicked in Plugin Manager (not on the first time) (#1781)
I can confirm that. The click speed in the bad case is that fast that the first row of the table gets selected shortly. In the good case without the crash, the selected row does not change. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1781#issuecomment-368307123
Re: [Github-comments] [geany/geany] Geany crashes if help is clicked in Plugin Manager (not on the first time) (#1781)
I am currently on a different machine and only have Geany core plugins (all of which have no help) so I can't try it again, but one thing I noticed is that if you double click on the checkbox the selected row jumps to the top. Maybe you are double clicking and changing the selected row and confusing the PM. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1781#issuecomment-368306848
Re: [Github-comments] [geany/geany] Geany crashes if help is clicked in Plugin Manager (not on the first time) (#1781)
Never mind. I can confirm it is the click speed between the On-Off which matters: - clicking in a one second speed (like _"21 - click - 22 -click - 23 - click"_) "solves" the problem, no crash - if I click fast then a single "On-Off-On-Help" or "Off-On-Help" sequence is enough to get the crash -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1781#issuecomment-368306808
Re: [Github-comments] [geany/geany] Geany crashes if help is clicked in Plugin Manager (not on the first time) (#1781)
Oh, I read @codebrainz versions, oops :) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1781#issuecomment-368306510
Re: [Github-comments] [geany/geany] Geany crashes if help is clicked in Plugin Manager (not on the first time) (#1781)
> No GTK 3.18.9, GLib 2.48.2 I think you mis-read something. This are exactly the versions I use. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1781#issuecomment-368306329
Re: [Github-comments] [geany/geany] Geany crashes if help is clicked in Plugin Manager (not on the first time) (#1781)
> Are you using the same GTK/glib versions? No GTK 3.18.9, GLib 2.48.2 I think its far more likely to be sensitive to the time between on and off, on is the thing that loads the .so and links symbols, ok, its likely to be faster the second and subsequent times, but still its some work. And if your version of Glib tries to do the module load asynchronously the UI may be active before everything is set up. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1781#issuecomment-368305891
Re: [Github-comments] [geany/geany] Geany crashes if help is clicked in Plugin Manager (not on the first time) (#1781)
I just downloaded the current master version of geany into a new, fresh directory and built that. No difference, sill crashes (just to be sure I did not mess something up in my other folder). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1781#issuecomment-368305828
Re: [Github-comments] [geany/geany] Geany crashes if help is clicked in Plugin Manager (not on the first time) (#1781)
To point one thing out: it does not happen always but in far more than 50% of my attempts. I tried waiting after the multiple On-Off-On-Switching. So I waited 5, 10 and 20seconds before clicking on "Help" but it did not make a difference. Still crashes. So as you say if something is "out of sync" it seems to stay "out of sync", waiting for something to finish does not seem to help (and my machine did not seem to be busy with anything during the waiting time. This is just my impression from "listening" - I did not check any system monitors). Are you using the same GTK/glib versions? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1781#issuecomment-368304572
Re: [Github-comments] [geany/geany] Geany crashes if help is clicked in Plugin Manager (not on the first time) (#1781)
The plugin doesn't matter. I can re-produce it with every plugin that supports the help button/which has got an help button. To be explicit I re-produced it with this plugins: - Auto-Close - Auto-Mark - Code Navigation - Commander - Define formatter - GeanyCtags - Latex - Macros - Project Organizer - Spell Check - Workbench I think it is not plugin related. The Number bookmarks crashed by just enabling/disabling it but that is definitely another plugin specific issue. I will re-test now and see if waiting some seconds after the on-off phase makes a difference. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1781#issuecomment-368304008
Re: [Github-comments] [geany/geany] Geany crashes if help is clicked in Plugin Manager (not on the first time) (#1781)
The line in the [BT](https://github.com/geany/geany/blob/7d2e6182110a24b505c732f221dd79415f174024/src/plugins.c#L1868) indicates that cbs.help is null, and thats set [here](https://github.com/geany/geany/blob/7d2e6182110a24b505c732f221dd79415f174024/src/plugins.c#L539) which as you can see will set NULL in some circumstances, maybe fast activation/deactivation gets it out of sync. Activation may include loading the .so and therefore may be a slow process (relatively speaking) so your fast click might intercept a previous action. Just check that the plugin is actually enabled, even though the help is enabled, maybe its getting out of sync. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1781#issuecomment-368303253
Re: [Github-comments] [geany/geany] Geany crashes if help is clicked in Plugin Manager (not on the first time) (#1781)
Cannot reproduce, @LarsGit223 which plugin? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1781#issuecomment-368302510
Re: [Github-comments] [geany/geany] Geany crashes if help is clicked in Plugin Manager (not on the first time) (#1781)
I did try that with several different plugins. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1781#issuecomment-368242966
Re: [Github-comments] [geany/geany] Geany crashes if help is clicked in Plugin Manager (not on the first time) (#1781)
Cannot re-produce it myself now. I am now on GTK2. Will try some time later again with GTK3. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1781#issuecomment-368242807
Re: [Github-comments] [geany/geany] Geany crashes if help is clicked in Plugin Manager (not on the first time) (#1781)
Did you try enabling/disabling a plugin fast? (On-Off-On-Off-On-Off-On-Help ==> crash) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1781#issuecomment-368242218
Re: [Github-comments] [geany/geany] Geany crashes if help is clicked in Plugin Manager (not on the first time) (#1781)
I cannot reproduce here. Could [post a backtrace](https://www.geany.org/Support/Bugs) to see where it's crashing? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1781#issuecomment-368241573
[Github-comments] [geany/geany] Geany crashes if help is clicked in Plugin Manager (not on the first time) (#1781)
If I click on the help button in the Plugin Manager then it shows me the help for that plugin. This usually works fine. But if I enable and disable a plugin a few times and click on help after that, then geany will crash quite likely. This happens no matter if the plugin is using the old or new plugin API. Also the kind of help shown does not seem to make a difference, e.g.: - the Latex plugin opens a info dialog - other plugins open a webpage In both cases I could re-produce the crash. I tested with a quite actual development version of geany under Ubuntu 16.04, GTK3 build. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1781
