Re: [Github-comments] [geany/geany] Include for pathconf() (#2402)
Two experts agreeing is good enough for me :) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2402#issuecomment-557743619
Re: [Github-comments] [geany/geany] Include for pathconf() (#2402)
Merged #2402 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2402#event-2824961817
Re: [Github-comments] [geany/geany] Include for pathconf() (#2402)
techee approved this pull request. LGTM, too. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2402#pullrequestreview-321813112
Re: [Github-comments] [geany/geany] Include for pathconf() (#2402)
b4n approved this pull request. LGTM. Maybe it could be guarded against `PATH_MAX` not being defined, but it might more noise than anything else, so I'm happy with this version. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2402#pullrequestreview-321104968
[Github-comments] [geany/geany] Include for pathconf() (#2402)
The `get_path_max()` function uses `pathconf()` in case `PATH_MAX` is not defined, and for that `unistd.h` is needed. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/2402 -- Commit Summary -- * Include unistd.h for pathconf() -- File Changes -- M src/tagmanager/tm_source_file.c (1) -- Patch Links -- https://github.com/geany/geany/pull/2402.patch https://github.com/geany/geany/pull/2402.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2402
