Re: [Github-comments] [geany/geany] Set default 'search not found' dialog to 'Find' (#2109)
Closing as changes affect multiple dialogs. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2109#issuecomment-498733352
Re: [Github-comments] [geany/geany] Set default 'search not found' dialog to 'Find' (#2109)
Closed #2109. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2109#event-2388648053
Re: [Github-comments] [geany/geany] Set default 'search not found' dialog to 'Find' (#2109)
> For reference the wrap option was split from a combined option here as a > result of the discussion in the Geany ML thread which basically makes the > decision to keep it off as it was before, since there is no good reason for > either provided, and since there are no statistics on what would be preferred. Statistics can only be obtain there are lots of users - I am unsure whether Geany fits that category. > So you need to provide some better justification than personal preference to > change it, see the ML thread. ok I can see this discussion will go nowhere, so I leave it here. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2109#issuecomment-475956441
Re: [Github-comments] [geany/geany] Set default 'search not found' dialog to 'Find' (#2109)
> It is just I toggled the checkbutton in the UI logic. Should this change > propagate automatically into the search logic? I'm not sure I understand you? If you set "always wrap search" preference and apply/ok the preferences dialog then yeah it should "propagate" to the search logic so searches always wrap. > Should it not be on by default? So why not just open an issue to change that? :grin: For reference the wrap option was split from a combined option [here](https://github.com/geany/geany/commit/4ffbd8f9ada26ed8d288865e910e96dbe5250bfc) as a result of the discussion in the Geany ML [thread](https://lists.geany.org/pipermail/devel/2011-December/006072.html) which basically makes the decision to keep it off as it was before, since there is no good reason for either provided, and since there are no statistics on what would be preferred. So you need to provide some better justification than personal preference to change it, see the ML thread. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2109#issuecomment-475945767
Re: [Github-comments] [geany/geany] Set default 'search not found' dialog to 'Find' (#2109)
> So did you report that? I can't find an issue that fits. I don't think it is a problem. It is just I toggled the checkbutton in the UI logic. Should this change propagate automatically into the search logic? > And it works for me with latest Geany git. If you delete .config/geany does it still work? It does not for me and I am working also with the git version of Geany. > Well, you only have to set it once and its remembered. But why even set it once? What is the point in that? Should it not be on by default? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2109#issuecomment-475941673
Re: [Github-comments] [geany/geany] Set default 'search not found' dialog to 'Find' (#2109)
@crazyBaboon you are aware of `Edit->Preferences->General->Miscellaneous->Always wrap search`? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2109#issuecomment-475916873
Re: [Github-comments] [geany/geany] Set default 'search not found' dialog to 'Find' (#2109)
done! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2109#issuecomment-475862067
Re: [Github-comments] [geany/geany] Set default 'search not found' dialog to 'Find' (#2109)
@crazyBaboon pushed 1 commit. f78a20c06039336f78df2b45a7ee51616e3da6af Delete dialogs.c~ -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/geany/geany/pull/2109/files/771e951c9e775483140b69fd7cc300e2115a2de6..f78a20c06039336f78df2b45a7ee51616e3da6af
Re: [Github-comments] [geany/geany] Set default 'search not found' dialog to 'Find' (#2109)
please remove dialogs.c~ -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2109#issuecomment-475859846
[Github-comments] [geany/geany] Set default 'search not found' dialog to 'Find' (#2109)
this way the user only has to press enter in the 'search not found' dialog to wrap search You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/2109 -- Commit Summary -- * Set default 'search not found' dialog to 'Find' -- File Changes -- M src/dialogs.c (5) A src/dialogs.c~ (1437) -- Patch Links -- https://github.com/geany/geany/pull/2109.patch https://github.com/geany/geany/pull/2109.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2109
