Re: [Github-comments] [geany/geany-plugins] Add file operations to Project Organizer. (#767)
Closed #767. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/767#event-1906912378
Re: [Github-comments] [geany/geany-plugins] Add file operations to Project Organizer. (#767)
> All look very good. Most of those are things I should have considered myself, > sorry for that. Great, good to hear! > Regarding empty directories, yes, this makes the tree a bit more crowded. It > would be possible to haved them hidden and show them only when their parent > is selected, maybe with a dimmed icon, but I thought it may be a little bit > confusing and, more important, it was too complex for the time I had > available. Yeah, I think it's not worth it. I was thinking about some config option to disable showing empty directories (which would kind of kill the "create directory" feature for users who would enable it) but I think I'll wait with this and see if users are complaining about it or just don't care. I've created #783 with the extra patches and will close this pull request. Thanks a lot for contributing the code! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/767#issuecomment-430250332
Re: [Github-comments] [geany/geany-plugins] Add file operations to Project Organizer. (#767)
All look very good. Most of those are things I should have considered myself, sorry for that. Regarding empty directories, yes, this makes the tree a bit more crowded. It would be possible to haved them hidden and show them only when their parent is selected, maybe with a dimmed icon, but I thought it may be a little bit confusing and, more important, it was too complex for the time I had available. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/767#issuecomment-430115135
Re: [Github-comments] [geany/geany-plugins] Add file operations to Project Organizer. (#767)
@dgmz Shame on me - took me ages to look at your patches :-(. In general, I really like the added features and the implementation looks good too. I've just made some extra patches on top of yours with some minor fixes here: https://github.com/techee/geany-plugins/tree/projorg_file_ops Please let me know what you think about them. The only thing I dislike is that empty directories are shown now - but at the same time this is necessary when you want to have the "create directory" functionality and allow users to add files to the empty directories. So it will probably have to stay this way. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/767#issuecomment-429986660
[Github-comments] [geany/geany-plugins] Add file operations to Project Organizer. (#767)
Add file and directory creation, renaming and removal operations to the Project Organizer sidebar. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany-plugins/pull/767 -- Commit Summary -- * Add file operations to Project Organizer. -- File Changes -- M projectorganizer/src/prjorg-project.c (1) M projectorganizer/src/prjorg-project.h (2) M projectorganizer/src/prjorg-sidebar.c (253) M projectorganizer/src/prjorg-utils.c (78) M projectorganizer/src/prjorg-utils.h (7) -- Patch Links -- https://github.com/geany/geany-plugins/pull/767.patch https://github.com/geany/geany-plugins/pull/767.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/767
