[Github-comments] Re: [geany/geany] Link to libiconv explicitly for Windows/mingw64 builds (PR #3600)
Merged #3600 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3600#event-10663775637 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Link to libiconv explicitly for Windows/mingw64 builds (PR #3600)
@b4n approved this pull request. You gotta do what you gotta do I guess -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3600#pullrequestreview-1678012613 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Link to libiconv explicitly for Windows/mingw64 builds (PR #3600)
@elextr just for you, the classic last minute Windows fix. This was removed as part of https://github.com/geany/geany/pull/3465 a few months ago. I was very sure I tested this properly but it turned out that the explicit link to `libiconv` is necessary for building on Windows. However it is not necessary for the cross compilation toolchain in the CI but also don't hurt. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3600#issuecomment-1762742277 You are receiving this because you are subscribed to this thread. Message ID:
