[Github-comments] Re: [geany/geany] Prefix generated scope field by the "scope:" prefix (PR #3592)
Closed #3592. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3592#event-13255548575 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Prefix generated scope field by the "scope:" prefix (PR #3592)
> How "slow" is it in reality? After all tags are only read once, even seconds > is likely to be acceptable. I just tested it and it's actually about the same both with and without `scope:`. Roughly 1 million tags per second. So while I still think the patch is worth applying, it can wait after 2.0. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3592#issuecomment-1763059572 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Prefix generated scope field by the "scope:" prefix (PR #3592)
Purple editors pencil has been deployed :-) -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3592#issuecomment-1760568000 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Prefix generated scope field by the "scope:" prefix (PR #3592)
@elextr Would you mind having a look at the update of geany.txt I made in https://github.com/geany/geany/pull/3049 if it looks alright to you? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3592#issuecomment-1760450881 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Prefix generated scope field by the "scope:" prefix (PR #3592)
> But if uctags still generates the parent_kind:A::B::C form the problem will > still apply in the case of ctags generated files without sZ so needs to still > be able to read those files. And document the ctags option as recommended > somewhere. The documentation is a good point, I'll write something. > How "slow" is it in reality? After all tags are only read once, even seconds > is likely to be acceptable. I haven't benchmarked that, it probably just "doesn't feel right" than being some real problem. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3592#issuecomment-1760097675 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Prefix generated scope field by the "scope:" prefix (PR #3592)
But if uctags still generates the `parent_kind:A::B::C` form the problem will still apply in the case of ctags generated files without `sZ` so needs to still be able to read those files. And document the ctags option as recommended somewhere. How "slow" is it in reality? After all tags are only read once, even seconds is likely to be acceptable. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3592#issuecomment-1756541922 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Prefix generated scope field by the "scope:" prefix (PR #3592)
Having had a look at #3049 I get the point. But IIUC it must only be merged after #3049 is, otherwise it'll make things rather worse as the current ctags file parser don't understand that field (it could be made to, but I guess it's not the point :)) -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3592#issuecomment-1756409640 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Prefix generated scope field by the "scope:" prefix (PR #3592)
I've added this to the 2.0 milestone, but, strictly speaking, it's not absolutely necessary if it's considered problematic for some reason. The tag files will be parsed alright by https://github.com/geany/geany/pull/3049, parsing will just be slower and unnecessarily inefficient. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3592#issuecomment-1756283993 You are receiving this because you are subscribed to this thread. Message ID:
