[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
Closed #1242. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1242#event-11722045209 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
@liomarhora pushed 0 commits. -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1242/files/8b9bfccaa220ce25eda4854bded15a3ee468fabd..6227d2bebb980b908261f4c9bc470d2de011351c You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
@liomarhora pushed 1 commit. 8b9bfccaa220ce25eda4854bded15a3ee468fabd Merge branch 'geany:master' into devhelpplugin -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1242/files/dff3cfdd0f94f8e7a38b9dc838c43e58b4d432c9..8b9bfccaa220ce25eda4854bded15a3ee468fabd You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
@liomarhora pushed 1 commit. dff3cfdd0f94f8e7a38b9dc838c43e58b4d432c9 Merge branch 'geany:master' into devhelpplugin -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1242/files/22bb8ae75411ee27eb1fd62d812d2e8a4fed7b11..dff3cfdd0f94f8e7a38b9dc838c43e58b4d432c9 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
Hi, While the plugin was not accepted, I'm working on it. I made some changes regarding Zoom. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1242#issuecomment-1678017227 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
@liomarhora pushed 1 commit. 22bb8ae75411ee27eb1fd62d812d2e8a4fed7b11 Update Zoom 10% dhp-object.c -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1242/files/404b05701d2bcb7cee0c19f3eee38e23acd15e56..22bb8ae75411ee27eb1fd62d812d2e8a4fed7b11 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
@liomarhora pushed 1 commit. 404b05701d2bcb7cee0c19f3eee38e23acd15e56 Update translation pt_BR.po -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1242/files/2dc2db26e6eb6f322b92f969365e134b3c08225b..404b05701d2bcb7cee0c19f3eee38e23acd15e56 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
@liomarhora pushed 1 commit. 2dc2db26e6eb6f322b92f969365e134b3c08225b Update Zoom dhp-object.c -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1242/files/2cc085f270cef1c4f5f24de1bce49d9d0cee47b8..2dc2db26e6eb6f322b92f969365e134b3c08225b You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
> > Fiz as modificações. Qual é o próximo passo? > > Seja um pouco mais paciente até que alguém faça uma revisão completa. Eu > gostaria, mas não posso dizer quando encontrarei tempo para fazê-lo. All good. I'm new with programming. I thank you for your patience. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1242#issuecomment-1659159489 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
> I made the modifications. What is the next step? Be a bit more patient until someone does a full review. I would like to but cannot say when I find time to do it. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1242#issuecomment-1659157748 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
@liomarhora commented on this pull request. > @@ -0,0 +1,367 @@ +/* Included directly into dhp-object.c just to keep this whole mess out It was already in this file. It was Matthew who had put. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1242#discussion_r1279875325 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
@eht16 commented on this pull request. > @@ -0,0 +1,10 @@ +include $(top_srcdir)/build/vars.docs.mk + +plugin = devhelp + +dist_plugindata_DATA = \ + devhelp-plugin.svg \ + devhelp-plugin-48.png \ + geany-devhelp-plugin.png \ The file is still not referenced here or am I missing something? `dist_plugindata_DATA` ensures that files listed here will be included in releases and get installed properly. If you do not add the image filename here, it won't be installed. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1242#discussion_r1279872569 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
@liomarhora commented on this pull request. > @@ -0,0 +1,365 @@ +Installation Instructions Done. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1242#discussion_r1279871545 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
@eht16 commented on this pull request. > @@ -0,0 +1,367 @@ +/* Included directly into dhp-object.c just to keep this whole mess out What is this comment about? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1242#pullrequestreview-1555760609 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
@eht16 commented on this pull request. > @@ -0,0 +1,365 @@ +Installation Instructions This file is always not very useful, these are just generic install instructions which mainly don't fit for this plugin. I'd say better remove it than just keeping it around. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1242#pullrequestreview-1555756170 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
@eht16 commented on this pull request. > @@ -0,0 +1,10 @@ +include $(top_srcdir)/build/vars.auxfiles.mk + +if GP_GTK3 Well, I meant that both branches of the switch seem to do the same and so the switch is not necessary at all. Additionally, Geany-Plugins are always using GTK3, we do not support GTK2 anymore. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1242#discussion_r1279863053 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
@eht16 commented on this pull request. > @@ -0,0 +1,1630 @@ +# Doxyfile 1.7.1 Just delete it. This is the configuration for Doxygen, a tool to generate API documentation for code. But it is unlikely to be necessary or useful in this context. If you at some point in the future want to use Doxygen, then it is eay to regenerate the config again from scratch. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1242#discussion_r1279858120 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
I made the modifications. What is the next step? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1242#issuecomment-1658512457 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
> @liomarhorao problema é que você havia confirmado alguns desses arquivos de > construção em sua ramificação, talvez você os tenha adicionado à força. > Como@eht16disse que eles precisam ser removidos de lá, não apenas do > diretório de trabalho, não queremos seus artefatos de construção específicos > no repositório. > > possivelmente `git-ls-files -i --exclude-standard`irá listá-los [conselho não > experimentado] Right. Understood -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1242#issuecomment-1658403821 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
@liomarhora commented on this pull request. > @@ -0,0 +1,1630 @@ +# Doxyfile 1.7.1 I still don't know the purpose of this file in the project. Could you leave it like that? In the future I will find out about his role in the project. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1242#discussion_r1279306416 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
@liomarhora commented on this pull request. > @@ -0,0 +1,6 @@ +#!/bin/sh ok. done! -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1242#discussion_r1279301595 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
@liomarhora commented on this pull request. > @@ -0,0 +1,10 @@ +include $(top_srcdir)/build/vars.docs.mk + +plugin = devhelp + +dist_plugindata_DATA = \ + devhelp-plugin.svg \ + devhelp-plugin-48.png \ + geany-devhelp-plugin.png \ Done. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1242#discussion_r1279301812 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
@liomarhora pushed 1 commit. 7b1fa6f372ef3d4829bf05473f29a947537702e2 unnecessary files deleted -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1242/files/2f9842ffc86913e0e96bf19cd5347d2228788e52..7b1fa6f372ef3d4829bf05473f29a947537702e2 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
@liomarhora pushed 1 commit. 2f9842ffc86913e0e96bf19cd5347d2228788e52 Update dhp.h -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1242/files/67a8dfc185b732d17849b58fd2c8d72066ddac80..2f9842ffc86913e0e96bf19cd5347d2228788e52 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
@liomarhora pushed 1 commit. 67a8dfc185b732d17849b58fd2c8d72066ddac80 Update dhp-settings.c -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1242/files/2fe2423ffe26dbe5b194daaf8a3c0cec52abe6b4..67a8dfc185b732d17849b58fd2c8d72066ddac80 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
@liomarhora pushed 1 commit. 2fe2423ffe26dbe5b194daaf8a3c0cec52abe6b4 Update dhp-plugin.h -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1242/files/4ba460d96bd8e7fb8c67cb8d03284cc55808bd92..2fe2423ffe26dbe5b194daaf8a3c0cec52abe6b4 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
@liomarhora pushed 1 commit. 4ba460d96bd8e7fb8c67cb8d03284cc55808bd92 Update dhp-object.c -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1242/files/6323db42a2c869c891a5e829c08f73564cbf..4ba460d96bd8e7fb8c67cb8d03284cc55808bd92 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
@liomarhora pushed 1 commit. 6323db42a2c869c891a5e829c08f73564cbf Update dhp-manpages.c -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1242/files/ed639b97b9e852b06c5d94ef0265fb2e992b4f87..6323db42a2c869c891a5e829c08f73564cbf You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
@liomarhora pushed 1 commit. ed639b97b9e852b06c5d94ef0265fb2e992b4f87 Update dhp-object.c -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1242/files/10405a28aa2e172c2824fb6d267e0169bc6a10bc..ed639b97b9e852b06c5d94ef0265fb2e992b4f87 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
@liomarhora pushed 1 commit. 10405a28aa2e172c2824fb6d267e0169bc6a10bc Update dhp-manpages.c -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1242/files/0c8bf0686fd1be9caebaa63341618a225ca17258..10405a28aa2e172c2824fb6d267e0169bc6a10bc You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
@liomarhora pushed 1 commit. 0c8bf0686fd1be9caebaa63341618a225ca17258 Update dhp-plugin.c -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1242/files/4b91784668a616bf9f9b09402da5ee69cff7944c..0c8bf0686fd1be9caebaa63341618a225ca17258 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
@liomarhora pushed 1 commit. 4b91784668a616bf9f9b09402da5ee69cff7944c Update AUTHORS -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1242/files/555b502e13cbc3bdf5741e58fbfd932f3b5fbf2a..4b91784668a616bf9f9b09402da5ee69cff7944c You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
@liomarhora pushed 1 commit. 555b502e13cbc3bdf5741e58fbfd932f3b5fbf2a Update AUTHORS -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1242/files/5ff6d7f18b3074514a2c8b165ee0210c13f8167c..555b502e13cbc3bdf5741e58fbfd932f3b5fbf2a You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
@liomarhora the problem was that you had committed some of those build files to your branch, perhaps you force added them. As @eht16 said they need to be removed from there, not just the working directory, we don't want your specific build artefacts in the repository. possibly `git-ls-files -i --exclude-standard` will list them [untried advice] -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1242#issuecomment-1657425001 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
@liomarhora commented on this pull request. > @@ -0,0 +1,10 @@ +include $(top_srcdir)/build/vars.auxfiles.mk + +if GP_GTK3 The plugin used an old devhelp library. That's why this condition exists -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1242#discussion_r1278658874 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
@liomarhora commented on this pull request. > @@ -0,0 +1,240 @@ +#include Yes, done. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1242#discussion_r1278657155 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
@liomarhora commented on this pull request.
> +}
+
+
+/* Load module */
+G_MODULE_EXPORT
+void geany_load_module(GeanyPlugin *plugin)
+{
+ /* Setup translation */
+ main_locale_init(LOCALEDIR, GETTEXT_PACKAGE);
+
+ /* Set metadata */
+ plugin->info->name = _("Devhelp Plugin");
+ plugin->info->description = _("Adds support for looking up
documentation in Devhelp, manual pages, and "
+ "Google Code Search in the integrated viewer.");
+ plugin->info->version = "1.0";
+ plugin->info->author = "Matthew Brush ";
Updated.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1242#discussion_r1278657012
You are receiving this because you are subscribed to this thread.
Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
@liomarhora commented on this pull request. > @@ -0,0 +1 @@ +Matthew Brush I changed it, but Matthew Brush who created the plugin. I just updated to gtk+3 version -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1242#discussion_r1278656814 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
> there were 23 commits, so I ran git reset --soft HEAD~22 and deleted 96 > files. Was that the procedure? This removed the commits only for you locally, they are still here in the repository. Just the delete (`git rm` as @elextr said) the files mentioned in one of my comments above. > hello, I created a repository and did the tests in the CI and managed to fix > the problem. I've updated the current repository and I'm waiting for it to > run on CI. Could you perform this action for me? I just approved the CI pipeline, so further pushes will be checked automatically. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1242#issuecomment-1657235986 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
@eht16 requested changes on this pull request.
I had a quick look and left a few comments.
Though this was no proper review, just a first look.
> @@ -0,0 +1 @@
+Matthew Brush
Maybe add yourself here?
> +}
+
+
+/* Load module */
+G_MODULE_EXPORT
+void geany_load_module(GeanyPlugin *plugin)
+{
+ /* Setup translation */
+ main_locale_init(LOCALEDIR, GETTEXT_PACKAGE);
+
+ /* Set metadata */
+ plugin->info->name = _("Devhelp Plugin");
+ plugin->info->description = _("Adds support for looking up
documentation in Devhelp, manual pages, and "
+ "Google Code Search in the integrated viewer.");
+ plugin->info->version = "1.0";
+ plugin->info->author = "Matthew Brush ";
Maybe add yourself here too?
> @@ -0,0 +1,240 @@
+#include
Could you add the file header with the authors and license in all source files?
> @@ -0,0 +1,10 @@
+include $(top_srcdir)/build/vars.auxfiles.mk
+
+if GP_GTK3
What's the use of this switch? :D
> @@ -0,0 +1,6 @@
+#!/bin/sh
The files:
- autogen.sh
- config.status
- configure
- configure.ac
- configure.scan
- libtool
- the whole m4 folder
are not necessary at all, just delete them.
> @@ -0,0 +1,10 @@
+include $(top_srcdir)/build/vars.docs.mk
+
+plugin = devhelp
+
+dist_plugindata_DATA = \
+ devhelp-plugin.svg \
+ devhelp-plugin-48.png \
+ geany-devhelp-plugin.png \
`geany-devhelp.png` is missing here or it is not used and can be removed?
> @@ -0,0 +1,1630 @@
+# Doxyfile 1.7.1
Is this file used anywhere?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1242#pullrequestreview-1553678395
You are receiving this because you are subscribed to this thread.
Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
there were 23 commits, so I ran git reset --soft HEAD~22 and deleted 96 files. Was that the procedure? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1242#issuecomment-1657129135 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
> manualmente com `git-rm`. Então **não** construa até depois de confirmar a > remoção. Before confirming I used the command git clean -fxd to remove the compiled files. Analyzing the directory I can't find the files that should be excluded. Could you give me examples of which ones I should exclude. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1242#issuecomment-1657126018 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
Manually with `git-rm`. Then do __not__ build until after committing the removal. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1242#issuecomment-1656962806 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
> You need to remove all the product files that have been committed. Anything > that matches the patterns in geany-plugins `.gitignore`. I was kind of lost on how to do this removal. Would you help me? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1242#issuecomment-1656731037 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
You need to remove all the product files that have been committed. Anything that matches the patterns in geany-plugins `.gitignore`. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1242#issuecomment-1652695898 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
what is the next step? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1242#issuecomment-1652692578 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
Hello, Could take action now -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1242#issuecomment-1652100535 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
@liomarhora pushed 1 commit. 873620d0c550e5a0c6b283762c82c477028ddcb9 Update build.yml -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1242/files/89b358b9720dc03bb2f7eb14c0e7425963b310e1..873620d0c550e5a0c6b283762c82c477028ddcb9 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
@liomarhora pushed 1 commit. 89b358b9720dc03bb2f7eb14c0e7425963b310e1 Update configure.ac -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1242/files/cc0ad672ec47dd3b138d807b52a94c00c2ab1e34..89b358b9720dc03bb2f7eb14c0e7425963b310e1 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
@liomarhora pushed 1 commit. cc0ad672ec47dd3b138d807b52a94c00c2ab1e34 Update Makefile.am -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1242/files/86b41001e811b14fdd98197361ee1c813e59f52c..cc0ad672ec47dd3b138d807b52a94c00c2ab1e34 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
there was in the POTFILES.in file the path of the old devhelp library. But I already made the changes. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1242#issuecomment-1651788258 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
@liomarhora pushed 1 commit. 86b41001e811b14fdd98197361ee1c813e59f52c Update POTFILES.in -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1242/files/ec67c88829a9d3721a372a4a5f3cfbbac574d596..86b41001e811b14fdd98197361ee1c813e59f52c You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
> > Is there a way to run the app on the CI of my fork before pulling it on the > > master? > > Possibly, but I don't know how, possibly a github expert can tell what needs > to be enabled. hello, I created a repository and did the tests in the CI and managed to fix the problem. I've updated the current repository and I'm waiting for it to run on CI. Could you perform this action for me? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1242#issuecomment-1651659904 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
Reopened #1242. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1242#event-9923167234 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
> > Is there a way to run the app on the CI of my fork before pulling it on the > > master? > > Possibly, but I don't know how, possibly a github expert can tell what needs > to be enabled. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1242#issuecomment-1651659187 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
Closed #1242. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1242#event-9923165777 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
@liomarhora pushed 1 commit. ec67c88829a9d3721a372a4a5f3cfbbac574d596 Update devhelp.m4 -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1242/files/f57d020d0f5c200408bb8993aa51284a33751440..ec67c88829a9d3721a372a4a5f3cfbbac574d596 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
@liomarhora pushed 1 commit. f57d020d0f5c200408bb8993aa51284a33751440 changing webkit library in README -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1242/files/c063cec40bc706a0531c9dc4c08735a40e9ee29b..f57d020d0f5c200408bb8993aa51284a33751440 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
@liomarhora pushed 2 commits. 6a784e271cf0b6e086da93e4a5ba2f9dbd315b48 changing webkit library in build.yml file and changing maintainer name in devhelp/README file c063cec40bc706a0531c9dc4c08735a40e9ee29b changing webkit library in devhelp.m4 -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1242/files/d8fcca72d6108b0de0b323b077f57a1d93f28402..c063cec40bc706a0531c9dc4c08735a40e9ee29b You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
> > Existe uma maneira de executar o aplicativo no CI do meu garfo antes de > > puxá-lo no mestre? > > Possivelmente, mas não sei como, possivelmente um especialista do github pode > dizer o que precisa ser ativado. I'll search -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1242#issuecomment-1601872831 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
@liomarhora pushed 1 commit. d8fcca72d6108b0de0b323b077f57a1d93f28402 Update build.yml -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1242/files/62ea3450fb8920e2dbee449ba26e067d07cadd01..d8fcca72d6108b0de0b323b077f57a1d93f28402 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
> Is there a way to run the app on the CI of my fork before pulling it on the > master? Possibly, but I don't know how, possibly a github expert can tell what needs to be enabled. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1242#issuecomment-1601871671 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
Is there a way to run the app on the CI of my fork before pulling it on the master? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1242#issuecomment-1601865249 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
> Ahhh, now both Linux and Windows break, the `devhelp.m4` should explicitly > disable on windows since the libwebkit2 is available on the cross compile > host platform and that is what configure tests. I am m4 illiterate, maybe > some expert can advise how. > > @liomarhora Linux fail means you have a dependency on something else which > you happen to have installed on your machine but which isn't on the CI > machine, no idea what. I will check -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1242#issuecomment-1601860501 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
Ahhh, now both Linux and Windows break, the `devhelp.m4` should explicitly disable on windows since the libwebkit2 is available on the cross compile host platform and that is what configure tests. I am m4 illiterate, maybe some expert can advise how. @liomarhora Linux fail means you have a dependency on something else which you happen to have installed on your machine but which isn't on the CI machine, no idea what. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1242#issuecomment-1601840530 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
@liomarhora pushed 1 commit. 62ea3450fb8920e2dbee449ba26e067d07cadd01 Update build.yml -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1242/files/9ec1d13e8faae77c3106522e113f27e841e7073f..62ea3450fb8920e2dbee449ba26e067d07cadd01 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
> ok, since the windows CI properly configures devhelp disabled there is > nothing to do there. > > So @liomarhora [this](.github/workflows/build.yml) just needs to depend on a > current package, possibly libwebkit2gtk-4.0-dev (what is installed here on > old Mint). Then the CI should get to your code, as its working that should go > smoothly :-). updated version of webkitgtk library in CI. Could you run the test? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1242#issuecomment-1601359179 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
@liomarhora pushed 1 commit. 9ec1d13e8faae77c3106522e113f27e841e7073f Update build.yml -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1242/files/48c67e811e693cc75e1d1be2d11225aa0355d59e..9ec1d13e8faae77c3106522e113f27e841e7073f You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
@liomarhora pushed 1 commit. 48c67e811e693cc75e1d1be2d11225aa0355d59e Update build.yml -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1242/files/eecde60ec23db6f28784f253f41ff7ce58040cfc..48c67e811e693cc75e1d1be2d11225aa0355d59e You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
ok, since the windows CI properly configures devhelp disabled there is nothing to do there. So @liomarhora [this](.github/workflows/build.yml) just needs to depend on a current package, possibly libwebkit2gtk-4.0-dev (what is installed here on old Mint). Then the CI should get to your code, as its working that should go smoothly :-). -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1242#issuecomment-1585535947 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
>The Windows build doesn't fail (it uses a docker image with >pre-installed deps), but devhelp does not configure, possibly because >that image doesn't have the requisite dependencies. The Docker image is not really relevant here, it only has some dependencies as some sort of cache. The workflow definition in the project is the authority for installing dependecies. >Maybe because of webkit, @eht16 is there a even a webkit for windows? >Webhelper doesn't configure on windows either. There is no more WebkitGTK for Windows: ***@***.***/thread/4DEVGI2ICZX7F7GE6FLSNNQF3Q6I2OP7/ The link in the post is broken, the correct one should be https://github.com/MSYS2/MINGW-packages/issues/4318. So, the devhelp plugin won't be available on Windows at all. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1242#issuecomment-1585532128 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
> (/me slips into grumpy olde guy mode) How is `build.yaml` `devhelp.m4`? > > For me `build.yaml` comes up as the very first change on the "Files Changed" > tab of the PR on github. sorry, I will try to identify -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1242#issuecomment-1585428520 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
(/me slips into grumpy olde guy mode) How is `build.yaml` `devhelp.m4`? For me `build.yaml` comes up as the very first change on the "Files Changed" tab of the PR on github. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1242#issuecomment-1585427880 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
> > Its not in the code its in the CI setup, build.yml, the CI hasn't even > > gotten to compiling your code yet. > > That by editing your changes to `build.yaml` to ask for the correct version. > > Windows, forget it, to answer my own question to @eht16 above, google can't > find webkitgtk for windows, so it probably doesn't exist. I just edited the settings in the devhelp.m4 file. Was it this file? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1242#issuecomment-1585426207 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
> Its not in the code its in the CI setup, build.yml, the CI hasn't even gotten > to compiling your code yet. That by editing your changes to `build.yaml` to ask for the correct version. Windows, forget it, to answer my own question to @eht16 above, google can't find webkitgtk for windows, so it probably doesn't exist. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1242#issuecomment-1585425255 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
@liomarhora pushed 1 commit. eecde60ec23db6f28784f253f41ff7ce58040cfc modified webkitgtk dependency in devhelp.m4 file -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1242/files/820c1da737abec7b40f6aa3b152bccb74043429f..eecde60ec23db6f28784f253f41ff7ce58040cfc You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
> Nup, you still tell CI to load libwebkitgtk-dev which does not exist any more. > > Its not in the code its in the CI setup, `build.yml`, the CI hasn't even > gotten to compiling your code yet. > > The Windows build doesn't fail (it uses a docker image with pre-installed > deps), but devhelp does not configure, possibly because that image doesn't > have the requisite dependencies. > > Maybe because of webkitgtk, @eht16 is there a even a webkitgtk for windows? > Webhelper doesn't configure on windows either. how do i solve this? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1242#issuecomment-1585422210 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
PS because you are a new contributor Github requires that we manually enable each CI run, so there can be delays before it runs. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1242#issuecomment-1585415702 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
Nup, you still tell CI to load libwebkitgtk-dev which does not exist any more. Its not in the code its in the CI setup, `build.yml`, the CI hasn't even gotten to compiling your code yet. The Windows build doesn't fail (it uses a docker image with pre-installed deps), but devhelp does not configure, possibly because that image doesn't have the requisite dependencies. Maybe because of webkit, @eht16 is there a even a webkit for windows? Webhelper doesn't configure on windows either. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1242#issuecomment-1585415026 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
I can't find where this libwebkitgtk dependency is in the code -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1242#issuecomment-1585379632 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
@liomarhora pushed 1 commit. 820c1da737abec7b40f6aa3b152bccb74043429f replacing gtk_tool_button_new_from_stock with gtk_tool_button_new on zoom buttons and page forward and back buttons -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1242/files/d1ec14450608924d5a420442833833428e528dd6..820c1da737abec7b40f6aa3b152bccb74043429f You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
@liomarhora pushed 1 commit. d1ec14450608924d5a420442833833428e528dd6 Changing the devhelp plugin maintainer in the MAINTAIN file -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1242/files/665abd0652d82ef09905b841458f130878b0df57..d1ec14450608924d5a420442833833428e528dd6 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
> The CI runs on Ubuntu 20.04 > > [Edit: the dependency you ask for is the old version of webkit that is no > longer available, so the CI doesn't even start] I believe I found the place where I requested the old version of webkit. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1242#issuecomment-1583719816 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
@liomarhora pushed 1 commit. 665abd0652d82ef09905b841458f130878b0df57 webkit change to new version -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1242/files/b09be51015e257c52dbeb9e1127fa29b70922a70..665abd0652d82ef09905b841458f130878b0df57 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
@elextr commented on this pull request. > @@ -61,6 +61,13 @@ M: Pavel Roschin W: http://plugins.geany.org/defineformat.html S: Maintained +devhelp +P: Matthew Brush To be clear, the plugin has been removed from Geany-plugins because it was not usable as it was and broke the build. You are effectively submitting a new plugin that is now usable, not Matthew. He and any other authors retain copyright to the code that is reused, you can't change that, but it is licensed under the GPL allowing you to reuse it as you are retaining the GPL. That is the authorisation. What the maintainers file says has no impact on that. Preferably you should use Git to show the changes from a position when the plugin was in the repository so the copyright is traceable. I am not a git expert so I have not considered exactly what that would entail, likely reverting the removal commits, then applying your changes on top of that. The maintainers file is a list of contacts for the person who is willing to provide support (address issues, fix bugs, maybe add features) simply to make it easier for users to find such support. In many cases that is not the author. To avoid "drive by" plugin submissions they normally are not accepted unless the submitter is willing to stand behind their work (at least for a while). -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1242#discussion_r1222461150 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
@liomarhora commented on this pull request. > @@ -61,6 +61,13 @@ M: Pavel Roschin W: http://plugins.geany.org/defineformat.html S: Maintained +devhelp +P: Matthew Brush Can I put my name and email in place of theirs and their authorization? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1242#discussion_r1222422886 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
@elextr commented on this pull request. > @@ -61,6 +61,13 @@ M: Pavel Roschin W: http://plugins.geany.org/defineformat.html S: Maintained +devhelp +P: Matthew Brush Then its rude to put him as maintainer, nominate yourself. If you are not willing to support the plugin you are proposing it will be less likely to be accepted back. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1242#discussion_r1222350992 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
> If you are using the library then remove the devhelp sources from the pull. ok -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1242#issuecomment-1581755900 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
If you are using the library then remove the devhelp sources from the pull. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1242#issuecomment-1581744684 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
The CI runs on Ubuntu 20.04 -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1242#issuecomment-1581741837 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
> Neither Linux nor Windows CI passes, that needs to be fixed. How do I perform these tests before pulling? Why is it working normally on debian and manjaro. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1242#issuecomment-1581696221 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
Reopened #1242. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1242#event-9465552866 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
I accidentally closed the pull. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1242#issuecomment-1581693022 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
> Por que você está construindo o libdevhelp a partir de uma fonte estática em > vez de usar o libdevhelp distribuído pela distro que é compatível com > atualizações de segurança, correções de bugs, etc? > Why are you building libdevhelp from a static source instead of using the > libdevhelp distributed by the distro that is supported with security updates > bugfixes etc? apologies for the delay. I had an unforeseen event and could only respond now. I am building with the library provided by the system (Debian). But where are you checking the static font in the code? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1242#issuecomment-1581691126 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
Closed #1242. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1242#event-9465535326 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
Why are you building libdevhelp from a static source instead of using the libdevhelp distributed by the distro that is supported with security updates bugfixes etc? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1242#issuecomment-1580208255 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
Neither Linux nor Windows CI passes, that needs to be fixed. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1242#issuecomment-1578604204 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
@liomarhora pushed 1 commit. b09be51015e257c52dbeb9e1127fa29b70922a70 editing build file devhelp.m4 -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1242/files/3d055fa1066fe984a600059bd81d0e52a593e6fe..b09be51015e257c52dbeb9e1127fa29b70922a70 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
> What have you done to move the plugin to a supported version of webkit? It > was deleted from geany-plugins because it used a version of webkit that was > not supported by most distributions and nobody wanted to port it to the new > version because IIUC the API changed significantly. I analyzed the functions of the new webkit and migrated. The same was done with libdevhelp. There is little left to port from gtk to version 3, but it is functional -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1242#issuecomment-1576897346 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Porting devhelp plugin for gtk3. Working display in sidebar and main … (PR #1242)
@liomarhora commented on this pull request. > @@ -61,6 +61,13 @@ M: Pavel Roschin W: http://plugins.geany.org/defineformat.html S: Maintained +devhelp +P: Matthew Brush > Have you got Matthew's agreement to be maintainer? I sent him an email, but got no response. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1242#discussion_r1218136668 You are receiving this because you are subscribed to this thread. Message ID:
