[Github-comments] Re: [geany/geany-plugins] Windows installer: Prefer Geany installation directory over user's HOME (PR #1324)

[Enrico Tröger via Github-comments]

Merged #1324 into master.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1324#event-13258211467
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany-plugins] Windows installer: Prefer Geany installation directory over user's HOME (PR #1324)

[Enrico Tröger via Github-comments]

@eht16 commented on this pull request.



> @@ -401,6 +398,12 @@ Function .onInit
StrCpy $INSTDIR "$GEANY_INSTDIR"
${EndIf}
 
+   ; if $INSTDIR has not been set yet above, set it to the profile 
directory for non-admin users
+   ${If} $INSTDIR == ""

The diff is a bit cluttered because of the variable rename (I don't know what 
was wrong with me naming it "Answer" :( ), the relevant part is here: we set 
`$INSTDIR` only to the user's profile directory if we didn't find a Geany 
installation before. Before the Geany installation was ignored if the installer 
was executed without administrative privileges.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1324#pullrequestreview-1999560372
You are receiving this because you are subscribed to this thread.

Message ID: