Re: [Github-comments] [geany/geany] Remove requirement to fail build on aggregate return (#1740)

2018-01-12 Thread Matthew Brush 
Merged #1740.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1740#event-1422855689

Re: [Github-comments] [geany/geany] Remove requirement to fail build on aggregate return (#1740)

2018-01-12 Thread Colomban Wendling 
OK.

@elextr 4 is not a real reason, GP is voluntarily forgiving on non-critical 
things because it's more of an aggregate itself () then a single project.

@codebrainz warnings are mostly useless in CI builds unless the CI can report 
them directly, nobody actually read a successful build's log.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1740#issuecomment-357394540

Re: [Github-comments] [geany/geany] Remove requirement to fail build on aggregate return (#1740)

2018-01-12 Thread Matthew Brush 
:+1:, at most this should be a warning.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1740#issuecomment-357366468