Re: [Github-comments] [geany/geany] Search for selected text when pressing [Ctrl]+[F] (#2693)
Closed #2693 via #2697. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2693#event-4153008436
Re: [Github-comments] [geany/geany] Search for selected text when pressing [Ctrl]+[F] (#2693)
Reopened #2693. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2693#event-4135102103
Re: [Github-comments] [geany/geany] Search for selected text when pressing [Ctrl]+[F] (#2693)
Don't close until the PR is merged, see [github docs](https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword) for how to make it happen automatically when the merge happens. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2693#issuecomment-748869588
Re: [Github-comments] [geany/geany] Search for selected text when pressing [Ctrl]+[F] (#2693)
Closed because of pending Pull Request: #2697 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2693#issuecomment-748866968
Re: [Github-comments] [geany/geany] Search for selected text when pressing [Ctrl]+[F] (#2693)
Closed #2693. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2693#event-4135081562
Re: [Github-comments] [geany/geany] Search for selected text when pressing [Ctrl]+[F] (#2693)
I created a pull request now, see #2695. Is it okay if I do another PL for the manual later? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2693#issuecomment-748676763
Re: [Github-comments] [geany/geany] Search for selected text when pressing [Ctrl]+[F] (#2693)
> Since the feature is already implemented I think it should be a little bit > easier to just add an option such like "Always search for selected text". Well, thats the whole point of the lng discussion on #758, changing the search string every time something is selected limits what editing actions can be used between searches (they have to _NOT_ select anything or you lose the search string), but if its an option on the search dialog it should be ok. Since it already loads the selection on opening the dialog, if CTRL+F (or whatever is configured as the keybinding for search) while the dialog is is already open, loads a new search from selection without closing and re-opening, thats also an acceptable enhancement IMNSHO. Pull requests are welcome (and don't forget to document in the manual). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2693#issuecomment-747949931
Re: [Github-comments] [geany/geany] Search for selected text when pressing [Ctrl]+[F] (#2693)
I noticed that the default behaviour of Geany is to put the selected text into the "Search for:" as long the search dialog is not opened. If you open it using [Ctrl]+[F] or via the menu does not matter. Since the feature is already implemented I think it should be a little bit easier to just add an option such like "Always search for selected text". -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2693#issuecomment-747943255
Re: [Github-comments] [geany/geany] Search for selected text when pressing [Ctrl]+[F] (#2693)
Duplicate of #758 (or at least one of the suggestions, its a big and confusing discussion) but nobody has made a PR. Although its a duplicate perhaps better to leave this open due to the complexity (and age) of #758. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2693#issuecomment-747677107
