Re: [Github-comments] [geany/geany-osx] Dark / light mode Macos (#22)

2021-02-04 Thread pragma-git
Closed #22.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-osx/issues/22#event-4290338967

Re: [Github-comments] [geany/geany-osx] Dark / light mode Macos (#22)

2021-02-04 Thread pragma-git
Yes it works very well (sorry I used the wrong account when answering above).  

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-osx/issues/22#issuecomment-773235811

Re: [Github-comments] [geany/geany-osx] Dark / light mode Macos (#22)

2021-02-04 Thread Jiří Techet
Basically the quote @codebrainz mentioned should describe how theme picking 
works - and at least on my machine theme selection works automatically for 1.37.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-osx/issues/22#issuecomment-773225464

Re: [Github-comments] [geany/geany-osx] Dark / light mode Macos (#22)

2021-02-04 Thread elextr
@pragma-git does it work for you?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-osx/issues/22#issuecomment-773200309

Re: [Github-comments] [geany/geany-osx] Dark / light mode Macos (#22)

2021-02-04 Thread JanAxelssonTest
I can confirm that version 1.37 works as anticipated (problem reported for 
version 1.36, which I thought was latest).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-osx/issues/22#issuecomment-773170321

Re: [Github-comments] [geany/geany-osx] Dark / light mode Macos (#22)

2021-02-03 Thread Matthew Brush
>From [this 
>comment](https://github.com/geany/geany/issues/2344#issuecomment-546718908):

> The main feature of this release is that I made a few things configurable 
> (probably the most interesting one is the dark/light theme) using a config 
> file which is created when you start Geany under 
> ~/.config/geany/geany_mac.conf. The default value for the theme is to use 
> your macOS settings so if you use the dark theme system-wise, it will be 
> picked automatically for you. Note that if you previously set the theme using 
> the .config/gtk-3.0/settings.ini file, you'll have to remove this file first, 
> otherwise it overrides the settings specified in 
> ~/config/geany/geany_mac.conf.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-osx/issues/22#issuecomment-772942391

Re: [Github-comments] [geany/geany-osx] Dark / light mode Macos (#22)

2021-02-03 Thread JanAxelssonTest
1) I do understand that you wish to keep the code the same, but I do disagree 
that having the suggested setting would disrupt cross-platform conformity.  To 
clairfy the setting I talk about: I think having the possibility to force 
light/dark for the single Geany application may be useful for some people (also 
on platforms where you pick up system setting).  Such an option would also 
solve the Macos issue, without disturbing the cross-platform. 

2) Regarding adding the setting in a non-Macos fashion (like from the dock), 
would not follow the standard, but I understand how you think. One such 
possibility could be to add an extra Mac-specific setting-menu where settings 
on Macos are normally situated (under the Geany application name; @techee would 
know). That way, the normal Geany Edit/Settings menu would not need to be 
touched. Just a suggestion!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-osx/issues/22#issuecomment-772509928

Re: [Github-comments] [geany/geany-osx] Dark / light mode Macos (#22)

2021-02-03 Thread elextr
> That is, double-clicking a file which opens with Geany, makes light mode. 
> Also starting Geany from the dock defaults to light mode

I'm totally macos illiterate, but I would have thought these can be modified to 
do the setting of `GTK_THEME`.

The problem with adding it into a menu in Geany will be that its a macos 
special since other systems provide their own methods of setting themes, and we 
don't want conflicts, if its gonna work, it better do it the system way.

A better place to add an option might be in the macos 
[launcher](https://github.com/geany/geany-osx/blob/master/Launcher/geany/geany/main.m),
 then it may work in all situations, thats something a macos expert like 
@techee  will have to comment on.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-osx/issues/22#issuecomment-772454571

Re: [Github-comments] [geany/geany-osx] Dark / light mode Macos (#22)

2021-02-03 Thread JanAxelssonTest
The solution 
https://github.com/geany/geany-osx/issues/22#issuecomment-772130658 works from 
command line
`export GTK_THEME=Mojave-light-solid:dark; open -a geany`

**_BUT_**, it does not work in normal Mac workflow.  That is, double-clicking a 
file which opens with Geany, makes light mode.  Also starting Geany from the 
dock defaults to light mode

There is a `settings.ini` in the Macos bundle. Adding the following allows for 
dark-mode works:
`gtk-application-prefer-dark-theme=true`

I don't think gsettings exist for Macos.

**_For the average user_**, I think the best solution would be to keep Macos 
bundle intact. To reiterate: now two bundle-based alternatives exists 
(`gtk-application-prefer-dark-theme=true`, or changing `gtk-dark.css` file 
names as in original post 
https://github.com/geany/geany-osx/issues/22#issue-799806336). At least 
theoretically, maybe one of these could be jacked into to allow dark-mode 
setting from inside Geany menus?

Willing to test-drive if you don't have a Mac available

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-osx/issues/22#issuecomment-772439345

Re: [Github-comments] [geany/geany-osx] Dark / light mode Macos (#22)

2021-02-02 Thread Matthew Brush
>  As a last resource (not as good) allow and document a "less hacky" way to 
> change to dark mode...

If you set the `GTK_THEME` environment variable you should be able to switch to 
the dark version, for example setting the  environment variable to 
`GTK_THEME=Mojave-light-solid:dark` should work. There are a few other ways 
using `settings.ini` file and `gsettings` as well, but I'm not really sure 
what's available/included in the Macos bundle.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-osx/issues/22#issuecomment-772130658

Re: [Github-comments] [geany/geany-osx] Dark / light mode Macos (#22)

2021-02-02 Thread elextr
Except for the editing window, Geany follows your GTK theme, so on systems 
where GTK theming is set by the system (like my Linux Mint here) it just works 
if your machine is set to a dark theme, so the problem is basically Macos 
specific where GTK doesn't follow the system theme it seems.  Will transfer to 
the Geany-OSX issues.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-osx/issues/22#issuecomment-772080802