Re: [Github-comments] [geany/geany-plugins] workbench: use simple/old file monitor events only (#719)
Merged #719. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/719#event-1514503631
Re: [Github-comments] [geany/geany-plugins] workbench: use simple/old file monitor events only (#719)
@LarsGit223 pushed 1 commit. e171c35 workbench: cleaned up 'workbench.m4' -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/geany/geany-plugins/pull/719/files/87a6400a159daaeed755b1765972f49604c1eeb2..e171c35d14539666f2ec878a57b3634fd877da80
Re: [Github-comments] [geany/geany-plugins] workbench: use simple/old file monitor events only (#719)
LarsGit223 commented on this pull request. > @@ -22,7 +22,7 @@ #include #include "wb_project.h" -#if defined(HAVE_GIO) && GLIB_CHECK_VERSION (2, 46, 0) +#if defined(HAVE_GIO) Done. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/719#discussion_r172964196
Re: [Github-comments] [geany/geany-plugins] workbench: use simple/old file monitor events only (#719)
@LarsGit223 pushed 1 commit. 87a6400 workbench: removed compile-time checks -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/geany/geany-plugins/pull/719/files/9096605eb280528a46b7cc446d550bb75dfb22af..87a6400a159daaeed755b1765972f49604c1eeb2
Re: [Github-comments] [geany/geany-plugins] workbench: use simple/old file monitor events only (#719)
LarsGit223 commented on this pull request. > @@ -22,7 +22,7 @@ #include #include "wb_project.h" -#if defined(HAVE_GIO) && GLIB_CHECK_VERSION (2, 46, 0) +#if defined(HAVE_GIO) Yes, geany itself is not using it, I will remove it. Maybe it should be removed from other plugins also. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/719#discussion_r172420861
Re: [Github-comments] [geany/geany-plugins] workbench: use simple/old file monitor events only (#719)
elextr commented on this pull request. > @@ -22,7 +22,7 @@ #include #include "wb_project.h" -#if defined(HAVE_GIO) && GLIB_CHECK_VERSION (2, 46, 0) +#if defined(HAVE_GIO) Yes, Geany itself stopped checking back in [2011](https://github.com/geany/geany/commit/591417697010200441af6b6ed76ef28ef4731d83) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/719#discussion_r172385982
Re: [Github-comments] [geany/geany-plugins] workbench: use simple/old file monitor events only (#719)
codebrainz commented on this pull request. > @@ -22,7 +22,7 @@ #include #include "wb_project.h" -#if defined(HAVE_GIO) && GLIB_CHECK_VERSION (2, 46, 0) +#if defined(HAVE_GIO) I don't think you need this `HAVE_GIO` stuff from the build system as GIO is part of GLib, Geany requires GIO already, and AFAIK some plugins too. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/719#pullrequestreview-101385501
