Re: [gitorious] OpenID integration tests for Gitorious
Rodrigo, First of all: sorry for sucking at responding to email here :-/ On Wed, Aug 24, 2011 at 1:12 PM, Rodrigo Rosenfeld Rosas rr.ro...@gmail.com wrote: ** Em 24-08-2011 04:52, Marius Mårnes Mathiesen escreveu: First of all, let me see if I get this right: you're proposing to merge the integration test only at this time, and then use that to continue the work on Devise? Awesome! That's exactly what I'm proposing. Love it! How deep do you feel it's necessary to integrate the OpenID communication? I would like to integrate in such a way that completely replacing the OpenID implementation would still cause the test to pass without modifications. Perfect! I'm skipping the other questions, since they may not be relevant now that I (think I) understand what you meant in the first place :-) The easiest way to stitch all this together would probably be to create a separate rake task that: - Starts a ROTS server - Runs the integration tests - Stops the ROTS server This task could either override the default test:integrations task or be a separate one - the least painful solution would probably be a separate task? - Marius -- To post to this group, send email to gitorious@googlegroups.com To unsubscribe from this group, send email to gitorious+unsubscr...@googlegroups.com
Re: [gitorious] OpenID integration tests for Gitorious
On Tue, Aug 30, 2011 at 1:04 PM, Rodrigo Rosenfeld Rosas rr.ro...@gmail.com wrote: ** Would you prefer to have an slow-integration extra directory so that a rake test would skip those tests and we wouldn't run it that often? That way I could write a test-slow rake task for running those tests separately. Another option could be to run the slow tests if a certain environment variable is set, ie LOTS_OF_TIME_TO_SPARE=true rake test:integration Your call. - M -- To post to this group, send email to gitorious@googlegroups.com To unsubscribe from this group, send email to gitorious+unsubscr...@googlegroups.com
Re: [gitorious] OpenID integration tests for Gitorious
Em 30-08-2011 10:02, Marius Mårnes Mathiesen escreveu: On Tue, Aug 30, 2011 at 1:04 PM, Rodrigo Rosenfeld Rosas rr.ro...@gmail.com mailto:rr.ro...@gmail.com wrote: Would you prefer to have an slow-integration extra directory so that a rake test would skip those tests and we wouldn't run it that often? That way I could write a test-slow rake task for running those tests separately. Another option could be to run the slow tests if a certain environment variable is set, ie LOTS_OF_TIME_TO_SPARE=true rake test:integration Your call. Please, take a look again in my 'openid-integration-test' branch. I've added: rake test:slow:start rake test:slow:run (will run start and stop if ROTS is not started) rake test:slow:stop What do you think about this? -- To post to this group, send email to gitorious@googlegroups.com To unsubscribe from this group, send email to gitorious+unsubscr...@googlegroups.com
Re: [gitorious] OpenID integration tests for Gitorious
Hi, I've just added this test to my devise-openid branch and the tests have passed :D Great! So, now, I would like you to review my devise-openid branch for merging it with master. While you review, I'll try to rebase it to current master. Feel free if you would like some commits to be merged or cleaned up. I'm getting really good with git rebase -i :D Best, Rodrigo. Em 30-08-2011 10:02, Marius Mårnes Mathiesen escreveu: On Tue, Aug 30, 2011 at 1:04 PM, Rodrigo Rosenfeld Rosas rr.ro...@gmail.com mailto:rr.ro...@gmail.com wrote: Would you prefer to have an slow-integration extra directory so that a rake test would skip those tests and we wouldn't run it that often? That way I could write a test-slow rake task for running those tests separately. Another option could be to run the slow tests if a certain environment variable is set, ie LOTS_OF_TIME_TO_SPARE=true rake test:integration Your call. - M -- To post to this group, send email to gitorious@googlegroups.com To unsubscribe from this group, send email to gitorious+unsubscr...@googlegroups.com -- To post to this group, send email to gitorious@googlegroups.com To unsubscribe from this group, send email to gitorious+unsubscr...@googlegroups.com
Re: [gitorious] OpenID integration tests for Gitorious
I've just forced push a rebased version of the branch with some minor extra commits. Please, take a look and let me know what you think. Thanks, Rodrigo. Em 30-08-2011 16:39, Rodrigo Rosenfeld Rosas escreveu: Hi, I've just added this test to my devise-openid branch and the tests have passed :D Great! So, now, I would like you to review my devise-openid branch for merging it with master. While you review, I'll try to rebase it to current master. Feel free if you would like some commits to be merged or cleaned up. I'm getting really good with git rebase -i :D Best, Rodrigo. Em 30-08-2011 10:02, Marius Mårnes Mathiesen escreveu: On Tue, Aug 30, 2011 at 1:04 PM, Rodrigo Rosenfeld Rosas rr.ro...@gmail.com mailto:rr.ro...@gmail.com wrote: Would you prefer to have an slow-integration extra directory so that a rake test would skip those tests and we wouldn't run it that often? That way I could write a test-slow rake task for running those tests separately. Another option could be to run the slow tests if a certain environment variable is set, ie LOTS_OF_TIME_TO_SPARE=true rake test:integration Your call. - M -- To post to this group, send email to gitorious@googlegroups.com To unsubscribe from this group, send email to gitorious+unsubscr...@googlegroups.com -- To post to this group, send email to gitorious@googlegroups.com To unsubscribe from this group, send email to gitorious+unsubscr...@googlegroups.com
[gitorious] Annotations branch
Hi folks, Sorry if I've missed a thread on this, but what state is the annotations branch in? I see lot of activity in there and am wondering if its relatively safe to try out (ie doesn't break any of the existing functionality), and what features are planned for it. Cheers, Darren -- To post to this group, send email to gitorious@googlegroups.com To unsubscribe from this group, send email to gitorious+unsubscr...@googlegroups.com
