Re: [GHC] #3803: addCoverageTicksTobind should not panic when file location is Nothing
#3803: addCoverageTicksTobind should not panic when file location is Nothing ---+ Reporter: clemens | Owner: igloo Type: merge | Status: closed Priority: high | Milestone: 6.12.2 Component: Compiler |Version: 6.12.1 Resolution: fixed | Keywords: hpc Difficulty:| Os: Unknown/Multiple Testcase:| Architecture: Unknown/Multiple Failure: None/Unknown | ---+ Changes (by igloo): * status: new = closed * resolution: = fixed Comment: Merged -- Ticket URL: http://hackage.haskell.org/trac/ghc/ticket/3803#comment:5 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler ___ Glasgow-haskell-bugs mailing list Glasgow-haskell-bugs@haskell.org http://www.haskell.org/mailman/listinfo/glasgow-haskell-bugs
Re: [GHC] #3803: addCoverageTicksTobind should not panic when file location is Nothing
#3803: addCoverageTicksTobind should not panic when file location is Nothing -+-- Reporter: clemens |Owner: Type: bug | Status: new Priority: high |Milestone: 6.12.2 Component: Compiler | Version: 6.12.1 Keywords: hpc | Difficulty: Os: Unknown/Multiple | Testcase: Architecture: Unknown/Multiple | Failure: None/Unknown -+-- Changes (by simonmar): * priority: normal = high Comment: easy to fix, so bump prio. -- Ticket URL: http://hackage.haskell.org/trac/ghc/ticket/3803#comment:2 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler ___ Glasgow-haskell-bugs mailing list Glasgow-haskell-bugs@haskell.org http://www.haskell.org/mailman/listinfo/glasgow-haskell-bugs
Re: [GHC] #3803: addCoverageTicksTobind should not panic when file location is Nothing
#3803: addCoverageTicksTobind should not panic when file location is Nothing -+-- Reporter: clemens |Owner: Type: bug | Status: new Priority: normal|Milestone: 6.12.2 Component: Compiler | Version: 6.12.1 Keywords: hpc | Difficulty: Os: Unknown/Multiple | Testcase: Architecture: Unknown/Multiple | Failure: None/Unknown -+-- Changes (by igloo): * milestone: = 6.12.2 -- Ticket URL: http://hackage.haskell.org/trac/ghc/ticket/3803#comment:1 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler ___ Glasgow-haskell-bugs mailing list Glasgow-haskell-bugs@haskell.org http://www.haskell.org/mailman/listinfo/glasgow-haskell-bugs
[GHC] #3803: addCoverageTicksTobind should not panic when file location is Nothing
#3803: addCoverageTicksTobind should not panic when file location is Nothing -+-- Reporter: clemens | Owner: Type: bug | Status: new Priority: normal| Component: Compiler Version: 6.12.1|Keywords: hpc Os: Unknown/Multiple |Testcase: Architecture: Unknown/Multiple | Failure: None/Unknown -+-- compiler/deSugar/Coverage.lhs: {{{ addCoverageTicksToBinds dflags mod mod_loc tyCons binds = do let orig_file = case ml_hs_file mod_loc of Just file - file Nothing - panic can not find the original file during hpc trans }}} Is there any reason for this function to panic? It is the only function (at least in my use-case) of the GHC API that panics on ms_hs_file = Nothing. I suggest to handle this more graceful and return emptyHpcInfo and emptyModBreaks just as in the case of file ending in .boot -- Ticket URL: http://hackage.haskell.org/trac/ghc/ticket/3803 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler___ Glasgow-haskell-bugs mailing list Glasgow-haskell-bugs@haskell.org http://www.haskell.org/mailman/listinfo/glasgow-haskell-bugs