Re: [GHC] #5944: Bad hpc hash function

2012-03-26 Thread GHC 
#5944: Bad hpc hash function
---+
  Reporter:  Lennart   |  Owner:  simonmar
  Type:  bug   | Status:  closed  
  Priority:  high  |  Milestone:  7.4.2   
 Component:  Code Coverage |Version:  7.2.2   
Resolution:  fixed |   Keywords:  
Os:  Unknown/Multiple  |   Architecture:  Unknown/Multiple
   Failure:  None/Unknown  | Difficulty:  Unknown 
  Testcase:|  Blockedby:  
  Blocking:|Related:  
---+
Changes (by pcapriotti):

  * status:  merge = closed
  * resolution:  = fixed


Comment:

 Merged as ffd12b9a17dfdffef8ca4dd215e5c081d9b082fa.

-- 
Ticket URL: http://hackage.haskell.org/trac/ghc/ticket/5944#comment:3
GHC http://www.haskell.org/ghc/
The Glasgow Haskell Compiler

___
Glasgow-haskell-bugs mailing list
Glasgow-haskell-bugs@haskell.org
http://www.haskell.org/mailman/listinfo/glasgow-haskell-bugs

Re: [GHC] #5944: Bad hpc hash function

2012-03-23 Thread GHC 
#5944: Bad hpc hash function
-+--
Reporter:  Lennart   |   Owner:  simonmar
Type:  bug   |  Status:  merge   
Priority:  high  |   Milestone:  7.4.2   
   Component:  Code Coverage | Version:  7.2.2   
Keywords:|  Os:  Unknown/Multiple
Architecture:  Unknown/Multiple  | Failure:  None/Unknown
  Difficulty:  Unknown   |Testcase:  
   Blockedby:|Blocking:  
 Related:|  
-+--
Changes (by simonmar):

  * status:  new = merge


Comment:

 {{{
 commit 4d661848575009bbcf3fe8e1f7c69da12f1d3a8e
 Author: Simon Marlow marlo...@gmail.com
 Date:   Tue Mar 20 12:12:06 2012 +

 fix bug in instance HpcHash (a,b) (GHC ticket #5944)
 }}}

-- 
Ticket URL: http://hackage.haskell.org/trac/ghc/ticket/5944#comment:2
GHC http://www.haskell.org/ghc/
The Glasgow Haskell Compiler

___
Glasgow-haskell-bugs mailing list
Glasgow-haskell-bugs@haskell.org
http://www.haskell.org/mailman/listinfo/glasgow-haskell-bugs

Re: [GHC] #5944: Bad hpc hash function

2012-03-20 Thread GHC 
#5944: Bad hpc hash function
-+--
Reporter:  Lennart   |   Owner:  simonmar
Type:  bug   |  Status:  new 
Priority:  high  |   Milestone:  7.4.2   
   Component:  Code Coverage | Version:  7.2.2   
Keywords:|  Os:  Unknown/Multiple
Architecture:  Unknown/Multiple  | Failure:  None/Unknown
  Difficulty:  Unknown   |Testcase:  
   Blockedby:|Blocking:  
 Related:|  
-+--
Changes (by simonmar):

  * owner:  andy@… = simonmar
  * difficulty:  = Unknown
  * priority:  normal = high
  * milestone:  = 7.4.2


Comment:

 Ok, I'll push the fix.  Thanks.

-- 
Ticket URL: http://hackage.haskell.org/trac/ghc/ticket/5944#comment:1
GHC http://www.haskell.org/ghc/
The Glasgow Haskell Compiler

___
Glasgow-haskell-bugs mailing list
Glasgow-haskell-bugs@haskell.org
http://www.haskell.org/mailman/listinfo/glasgow-haskell-bugs

[GHC] #5944: Bad hpc hash function

2012-03-16 Thread GHC 
#5944: Bad hpc hash function
--+-
 Reporter:  Lennart   |  Owner:  andy@…  
 Type:  bug   | Status:  new 
 Priority:  normal|  Component:  Code Coverage   
  Version:  7.2.2 |   Keywords:  
   Os:  Unknown/Multiple  |   Architecture:  Unknown/Multiple
  Failure:  None/Unknown  |   Testcase:  
Blockedby:|   Blocking:  
  Related:|  
--+-
 In the hpc module Trace.Hpc.Util there is the following code:

 {{{
 instance (HpcHash a,HpcHash b) = HpcHash (a,b) where
   toHash (a,b) = toHash a * 33 `hxor` toHash b
 }}}

 This is bad and I can only presume that what was actually intended was

 {{{
 instance (HpcHash a,HpcHash b) = HpcHash (a,b) where
   toHash (a,b) = (toHash a * 33) `hxor` toHash b
 }}}

 Otherwise a hash of 0 for a will result in a total hash of 0.

-- 
Ticket URL: http://hackage.haskell.org/trac/ghc/ticket/5944
GHC http://www.haskell.org/ghc/
The Glasgow Haskell Compiler

___
Glasgow-haskell-bugs mailing list
Glasgow-haskell-bugs@haskell.org
http://www.haskell.org/mailman/listinfo/glasgow-haskell-bugs