Re: [GHC] #7445: template-haskell : need a good error message instead of just an unexplained panic
#7445: template-haskell : need a good error message instead of just an unexplained panic -+-- Reporter: erikd | Owner: Type: bug | Status: merge Priority: normal| Milestone: Component: Template Haskell | Version: 7.7 Keywords:| Os: Unknown/Multiple Architecture: Unknown/Multiple | Failure: Compile-time crash Difficulty: Unknown |Testcase: th/T7445 Blockedby:|Blocking: Related:| -+-- Changes (by simonpj): * status: new = merge * difficulty: = Unknown * testcase: = th/T7445 -- Ticket URL: http://hackage.haskell.org/trac/ghc/ticket/7445#comment:7 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler ___ Glasgow-haskell-bugs mailing list Glasgow-haskell-bugs@haskell.org http://www.haskell.org/mailman/listinfo/glasgow-haskell-bugs
Re: [GHC] #7445: template-haskell : need a good error message instead of just an unexplained panic
#7445: template-haskell : need a good error message instead of just an unexplained panic -+-- Reporter: erikd | Owner: Type: bug | Status: closed Priority: normal | Milestone: Component: Template Haskell|Version: 7.7 Resolution: fixed | Keywords: Os: Unknown/Multiple| Architecture: Unknown/Multiple Failure: Compile-time crash | Difficulty: Unknown Testcase: th/T7445| Blockedby: Blocking: |Related: -+-- Changes (by igloo): * status: merge = closed * resolution: = fixed Comment: Merged as 1183080b1b45dbcaa6af1154e2e668f924598772 -- Ticket URL: http://hackage.haskell.org/trac/ghc/ticket/7445#comment:8 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler ___ Glasgow-haskell-bugs mailing list Glasgow-haskell-bugs@haskell.org http://www.haskell.org/mailman/listinfo/glasgow-haskell-bugs
Re: [GHC] #7445: template-haskell : need a good error message instead of just an unexplained panic
#7445: template-haskell : need a good error message instead of just an
unexplained
panic
---+
Reporter: erikd | Owner:
Type: bug | Status: new
Priority: normal | Component: Template Haskell
Version: 7.7 | Keywords:
Os: Unknown/Multiple| Architecture: Unknown/Multiple
Failure: Compile-time crash | Blockedby:
Blocking: |Related:
---+
Comment(by simonpj@…):
commit 9a20e540754fc2af74c2e7392f2786a81d8d5f11
{{{
Author: Simon Peyton Jones simo...@microsoft.com
Date: Thu Dec 6 16:03:16 2012 +
Stop attempting to trim data types in interface files
Without -O, we previously tried to make interface files smaller
by not including the data constructors of data types. But
there are a lot of exceptions, notably when Template Haskell is
involved or, more recently, DataKinds.
However Trac #7445 shows that even without TemplateHaskell, using
the Data class and invoking Language.Haskell.TH.Quote.dataToExpQ
is enough to require us to expose the data constructors.
So I've given up on this optimisation -- it's probably not
important anyway. Now I'm simply not attempting to trim off
the data constructors. The gain in simplicity is worth the
modest cost in interface file growth, which is limited to the
bits reqd to describe those data constructors.
compiler/main/TidyPgm.lhs | 207
-
1 files changed, 109 insertions(+), 98 deletions(-)
}}}
--
Ticket URL: http://hackage.haskell.org/trac/ghc/ticket/7445#comment:6
GHC http://www.haskell.org/ghc/
The Glasgow Haskell Compiler
___
Glasgow-haskell-bugs mailing list
Glasgow-haskell-bugs@haskell.org
http://www.haskell.org/mailman/listinfo/glasgow-haskell-bugs
Re: [GHC] #7445: template-haskell : need a good error message instead of just an unexplained panic (was: template-haskell : the impossible happened)
#7445: template-haskell : need a good error message instead of just an
unexplained
panic
---+
Reporter: erikd | Owner:
Type: bug | Status: new
Priority: normal | Component: Template Haskell
Version: 7.6.1 | Keywords:
Os: Unknown/Multiple| Architecture: Unknown/Multiple
Failure: Compile-time crash | Blockedby:
Blocking: |Related:
---+
Comment(by erikd):
Found the problem, for ```QuasiArith.hs``` I had:
{{{
module QuasiArith
( eval
, expr
) where
}}}
If I change the module declaration to:
{{{
module QuasiArith where
}}}
it no longer panics and in fact even works and generates the correct
result.
I'm not sure what was causing it to fail. I tried exporting all top level
functions and values in ```QuasiArith.hs``` and it still failed.
Would in be sensible to disallow restricted exports for all files that
import ```Language.Haskell.TH.Quote```?
--
Ticket URL: http://hackage.haskell.org/trac/ghc/ticket/7445#comment:3
GHC http://www.haskell.org/ghc/
The Glasgow Haskell Compiler
___
Glasgow-haskell-bugs mailing list
Glasgow-haskell-bugs@haskell.org
http://www.haskell.org/mailman/listinfo/glasgow-haskell-bugs
Re: [GHC] #7445: template-haskell : need a good error message instead of just an unexplained panic
#7445: template-haskell : need a good error message instead of just an unexplained panic ---+ Reporter: erikd | Owner: Type: bug | Status: new Priority: normal | Component: Template Haskell Version: 7.7 | Keywords: Os: Unknown/Multiple| Architecture: Unknown/Multiple Failure: Compile-time crash | Blockedby: Blocking: |Related: ---+ Changes (by erikd): * version: 7.6.1 = 7.7 Comment: Confirmed in GHC HEAD as well. -- Ticket URL: http://hackage.haskell.org/trac/ghc/ticket/7445#comment:4 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler ___ Glasgow-haskell-bugs mailing list Glasgow-haskell-bugs@haskell.org http://www.haskell.org/mailman/listinfo/glasgow-haskell-bugs
Re: [GHC] #7445: template-haskell : need a good error message instead of just an unexplained panic
#7445: template-haskell : need a good error message instead of just an
unexplained
panic
---+
Reporter: erikd | Owner:
Type: bug | Status: new
Priority: normal | Component: Template Haskell
Version: 7.7 | Keywords:
Os: Unknown/Multiple| Architecture: Unknown/Multiple
Failure: Compile-time crash | Blockedby:
Blocking: |Related:
---+
Comment(by erikd):
Hmm, this works:
{{{
module QuasiArith
( Expr (..)
, BinOp (..)
, eval
, expr
) where
}}}
Problem seems to have been that type Expr and BinOp were not exported.
--
Ticket URL: http://hackage.haskell.org/trac/ghc/ticket/7445#comment:5
GHC http://www.haskell.org/ghc/
The Glasgow Haskell Compiler
___
Glasgow-haskell-bugs mailing list
Glasgow-haskell-bugs@haskell.org
http://www.haskell.org/mailman/listinfo/glasgow-haskell-bugs
