Re: [Gluster-devel] [Gluster-Maintainers] 'Reviewd-by' tag for commits

2016-10-14 Thread Nigel Babu 
On Fri, Oct 14, 2016 at 10:44:02PM +0530, Pranith Kumar Karampuri wrote:
> How do we get the following tags in the commit message?
>
> > Smoke: Gluster Build System 
> > NetBSD-regression: NetBSD Build System 
> > CentOS-regression: Gluster Build System 

We use Cherry-Pick merge strategy[1]. Gerrit adds a set of metadata based on
that.

I'm in favor of removing the entire metadata in the commit message and moving
to Rebase-If-Necessary merge type which allows patch dependencies to be
enforced by Gerrit. This is an actual problem we run into often.

If we want additional data about what happened in a review request, it should
happen directly from Gerrit via the REST API[2].

[1]: 
http://review.gluster.org/Documentation/project-configuration.html#submit_type
[2]: 
http://review.gluster.org/Documentation/rest-api-changes.html#get-change-detail

--
nigelb
___
Gluster-devel mailing list
Gluster-devel@gluster.org
http://www.gluster.org/mailman/listinfo/gluster-devel

Re: [Gluster-devel] [Gluster-users] opportunist for outreachy

2016-10-14 Thread Pranith Kumar Karampuri 
On Fri, Oct 14, 2016 at 9:27 PM, Shyam  wrote:

> On 10/14/2016 10:48 AM, Manikandan Selvaganesh wrote:
>
>> Hi Soumya,
>>
>> Welcome to the community.
>>
>> Here[1] is the link for Gluster Documentation. I would suggest you to
>> google and
>> read a bit about GlusterFS and then get started with "Quick Start
>> Guide[2]".
>> Once you have done your setup and have played a bit around the
>> installation and
>> configuration move on with "Developers Guide[3]".
>>
>> If you want to get started with Code contributions pick some EasyFix
>> bugs which
>> can be found here[4]. After this I hope you would have got a minimal
>> idea and then
>> explore more in depth and pick up the project/component which interests
>> you more.
>> Again, we have some list of projects[5] already listed, check out if
>> anything interests
>> you here. Feel free to bring your own ideas as well. These are quite
>> generic for anyone
>> who is new to the community and in case if  you want to know
>> specifically about
>> Outreachy, someone in the community will surely respond to you shortly.
>>
>
> Let me take the Outreachy part up.
>
> There are 2 projects there, one relating to the documentation, for which
> Manikandan has filled in some links and thoughts. The other being the
> instrumentation tooling around performance.
>
> For the latter, I would suggest that you get a gluster volume up and
> running, and attempt the GlusterBench.py [6] against it, and start with
> reporting the results. Again, Manikandan has covered getting gluster up and
> running. For any questions, or things that you get stuck on when running
> the bench script, post back here and we will help as needed.
>
>
>> If you have queries, please mail us back. Also, we are always available
>> on #gluster-dev
>> and #gluster-meeting in Freenode.
>>
>> All the best :-)
>>
>> [1] https://gluster.readthedocs.io/en/latest/
>>
>> [2] https://gluster.readthedocs.io/en/latest/Quick-Start-Guide/
>> Quickstart/
>>
>> [3] https://gluster.readthedocs.io/en/latest/Developer-guide/Dev
>> elopers-Index/
>>
>> [4] https://gluster.readthedocs.io/en/latest/Developer-guide/Eas
>> y-Fix-Bugs/
>>
>> [5] https://gluster.readthedocs.io/en/latest/Developer-guide/Projects/
>>
>
> [6] GlusterBench.py : https://github.com/gluster/gbe
> nch/tree/master/bench-tests/bt--0001


Hi Soumya,
I see that the important information is already given by Mani and
Shyam. I went to IIIT-Hyderabad for my Engineering (2003-2007). It is
really good to see you here :-). I will be happy to visit the campus next
time I visit Hyderabad and introduce folks to gluster (I am hoping Linux
Users Group is still as active as it used to be). I heard that our college
is very famous now because of the performances in ACM ICPC, may be we
should make it famous for open-source contributions too in future :-).

All the best!


>
>
>>
>> --
>> Cheers,
>> Manikandan Selvaganesh.
>>
>> On Fri, Oct 14, 2016 at 7:56 PM, Ms ms > > wrote:
>>
>> Hi,
>>
>> I'm a research student pursuing my Masters in IIIT-Hyderabad. I am
>> keen on working on Gluster's Outreachy project.
>>
>> I have prior experience in configuring, maintaining and managing
>> systems in an MHRD project. I have completed the required course
>> credits towards my degree and am working on my Thesis currently. It
>> would be great opportunity for me to learn and contribute to the
>> project as well.
>>
>> As I am a bit new to the community it would be nice if anyone can
>> guide me a few useful resources to get me started.
>>
>> Thanks and regards,
>> Soumya
>>
>> ___
>> Gluster-users mailing list
>> gluster-us...@gluster.org 
>> http://www.gluster.org/mailman/listinfo/gluster-users
>> 
>>
>>
>>
>>
>> ___
>> Gluster-users mailing list
>> gluster-us...@gluster.org
>> http://www.gluster.org/mailman/listinfo/gluster-users
>>
>> ___
> Gluster-devel mailing list
> Gluster-devel@gluster.org
> http://www.gluster.org/mailman/listinfo/gluster-devel
>



-- 
Pranith
___
Gluster-devel mailing list
Gluster-devel@gluster.org
http://www.gluster.org/mailman/listinfo/gluster-devel

[Gluster-devel] Xavi documented how erasure coding algo works

2016-10-14 Thread Pranith Kumar Karampuri 
Your comments are welcome @ http://review.gluster.org/15637

-- 
Pranith
___
Gluster-devel mailing list
Gluster-devel@gluster.org
http://www.gluster.org/mailman/listinfo/gluster-devel

Re: [Gluster-devel] [Gluster-Maintainers] 'Reviewd-by' tag for commits

2016-10-14 Thread Pranith Kumar Karampuri 
How do we get the following tags in the commit message?

> Smoke: Gluster Build System 
> NetBSD-regression: NetBSD Build System 
> CentOS-regression: Gluster Build System 


On Fri, Oct 14, 2016 at 3:14 PM, Niels de Vos  wrote:

> On Fri, Oct 14, 2016 at 02:21:23PM +0530, Nigel Babu wrote:
> > I've said on this thread before, none of this is easy to do. It needs us
> to
> > fork Gerrit to make our own changes. I would argue that depending on the
> > data from the commit message is folly.
>
> Eventhough we all seem to agree that statistics based on commit messages
> is not correct, it looks like it is an incentive to get reviewing valued
> more. We need to promote the reviewing work somehow, and this is one way
> to do it.
>
> Forking Gerrit is surely not the right thing. But could it not get
> discussed with the rest of the Gerrit community? I hope that the Gerrit
> admins follow the Gerrit project and know how to report feature requests
> or such?
>
> Thanks,
> Niels
>
>
> >
> > On Fri, Oct 14, 2016 at 12:23 PM, Niels de Vos 
> wrote:
> >
> > > On Thu, Oct 13, 2016 at 11:01:43PM +0530, Pranith Kumar Karampuri
> wrote:
> > > > On Thu, Oct 6, 2016 at 1:49 AM, Michael Adam 
> wrote:
> > > >
> > > > > On 2016-10-05 at 09:45 -0400, Ira Cooper wrote:
> > > > > > "Feedback-given-by: "
> > > > >
> > > >
> > > > Niels/Nigel,
> > > >Is this easier to do?
> > >
> > > No idea if this can be done by a Gerrit configuration, I'm not an admin
> > > there :)
> > >
> > > I suspect Gerrit gives the option to run a script after someone pressed
> > > the [submit] button for merging, and before the actual commit is pushed
> > > into the branch. If there is no config option, such a hook-script could
> > > be made to work. But, my Gerrit experience on that level is
> > > non-existent, so I can be completely wrong.
> > >
> > > Niels
> > >
> > > >
> > > >
> > > > >
> > > > > I like that one - thanks! :-)
> > > > >
> > > > > Michael
> > > > >
> > > > > > - Original Message -
> > > > > > > On 2016-09-30 at 17:52 +0200, Niels de Vos wrote:
> > > > > > > > On Fri, Sep 30, 2016 at 08:50:12PM +0530, Ravishankar N
> wrote:
> > > > > > > > > On 09/30/2016 06:38 PM, Niels de Vos wrote:
> > > > > > > > > > On Fri, Sep 30, 2016 at 07:11:51AM +0530, Pranith Kumar
> > > Karampuri
> > > > > > > > > > wrote:
> > > > > > > > ...
> > > > > > > > > > Maybe we can add an additional tag that mentions all the
> > > people
> > > > > that
> > > > > > > > > > did do reviews of older versions of the patch. Not sure
> what
> > > the
> > > > > tag
> > > > > > > > > > would be, maybe just CC?
> > > > > > > > > It depends on what tags would be processed to obtain
> > > statistics on
> > > > > review
> > > > > > > > > contributions.
> > > > > > > >
> > > > > > > > Real statistics would come from Gerrit, not from the 'git
> log'
> > > > > output.
> > > > > > > > We do have a ./extras/who-wrote-glusterfs/ in the sources,
> but
> > > that
> > > > > is
> > > > > > > > only to get an idea about the changes that were made and
> should
> > > not
> > > > > be
> > > > > > > > used for serious statistics.
> > > > > > > >
> > > > > > > > It is possible to feed the Gerrit comment-stream into things
> like
> > > > > > > > Elasticsearch and get an accurate impression how many reviews
> > > people
> > > > > do
> > > > > > > > (and much more). I hope we can get some contribution diagrams
> > > from
> > > > > > > > someting like this at one point.
> > > > > > > >
> > > > > > > > Would some kind of Gave-feedback tag for people that left a
> > > comment
> > > > > on
> > > > > > > > earlier versions of the patch be appreciated by others? It
> will
> > > show
> > > > > in
> > > > > > > > the 'git log' who was involved in some way or form.
> > > > > > >
> > > > > > > I think this would be fair.
> > > > > > >
> > > > > > > Reviewed-by tags should imho be reserved for the final
> > > > > > > incarnation of the patch. Those mean that the person named
> > > > > > > in the tag has aproved this version of the patch for getting
> > > > > > > into the official tree. A previous version of the patch can
> > > > > > > have been entirely different, so a reviewed-by for that
> > > > > > > previous version may not actually apply to the new version at
> all
> > > > > > > and hence create a false impression!
> > > > > > >
> > > > > > > It is also difficult to track all activities by tags,
> > > > > > > and anyone who wants to measure performance and contributions
> > > > > > > only by looking at git commit tags will not be doing several
> > > > > > > people justice. We could add 'discussed-with' or 'designed-by'
> > > > > > > tags, etc ... ;-)
> > > > > > >
> > > > > > > On a serious note, in Samba we use 'Pair-programmed-with' tags,
> > > > > > > because we do pair-programming a lot, but only one person can
> > > > > > > be an author of a git commit ...
> > > > > > >
> > > > > > > The 'Gave-feedback' tag I do like. even though it does
> > > > > > > not quite match wit

Re: [Gluster-devel] [Gluster-users] opportunist for outreachy

2016-10-14 Thread Shyam 

On 10/14/2016 10:48 AM, Manikandan Selvaganesh wrote:

Hi Soumya,

Welcome to the community.

Here[1] is the link for Gluster Documentation. I would suggest you to
google and
read a bit about GlusterFS and then get started with "Quick Start
Guide[2]".
Once you have done your setup and have played a bit around the
installation and
configuration move on with "Developers Guide[3]".

If you want to get started with Code contributions pick some EasyFix
bugs which
can be found here[4]. After this I hope you would have got a minimal
idea and then
explore more in depth and pick up the project/component which interests
you more.
Again, we have some list of projects[5] already listed, check out if
anything interests
you here. Feel free to bring your own ideas as well. These are quite
generic for anyone
who is new to the community and in case if  you want to know
specifically about
Outreachy, someone in the community will surely respond to you shortly.


Let me take the Outreachy part up.

There are 2 projects there, one relating to the documentation, for which 
Manikandan has filled in some links and thoughts. The other being the 
instrumentation tooling around performance.


For the latter, I would suggest that you get a gluster volume up and 
running, and attempt the GlusterBench.py [6] against it, and start with 
reporting the results. Again, Manikandan has covered getting gluster up 
and running. For any questions, or things that you get stuck on when 
running the bench script, post back here and we will help as needed.




If you have queries, please mail us back. Also, we are always available
on #gluster-dev
and #gluster-meeting in Freenode.

All the best :-)

[1] https://gluster.readthedocs.io/en/latest/

[2] https://gluster.readthedocs.io/en/latest/Quick-Start-Guide/Quickstart/

[3] https://gluster.readthedocs.io/en/latest/Developer-guide/Developers-Index/

[4] https://gluster.readthedocs.io/en/latest/Developer-guide/Easy-Fix-Bugs/

[5] https://gluster.readthedocs.io/en/latest/Developer-guide/Projects/


[6] GlusterBench.py : 
https://github.com/gluster/gbench/tree/master/bench-tests/bt--0001





--
Cheers,
Manikandan Selvaganesh.

On Fri, Oct 14, 2016 at 7:56 PM, Ms ms mailto:ms.soumy...@gmail.com>> wrote:

Hi,

I'm a research student pursuing my Masters in IIIT-Hyderabad. I am
keen on working on Gluster's Outreachy project.

I have prior experience in configuring, maintaining and managing
systems in an MHRD project. I have completed the required course
credits towards my degree and am working on my Thesis currently. It
would be great opportunity for me to learn and contribute to the
project as well.

As I am a bit new to the community it would be nice if anyone can
guide me a few useful resources to get me started.

Thanks and regards,
Soumya

___
Gluster-users mailing list
gluster-us...@gluster.org 
http://www.gluster.org/mailman/listinfo/gluster-users





___
Gluster-users mailing list
gluster-us...@gluster.org
http://www.gluster.org/mailman/listinfo/gluster-users


___
Gluster-devel mailing list
Gluster-devel@gluster.org
http://www.gluster.org/mailman/listinfo/gluster-devel

Re: [Gluster-devel] [Gluster-users] Weekly Community Meeting 12 Oct 2016 - Minutes

2016-10-14 Thread Shyam 

On 10/13/2016 09:20 AM, Joe Julian wrote:

You forgot to count yourself: 6.

But still ... 6 when there was 60(?) in Berlin seems light. I know the
4am time doesn't work for the west coast of America, but that only
eliminates a very small percentage of those.

What's up, everyone else? Can something change to make participation
possible for you?


It would be a crime not to respond :)

This falls bang at 8:00 AM (eastern TZ) for me, and I have kid duties at 
that particular hour. 8:30 AM Eastern would be just fine, or earlier, 
but this is just me.


I read the meeting notes religiously every week though (just stating, in 
case that counts towards not absolving my duties).




On October 13, 2016 4:36:38 AM PDT, "Kaleb S. KEITHLEY"
 wrote:

Hi all,

Thank you to the five participants in today's community meeting. The
next meeting is scheduled next week (October 19th) at #gluster-meeting.

___
Gluster-devel mailing list
Gluster-devel@gluster.org
http://www.gluster.org/mailman/listinfo/gluster-devel

Re: [Gluster-devel] [Gluster-users] opportunist for outreachy

2016-10-14 Thread Manikandan Selvaganesh 
Hi Soumya,

Welcome to the community.

Here[1] is the link for Gluster Documentation. I would suggest you to
google and
read a bit about GlusterFS and then get started with "Quick Start
Guide[2]".
Once you have done your setup and have played a bit around the installation
and
configuration move on with "Developers Guide[3]".

If you want to get started with Code contributions pick some EasyFix bugs
which
can be found here[4]. After this I hope you would have got a minimal idea
and then
explore more in depth and pick up the project/component which interests you
more.
Again, we have some list of projects[5] already listed, check out if
anything interests
you here. Feel free to bring your own ideas as well. These are quite
generic for anyone
who is new to the community and in case if  you want to know specifically
about
Outreachy, someone in the community will surely respond to you shortly.

If you have queries, please mail us back. Also, we are always available on
#gluster-dev
and #gluster-meeting in Freenode.

All the best :-)

[1] https://gluster.readthedocs.io/en/latest/

[2] https://gluster.readthedocs.io/en/latest/Quick-Start-Guide/Quickstart/

[3]
https://gluster.readthedocs.io/en/latest/Developer-guide/Developers-Index/

[4] https://gluster.readthedocs.io/en/latest/Developer-guide/Easy-Fix-Bugs/

[5] https://gluster.readthedocs.io/en/latest/Developer-guide/Projects/


--
Cheers,
Manikandan Selvaganesh.

On Fri, Oct 14, 2016 at 7:56 PM, Ms ms  wrote:

> Hi,
>
> I'm a research student pursuing my Masters in IIIT-Hyderabad. I am keen on
> working on Gluster's Outreachy project.
>
> I have prior experience in configuring, maintaining and managing systems
> in an MHRD project. I have completed the required course credits towards my
> degree and am working on my Thesis currently. It would be great opportunity
> for me to learn and contribute to the project as well.
>
> As I am a bit new to the community it would be nice if anyone can guide me
> a few useful resources to get me started.
>
> Thanks and regards,
> Soumya
>
> ___
> Gluster-users mailing list
> gluster-us...@gluster.org
> http://www.gluster.org/mailman/listinfo/gluster-users
>
___
Gluster-devel mailing list
Gluster-devel@gluster.org
http://www.gluster.org/mailman/listinfo/gluster-devel

Re: [Gluster-devel] [Gluster-Maintainers] 'Reviewd-by' tag for commits

2016-10-14 Thread Niels de Vos 
On Fri, Oct 14, 2016 at 02:21:23PM +0530, Nigel Babu wrote:
> I've said on this thread before, none of this is easy to do. It needs us to
> fork Gerrit to make our own changes. I would argue that depending on the
> data from the commit message is folly.

Eventhough we all seem to agree that statistics based on commit messages
is not correct, it looks like it is an incentive to get reviewing valued
more. We need to promote the reviewing work somehow, and this is one way
to do it.

Forking Gerrit is surely not the right thing. But could it not get
discussed with the rest of the Gerrit community? I hope that the Gerrit
admins follow the Gerrit project and know how to report feature requests
or such?

Thanks,
Niels


> 
> On Fri, Oct 14, 2016 at 12:23 PM, Niels de Vos  wrote:
> 
> > On Thu, Oct 13, 2016 at 11:01:43PM +0530, Pranith Kumar Karampuri wrote:
> > > On Thu, Oct 6, 2016 at 1:49 AM, Michael Adam  wrote:
> > >
> > > > On 2016-10-05 at 09:45 -0400, Ira Cooper wrote:
> > > > > "Feedback-given-by: "
> > > >
> > >
> > > Niels/Nigel,
> > >Is this easier to do?
> >
> > No idea if this can be done by a Gerrit configuration, I'm not an admin
> > there :)
> >
> > I suspect Gerrit gives the option to run a script after someone pressed
> > the [submit] button for merging, and before the actual commit is pushed
> > into the branch. If there is no config option, such a hook-script could
> > be made to work. But, my Gerrit experience on that level is
> > non-existent, so I can be completely wrong.
> >
> > Niels
> >
> > >
> > >
> > > >
> > > > I like that one - thanks! :-)
> > > >
> > > > Michael
> > > >
> > > > > - Original Message -
> > > > > > On 2016-09-30 at 17:52 +0200, Niels de Vos wrote:
> > > > > > > On Fri, Sep 30, 2016 at 08:50:12PM +0530, Ravishankar N wrote:
> > > > > > > > On 09/30/2016 06:38 PM, Niels de Vos wrote:
> > > > > > > > > On Fri, Sep 30, 2016 at 07:11:51AM +0530, Pranith Kumar
> > Karampuri
> > > > > > > > > wrote:
> > > > > > > ...
> > > > > > > > > Maybe we can add an additional tag that mentions all the
> > people
> > > > that
> > > > > > > > > did do reviews of older versions of the patch. Not sure what
> > the
> > > > tag
> > > > > > > > > would be, maybe just CC?
> > > > > > > > It depends on what tags would be processed to obtain
> > statistics on
> > > > review
> > > > > > > > contributions.
> > > > > > >
> > > > > > > Real statistics would come from Gerrit, not from the 'git log'
> > > > output.
> > > > > > > We do have a ./extras/who-wrote-glusterfs/ in the sources, but
> > that
> > > > is
> > > > > > > only to get an idea about the changes that were made and should
> > not
> > > > be
> > > > > > > used for serious statistics.
> > > > > > >
> > > > > > > It is possible to feed the Gerrit comment-stream into things like
> > > > > > > Elasticsearch and get an accurate impression how many reviews
> > people
> > > > do
> > > > > > > (and much more). I hope we can get some contribution diagrams
> > from
> > > > > > > someting like this at one point.
> > > > > > >
> > > > > > > Would some kind of Gave-feedback tag for people that left a
> > comment
> > > > on
> > > > > > > earlier versions of the patch be appreciated by others? It will
> > show
> > > > in
> > > > > > > the 'git log' who was involved in some way or form.
> > > > > >
> > > > > > I think this would be fair.
> > > > > >
> > > > > > Reviewed-by tags should imho be reserved for the final
> > > > > > incarnation of the patch. Those mean that the person named
> > > > > > in the tag has aproved this version of the patch for getting
> > > > > > into the official tree. A previous version of the patch can
> > > > > > have been entirely different, so a reviewed-by for that
> > > > > > previous version may not actually apply to the new version at all
> > > > > > and hence create a false impression!
> > > > > >
> > > > > > It is also difficult to track all activities by tags,
> > > > > > and anyone who wants to measure performance and contributions
> > > > > > only by looking at git commit tags will not be doing several
> > > > > > people justice. We could add 'discussed-with' or 'designed-by'
> > > > > > tags, etc ... ;-)
> > > > > >
> > > > > > On a serious note, in Samba we use 'Pair-programmed-with' tags,
> > > > > > because we do pair-programming a lot, but only one person can
> > > > > > be an author of a git commit ...
> > > > > >
> > > > > > The 'Gave-feedback' tag I do like. even though it does
> > > > > > not quite match with the foobar-by pattern of other tags.
> > > > > >
> > > > > > Michael
> > > > > >
> > > > > > ___
> > > > > > Gluster-devel mailing list
> > > > > > Gluster-devel@gluster.org
> > > > > > http://www.gluster.org/mailman/listinfo/gluster-devel
> > > >
> > > > ___
> > > > maintainers mailing list
> > > > maintain...@gluster.org
> > > > http://www.gluster.org/mailman/listinfo/maintainers
> > > >
> > > >
> >

Re: [Gluster-devel] [Gluster-Maintainers] 'Reviewd-by' tag for commits

2016-10-14 Thread Nigel Babu 
I've said on this thread before, none of this is easy to do. It needs us to
fork Gerrit to make our own changes. I would argue that depending on the
data from the commit message is folly.

On Fri, Oct 14, 2016 at 12:23 PM, Niels de Vos  wrote:

> On Thu, Oct 13, 2016 at 11:01:43PM +0530, Pranith Kumar Karampuri wrote:
> > On Thu, Oct 6, 2016 at 1:49 AM, Michael Adam  wrote:
> >
> > > On 2016-10-05 at 09:45 -0400, Ira Cooper wrote:
> > > > "Feedback-given-by: "
> > >
> >
> > Niels/Nigel,
> >Is this easier to do?
>
> No idea if this can be done by a Gerrit configuration, I'm not an admin
> there :)
>
> I suspect Gerrit gives the option to run a script after someone pressed
> the [submit] button for merging, and before the actual commit is pushed
> into the branch. If there is no config option, such a hook-script could
> be made to work. But, my Gerrit experience on that level is
> non-existent, so I can be completely wrong.
>
> Niels
>
> >
> >
> > >
> > > I like that one - thanks! :-)
> > >
> > > Michael
> > >
> > > > - Original Message -
> > > > > On 2016-09-30 at 17:52 +0200, Niels de Vos wrote:
> > > > > > On Fri, Sep 30, 2016 at 08:50:12PM +0530, Ravishankar N wrote:
> > > > > > > On 09/30/2016 06:38 PM, Niels de Vos wrote:
> > > > > > > > On Fri, Sep 30, 2016 at 07:11:51AM +0530, Pranith Kumar
> Karampuri
> > > > > > > > wrote:
> > > > > > ...
> > > > > > > > Maybe we can add an additional tag that mentions all the
> people
> > > that
> > > > > > > > did do reviews of older versions of the patch. Not sure what
> the
> > > tag
> > > > > > > > would be, maybe just CC?
> > > > > > > It depends on what tags would be processed to obtain
> statistics on
> > > review
> > > > > > > contributions.
> > > > > >
> > > > > > Real statistics would come from Gerrit, not from the 'git log'
> > > output.
> > > > > > We do have a ./extras/who-wrote-glusterfs/ in the sources, but
> that
> > > is
> > > > > > only to get an idea about the changes that were made and should
> not
> > > be
> > > > > > used for serious statistics.
> > > > > >
> > > > > > It is possible to feed the Gerrit comment-stream into things like
> > > > > > Elasticsearch and get an accurate impression how many reviews
> people
> > > do
> > > > > > (and much more). I hope we can get some contribution diagrams
> from
> > > > > > someting like this at one point.
> > > > > >
> > > > > > Would some kind of Gave-feedback tag for people that left a
> comment
> > > on
> > > > > > earlier versions of the patch be appreciated by others? It will
> show
> > > in
> > > > > > the 'git log' who was involved in some way or form.
> > > > >
> > > > > I think this would be fair.
> > > > >
> > > > > Reviewed-by tags should imho be reserved for the final
> > > > > incarnation of the patch. Those mean that the person named
> > > > > in the tag has aproved this version of the patch for getting
> > > > > into the official tree. A previous version of the patch can
> > > > > have been entirely different, so a reviewed-by for that
> > > > > previous version may not actually apply to the new version at all
> > > > > and hence create a false impression!
> > > > >
> > > > > It is also difficult to track all activities by tags,
> > > > > and anyone who wants to measure performance and contributions
> > > > > only by looking at git commit tags will not be doing several
> > > > > people justice. We could add 'discussed-with' or 'designed-by'
> > > > > tags, etc ... ;-)
> > > > >
> > > > > On a serious note, in Samba we use 'Pair-programmed-with' tags,
> > > > > because we do pair-programming a lot, but only one person can
> > > > > be an author of a git commit ...
> > > > >
> > > > > The 'Gave-feedback' tag I do like. even though it does
> > > > > not quite match with the foobar-by pattern of other tags.
> > > > >
> > > > > Michael
> > > > >
> > > > > ___
> > > > > Gluster-devel mailing list
> > > > > Gluster-devel@gluster.org
> > > > > http://www.gluster.org/mailman/listinfo/gluster-devel
> > >
> > > ___
> > > maintainers mailing list
> > > maintain...@gluster.org
> > > http://www.gluster.org/mailman/listinfo/maintainers
> > >
> > >
> >
> >
> > --
> > Pranith
>
> > ___
> > maintainers mailing list
> > maintain...@gluster.org
> > http://www.gluster.org/mailman/listinfo/maintainers
>
>
> ___
> maintainers mailing list
> maintain...@gluster.org
> http://www.gluster.org/mailman/listinfo/maintainers
>
>


-- 
nigelb
___
Gluster-devel mailing list
Gluster-devel@gluster.org
http://www.gluster.org/mailman/listinfo/gluster-devel

[Gluster-devel] Check the possibility to incorporate DEBUG info permanently in build

2016-10-14 Thread ABHISHEK PALIWAL 
Hi Team,

As we are seeing many issues in gluster. And we are failing to address most
of the gluster issues due to lack of information for fault analysis.

And for the many issue unfortunately with the initial gluster logs we get a
very limited information which is not at all possible to find the root
cause/conclude the issue.
Every time enabling the LOG_LEVEL to DEBUG is not feasible and few of the
cases are very rarely seen.

Hence, I request you to check if there is a possibility  to incorporate the
debug information in build or check if its possible to introduce a new
debug level that can always be activated.

Please come back on this!

-- 

Regards
Abhishek Paliwal
___
Gluster-devel mailing list
Gluster-devel@gluster.org
http://www.gluster.org/mailman/listinfo/gluster-devel

Re: [Gluster-devel] Issue about the size of fstat is less than the really size of the syslog file

2016-10-14 Thread Lian, George (Nokia - CN/Hangzhou) 
Hi, Raghavendra,

Our version of GlusterFS is 3.6.9, and I also check the newest code of main 
branch, the function of " mdc_inode_iatt_set_validate" is almost same, from the 
following code of this function, 
We could see a "TODO" comments inline, does it mean if we enhance write-behind 
feature, the "iatt" field in callback will be NULL, so that inode_invalidate 
will not be called? So the size of file will not update since "write behind" 
enabled ?
Is it the root cause for "tail" application failed with "file truncated" issue ?

LOCK (&mdc->lock);
{
if (!iatt || !iatt->ia_ctime) {
mdc->ia_time = 0;
goto unlock;
}

/*
 * Invalidate the inode if the mtime or ctime has changed
 * and the prebuf doesn't match the value we have cached.
 * TODO: writev returns with a NULL iatt due to
 * performance/write-behind, causing invalidation on writes.
 */
if (IA_ISREG(inode->ia_type) &&
((iatt->ia_mtime != mdc->md_mtime) ||
(iatt->ia_ctime != mdc->md_ctime)))
if (!prebuf || (prebuf->ia_ctime != mdc->md_ctime) ||
(prebuf->ia_mtime != mdc->md_mtime))
inode_invalidate(inode);

mdc_from_iatt (mdc, iatt);

time (&mdc->ia_time);
}

Best Regards,
George
-Original Message-
From: Raghavendra Gowdappa [mailto:rgowd...@redhat.com] 
Sent: Thursday, October 13, 2016 8:58 PM
To: Lian, George (Nokia - CN/Hangzhou) 
Cc: Gluster-devel@gluster.org; I_EXT_MBB_WCDMA_SWD3_DA1_MATRIX_GMS 
; Zhang, Bingxuan (Nokia - 
CN/Hangzhou) ; Zizka, Jan (Nokia - CZ/Prague) 

Subject: Re: [Gluster-devel] Issue about the size of fstat is less than the 
really size of the syslog file



- Original Message -
> From: "George Lian (Nokia - CN/Hangzhou)" 
> To: Gluster-devel@gluster.org
> Cc: "I_EXT_MBB_WCDMA_SWD3_DA1_MATRIX_GMS" 
> , "Bingxuan Zhang (Nokia
> - CN/Hangzhou)" , "Jan Zizka (Nokia - CZ/Prague)" 
> 
> Sent: Thursday, October 13, 2016 2:33:53 PM
> Subject: [Gluster-devel] Issue about the size of fstat is less than the 
> really size of the syslog file
> 
> Hi, Dear Expert,
> We have use glusterfs as a network filesystem, and syslog store in there,
> some clients on different host may write the syslog file via “glusterfs”
> mount point.
> Now we encounter an issue when we “tail” the syslog file, it will occasional
> failed with error “ file truncated ”
> As we study and trace with the “tail” source code, it failed with the
> following code:
> if ( S_ISREG (mode) && stats.st_size < f[i].size )
> {
> error (0, 0, _("%s: file truncated"), quotef (name));
> /* Assume the file was truncated to 0,
> and therefore output all "new" data. */
> xlseek (fd, 0, SEEK_SET, name);
> f[i].size = 0;
> }
> When stats.st_size < f[i].size, what mean the size report by fstat is less
> than “tail” had read, it lead to “file truncated”, we also use “strace”
> tools to trace the tail application, the related tail strace log as the
> below:
> nanosleep({1, 0}, NULL) = 0
> fstat(3, {st_mode=S_IFREG|0644, st_size=192543105, ...}) = 0
> nanosleep({1, 0}, NULL) = 0
> fstat(3, {st_mode=S_IFREG|0644, st_size=192543105, ...}) = 0
> nanosleep({1, 0}, NULL) = 0
> fstat(3, {st_mode=S_IFREG|0644, st_size=192543105, ...}) = 0
> nanosleep({1, 0}, NULL) = 0
> fstat(3, {st_mode=S_IFREG|0644, st_size=192544549, ...}) = 0
> read(3, " Data … -"..., 8192) = 1444
> read(3, " Data.. "..., 8192) = 720
> read(3, "", 8192) = 0
> fstat(3, {st_mode=S_IFREG|0644, st_size=192544789, ...}) = 0
> write(1, “DATA…..” ) = 2164
> write(2, "tail: ", 6tail: ) = 6
> write(2, "/mnt/log/master/syslog: file tru"..., 38/mnt/log/master/syslog:
> file truncated) = 38
> as the above strace log, tail has read 1444+720=2164 bytes,
> but fstat tell “tail” 192544789 – 192543105 = 1664 which less than 2164, so
> it lead to “tail” application “file truncated”.
> And if we turn off “write-behind” feature, the issue will not be reproduced
> any more.

That seems strange. There are no writes happening on the fd/inode through which 
tail is reading/stating from. So, it seems strange that write-behind is 
involved here. I suspect whether any of md-cache/read-ahead/io-cache is causing 
the issue. Can you,

1. Turn off md-cache, read-ahead, io-cache xlators
2. mount glusterfs with --attribute-timeout=0
3. set write-behind on

and rerun the tests? If you don't hit the issue, you can experiment by turning 
on/off of md-cache, read-ahead and io-cache translators and see what are the 
minimal number of xlators that need to be turned off to not hit the issue (with 
write-behind on)?

regards,
Raghavendra

> So we think it may be related to cache consistence issue due to performance
> consider, but we still have concern that:
> The syslog file is used