Re: [Gluster-devel] [Gluster-Maintainers] Update: Gerrit review system has one more command now

2018-05-21 Thread Kotresh Hiremath Ravishankar 
This will be very useful. Thank you.

On Mon, May 21, 2018 at 11:45 PM, Vijay Bellur  wrote:

>
>
> On Mon, May 21, 2018 at 2:29 AM, Amar Tumballi 
> wrote:
>
>> Hi all,
>>
>> As a push towards more flexibility to our developers, and options to run
>> more tests without too much effort, we are moving towards more and more
>> options to trigger tests from Gerrit during reviews.
>>
>> One such example was 'regression-on-demand-multiplex' tests, where any
>> one can ask for a brick-mux regression for a particular patch.
>>
>> In the same way, in certain cases where developers are making changes,
>> and more than 1 tests would be impacted, there was no easy way to run all
>> the regression, other than sending one patchset with changes to
>> 'run-tests.sh' to not fail on failures. This was tedious, and also is not
>> known to many new developers. Hence a new command is added to gerrit, where
>> one can trigger all the runs (if something is failing), by entering *'run
>> full regression'* in a single line at the top of your review comments.
>>
>> With this, a separate job will be triggered which will run the full
>> regression suite with the patch. So, no more requirement to make
>> 'run-tests.sh' changes.
>>
>> More on this at http://bugzilla.redhat.com/1564119
>>
>>
>>
>
> Thank you, Amar! I think it will be quite useful for us.
>
> I am not sure if there's a document that details all possible options &
> tricks with gerrit. If there's none, we could add one to our
> repository/developer-guide so that new developers find it easy to use these
> options.
>
> Regards,
> Vijay
>
> ___
> Gluster-devel mailing list
> Gluster-devel@gluster.org
> http://lists.gluster.org/mailman/listinfo/gluster-devel
>



-- 
Thanks and Regards,
Kotresh H R
___
Gluster-devel mailing list
Gluster-devel@gluster.org
http://lists.gluster.org/mailman/listinfo/gluster-devel

Re: [Gluster-devel] [Gluster-Maintainers] Update: Gerrit review system has one more command now

2018-05-21 Thread Vijay Bellur 
On Mon, May 21, 2018 at 2:29 AM, Amar Tumballi  wrote:

> Hi all,
>
> As a push towards more flexibility to our developers, and options to run
> more tests without too much effort, we are moving towards more and more
> options to trigger tests from Gerrit during reviews.
>
> One such example was 'regression-on-demand-multiplex' tests, where any
> one can ask for a brick-mux regression for a particular patch.
>
> In the same way, in certain cases where developers are making changes, and
> more than 1 tests would be impacted, there was no easy way to run all the
> regression, other than sending one patchset with changes to 'run-tests.sh'
> to not fail on failures. This was tedious, and also is not known to many
> new developers. Hence a new command is added to gerrit, where one can
> trigger all the runs (if something is failing), by entering *'run full
> regression'* in a single line at the top of your review comments.
>
> With this, a separate job will be triggered which will run the full
> regression suite with the patch. So, no more requirement to make
> 'run-tests.sh' changes.
>
> More on this at http://bugzilla.redhat.com/1564119
>
>
>

Thank you, Amar! I think it will be quite useful for us.

I am not sure if there's a document that details all possible options &
tricks with gerrit. If there's none, we could add one to our
repository/developer-guide so that new developers find it easy to use these
options.

Regards,
Vijay
___
Gluster-devel mailing list
Gluster-devel@gluster.org
http://lists.gluster.org/mailman/listinfo/gluster-devel

[Gluster-devel] Update: Gerrit review system has one more command now

2018-05-21 Thread Amar Tumballi 
Hi all,

As a push towards more flexibility to our developers, and options to run
more tests without too much effort, we are moving towards more and more
options to trigger tests from Gerrit during reviews.

One such example was 'regression-on-demand-multiplex' tests, where any one
can ask for a brick-mux regression for a particular patch.

In the same way, in certain cases where developers are making changes, and
more than 1 tests would be impacted, there was no easy way to run all the
regression, other than sending one patchset with changes to 'run-tests.sh'
to not fail on failures. This was tedious, and also is not known to many
new developers. Hence a new command is added to gerrit, where one can
trigger all the runs (if something is failing), by entering *'run full
regression'* in a single line at the top of your review comments.

With this, a separate job will be triggered which will run the full
regression suite with the patch. So, no more requirement to make
'run-tests.sh' changes.

More on this at http://bugzilla.redhat.com/1564119

Regards,
Amar

-- 
Amar Tumballi (amarts)
___
Gluster-devel mailing list
Gluster-devel@gluster.org
http://lists.gluster.org/mailman/listinfo/gluster-devel